Adding magma linux build #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janeyx99
reviewed
Nov 22, 2021
| env: | ||
| DOCKER_REGISTRY: "docker.io" | ||
| DOCKER_BUILDKIT: 1 | ||
| DOCKER_ID: ${{ secrets.DOCKER_ID }} |
There was a problem hiding this comment.
Are these secrets properly set up?
There was a problem hiding this comment.
If so, aren't we pushing to conda?
There was a problem hiding this comment.
I think secrets are properly setup. We can certainly push to conda. What username/password do we use for pushing to Conda ? Do we have a group level user/password ? If not perhaps I can go ahead and create the user that we can store in the secrets.
There was a problem hiding this comment.
I think the only credentials are our individual account username/password currently--we already have a pytorchbot anaconda user that we can perhaps give the permissions to if @seemethere also agrees?
janeyx99
reviewed
Nov 22, 2021
janeyx99
approved these changes
Nov 22, 2021
seemethere
reviewed
Nov 22, 2021
atalman
force-pushed
the
main
branch
11 times, most recently
from
db913db to
3d71e4f
Compare
seemethere
approved these changes
Nov 23, 2021
janeyx99
approved these changes
Nov 23, 2021
Co-authored-by: Jane (Yuan) Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.