-
-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bleu metric #1834
Add bleu metric #1834
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @sdesrozis , thanks
I have few comments here and
do we need empty ignite/metrics/nlp/utils.py
here ?
The utils.py file holds the modified_precision function used in compute_corpus method line 131. Maybe the method has not been moved to utils.py yet. Also, this file can be used to store common nlp pre-processing which we can provide as options when calculating ROUGE or BLEU or other metrics in the future. |
This file should not be empty!! Let me see. EDIT ok I don't know why this file was not committed correctly. I do it asap. |
@vfdev-5 did you ever face flaky codecov failure ? |
@sdesrozis yes, codecov is start failing today |
I think we have the same issue as here codecov/codecov-action#234 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for great PR @sdesrozis 💪 LGTM
You can merge it once CI is done.
Description:
Add BLEU metric. Refactor to introduce
nlp
module inmetrics
. Rouge metric has been moved innlp
.The implementation is inspired from
nltk
.Check list: