Skip to content

Commit

Permalink
Re-word LOG message for Record Counters from Error info to Record cou…
Browse files Browse the repository at this point in the history
…nts (#848)

Summary:
Pull Request resolved: #848

This LOG message has been causing a lot of confusion across production jobs. People are seeing the Error info message, and believe the profiler is breaking something. This is actually a harmless message, that shows detailed record counts.

The loggers also mark Error keyword line in red, making it stand out as an Error message.

Test Plan: CI , this is essentially a no-op.

Reviewed By: anupambhatnagar

Differential Revision: D51950718

Pulled By: aaronenyeshi

fbshipit-source-id: 8d865c419065207af8f701b923cb07317a444e48
  • Loading branch information
aaronenyeshi authored and facebook-github-bot committed Dec 8, 2023
1 parent 5992865 commit fea669c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion libkineto/src/CuptiActivityProfiler.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ void CuptiActivityProfiler::processTraceInternal(ActivityLogger& logger) {
session->processTrace(logger);
}

LOG(INFO) << "Error info: " << ecs_;
LOG(INFO) << "Record counts: " << ecs_;

finalizeTrace(*config_, logger);
}
Expand Down

0 comments on commit fea669c

Please sign in to comment.