Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EZ] Remove remaining amz2023 runner variant references #136540

Closed
wants to merge 1 commit into from

Conversation

ZainRizvi
Copy link
Contributor

@ZainRizvi ZainRizvi commented Sep 24, 2024

Copy link

pytorch-bot bot commented Sep 24, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136540

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit a3944e7 with merge base 32727b9 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@malfet
Copy link
Contributor

malfet commented Sep 24, 2024

It would be nice to specify which PR removed suffixes in the first place, and if there are less than a week between that PR and this one, I would have waited, as PRs based on older commits would try to schedule something on those

@ZainRizvi
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 25, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

BoyuanFeng pushed a commit to BoyuanFeng/pytorch that referenced this pull request Sep 25, 2024
Validated no jobs use the amz2023 runner variant anymore ([proof](https://github.com/search?type=code&q=org%3Apytorch+%2F%5Cbamz2023%5Cb%2F+&p=1)) so removing all references to it

Explicit references to the amz2023 runner type variants were removed in the following PRs:
- pytorch/ignite#3285
- pytorch/ao#887
- pytorch/fbscribelogger#1
- pytorch#134355

Pull Request resolved: pytorch#136540
Approved by: https://github.com/huydhn, https://github.com/malfet
ZainRizvi added a commit to pytorch/test-infra that referenced this pull request Sep 26, 2024
Validated no jobs use the amz2023 runner variant anymore
([proof](https://github.com/search?type=code&q=org%3Apytorch+%2F%5Cbamz2023%5Cb%2F+&p=1))
so removing all references to it

Note: The Scale Config Validator job will only pass after
pytorch/pytorch#136540 is merged
@github-actions github-actions bot deleted the zainr/ami-cleanup-2 branch October 27, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants