Pin markdown version to fix broken doc build #1750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agunapal
approved these changes
Jul 20, 2022
maaquib
approved these changes
Jul 20, 2022
svekars
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Markdown 3.4 has made some breaking changes ryanfox/sphinx-markdown-tables#36 which broke our doc build https://github.com/pytorch/serve/actions/workflows/doc-automation.yml so we right now we can't update our documentation
So suggestion for now is to pick an earlier version from ryanfox/sphinx-markdown-tables#36
Fixes #1744
Type of change
Please delete options that are not relevant.
Feature/Issue validation/testing
About 7 different people have confirmed this works for them ryanfox/sphinx-markdown-tables#36
Checklist: