Add submodule input for build_wheels_*.yaml
#5095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
facebook-github-bot
added
the
CLA Signed
dbort
commented
Apr 12, 2024
| type: boolean | ||
| default: true | ||
| build-platform: | ||
| description: Platform to build wheels, choose from 'python-build-package' or 'setup-py' |
There was a problem hiding this comment.
My editor auto-removed trailing whitespace in a few places
huydhn
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
There is also https://github.com/pytorch/test-infra/blob/main/.github/workflows/build_wheels_windows.yml to complete the set
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Let users of `build_wheels_*.yml` override the `submodules` input of `setup-binary-build`. pytorch/executorch does not need (or want) to do a full recursive submodule checkout.
dbort
force-pushed
the
dbort/wheel-submodules
branch
from
0eaa31a to
8db7687
Compare
Whoops right! Fixed. |
dbort
added a commit
to dbort/pytorch-test-infra
that referenced
this pull request
Apr 12, 2024
Let users of `build_wheels_*.yml` override the `submodules` input of `setup-binary-build`. pytorch/executorch does not need (or want) to do a full recursive submodule checkout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let users of
build_wheels_*.ymloverride thesubmodulesinput ofsetup-binary-build.pytorch/executorch does not need (or want) to do a full recursive submodule checkout.