Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Gemma tokenizer] Ensure eos_token is not added if add_eos=False #1480

Closed
joecummings opened this issue Sep 3, 2024 · 0 comments · Fixed by #1806
Closed

[Gemma tokenizer] Ensure eos_token is not added if add_eos=False #1480

joecummings opened this issue Sep 3, 2024 · 0 comments · Fixed by #1806
Labels
bug Something isn't working community help wanted We would love the community's help completing this issue good first issue Good for newcomers

Comments

@joecummings
Copy link
Contributor

Fix similar to #1477
@joecummings joecummings added bug Something isn't working good first issue Good for newcomers community help wanted We would love the community's help completing this issue labels Sep 3, 2024
@joecummings joecummings linked a pull request Sep 20, 2024 that will close this issue
[BUG] Fix basic tokenizer no special tokens #1640
Merged
13 tasks
@joecummings joecummings removed a link to a pull request Sep 20, 2024
[BUG] Fix basic tokenizer no special tokens #1640
Merged
13 tasks
@krammnic krammnic mentioned this issue Oct 11, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working community help wanted We would love the community's help completing this issue good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix eos_token problem in all required models krammnic/torchtune
1 participant
@joecummings