Fix eos_token problem in all required models #1806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1806
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 33c6d54 with merge base c5b7386 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
Actually, I think that tests with this big lists of token ids should be refactored(maybe some fixture?). |
|
@RdoubleA @joecummings Require review |
joecummings
reviewed
Oct 11, 2024
torchtune/models/phi3/_tokenizer.py
Outdated
| @@ -101,13 +101,11 @@ def encode( | |||
| trim_leading_whitespace=trim_leading_whitespace, | |||
| ) | |||
|
|
|||
| def decode(self, ids: List[int], skip_special_tokens: bool = True) -> str: | |||
There was a problem hiding this comment.
Why did you remove skip_special_tokens?
There was a problem hiding this comment.
Weird, maybe accidentally removed. Let me fix
Will think about it more and maybe open PR |
|
Something really weird. |
mori360
pushed a commit
to mori360/torchtune
that referenced
this pull request
Oct 14, 2024
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
What is the purpose of this PR? Is it to
Please link to any issues this PR addresses.
Changelog
What are the changes made in this PR?
Closes #1478
Closes #1479
Closes #1480
Closes #1481
Test plan
Please make sure to do each of the following if applicable to your PR. If you're unsure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.
pre-commit install)pytest testspytest tests -m integration_testUX
If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Here is a docstring example
and a tutorial example
So generally for Mistral and Gemma - just check to pass None if add_eos = False in
tokenize_messages_no_special_tokensFor Qwen and Phi - same check as in #1477 in truncate(actually for Phi should be reviewed in more accurate way)
And 4 unittests for all models.