-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create CITATION.cff #1756
Create CITATION.cff #1756
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1756
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 37fd1c0 with merge base a8a64ec (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
CITATION.cff
Outdated
@@ -0,0 +1,9 @@ | |||
cff-version: 1.2.0 | |||
title: "torchtune: the PyTorch native finetuning library" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
title: "torchtune: the PyTorch native finetuning library" | |
title: "torchtune: a PyTorch native finetuning library" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't like being THE finetuning library?? 🥹
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or we can split the difference and say "PyTorch's finetuning library"
Should we also add a section in the README? |
added |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1756 +/- ##
==========================================
- Coverage 69.33% 67.33% -2.00%
==========================================
Files 305 305
Lines 15892 15961 +69
==========================================
- Hits 11018 10747 -271
- Misses 4874 5214 +340 ☔ View full report in Codecov by Sentry. |
"a finetuning library" bestows us with a modest sagaciousness Think we just need to link to the section in the readme heading ( Line 10 in a8a64ec
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment, otherwise looks good
👀