Add offloading tests and fix obscure edge case #1860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1860
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit c14aa1a with merge base 7d29c21 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1860 +/- ##
==========================================
+ Coverage 67.30% 67.33% +0.03%
==========================================
Files 304 305 +1
Lines 16000 16034 +34
==========================================
+ Hits 10768 10797 +29
- Misses 5232 5237 +5 ☔ View full report in Codecov by Sentry. |
| # memory usage, but this case should not happen often. | ||
| unpacked_tensor = self.bwd_tensor_stash[unpack_tensor_id] | ||
| if any( | ||
| o.untyped_storage() is unpacked_tensor.untyped_storage() |
There was a problem hiding this comment.
When I run with this, I get:
o.untyped_storage() is unpacked_tensor.untyped_storage()
AttributeError: 'NoneType' object has no attribute 'untyped_storage'
I think o can be None.
There was a problem hiding this comment.
Good catch thanks! Should be updated in latest commit
janeyx99
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
What is the purpose of this PR? Is it to
Please link to any issues this PR addresses.
Changelog
What are the changes made in this PR?
Test plan
Please make sure to do each of the following if applicable to your PR. If you're unsure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.
pre-commit install)pytest testspytest tests -m integration_testUX
If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Here is a docstring example
and a tutorial example