Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CLA note to CONTRIBUTING.md #8014

Merged
merged 5 commits into from
Oct 4, 2023
Merged

Add CLA note to CONTRIBUTING.md #8014

merged 5 commits into from
Oct 4, 2023

Conversation

joshlk
Copy link
Contributor

@joshlk joshlk commented Oct 3, 2023

Fixes #8006

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 3, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8014

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 17 Unrelated Failures

As of commit b28b665 with merge base ddfee23 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@joshlk joshlk mentioned this pull request Oct 3, 2023
Closed
NicolasHug
NicolasHug reviewed Oct 3, 2023
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @joshlk , I made a suggestion below, LMK what you think

CONTRIBUTING.md Outdated Show resolved Hide resolved
@joshlk @NicolasHug
Update CONTRIBUTING.md
6545d3b 
Co-authored-by: Nicolas Hug <[email protected]>
@joshlk
Copy link
Contributor Author

joshlk commented Oct 4, 2023

Sounds good. Ive made the change

NicolasHug
NicolasHug approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @joshlk

@NicolasHug NicolasHug merged commit af3077e into pytorch:main Oct 4, 2023
42 of 62 checks passed
facebook-github-bot pushed a commit that referenced this pull request Oct 31, 2023
@NicolasHug @facebook-github-bot
[fbsync] Add CLA note to CONTRIBUTING.md (#8014)
b98ff1d 
Summary: Co-authored-by: Nicolas Hug <[email protected]>

Reviewed By: vmoens

Differential Revision: D50789076

fbshipit-source-id: 21bc013ee5fdc61e3274f636bd933005baff29d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees
No one assigned
Labels
cla signed enhancement module: documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Contributor License Agreement is Facebook CLA and not PyTorch Foundation CLA. No mention of CLA in repo README
3 participants
@joshlk @NicolasHug @facebook-github-bot