Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RoIPool: SymInt support + meta-implem #8061

Merged
merged 12 commits into from
Oct 30, 2023
Merged

RoIPool: SymInt support + meta-implem #8061

merged 12 commits into from
Oct 30, 2023

Conversation

NicolasHug
Copy link
Member

Towards #8055

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 23, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8061

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (17 Unrelated Failures)

As of commit d5ff205 with merge base 209b2b3 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@NicolasHug NicolasHug mentioned this pull request Oct 23, 2023
Closed
6 tasks
@NicolasHug NicolasHug changed the title RoIPool: SymInt support + meta-implem + opchecks RoIPool: SymInt support + meta-implem Oct 27, 2023
vfdev-5
vfdev-5 approved these changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamp

@NicolasHug NicolasHug merged commit 85c586c into pytorch:main Oct 30, 2023
45 of 62 checks passed
@NicolasHug NicolasHug deleted the opcheck_roipool branch October 30, 2023 07:58
@github-actions
Copy link

Hey @NicolasHug!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@NicolasHug NicolasHug added the pt2 label Nov 13, 2023
facebook-github-bot pushed a commit that referenced this pull request Nov 14, 2023
@NicolasHug @facebook-github-bot
[fbsync] RoIPool: SymInt support + meta-implem (#8061)
69607ce 
Reviewed By: vmoens

Differential Revision: D50789078

fbshipit-source-id: 08ecd4c5244d906977548f698d09fa8039b10558
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
cla signed enhancement module: ops pt2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NicolasHug @vfdev-5 @facebook-github-bot