Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expected shapes in tvtensors docs #8262

Merged
merged 11 commits into from
Apr 19, 2024
Merged

Add expected shapes in tvtensors docs #8262

merged 11 commits into from
Apr 19, 2024

Conversation

mantasu
Copy link
Contributor

@mantasu mantasu commented Feb 7, 2024

Closes #8261, closes #8260

These are just some minor suggestions, please feel free to close if the current behavior is desired as mentioned here.

cc @NicolasHug

Copy link

pytorch-bot bot commented Feb 7, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8262

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 2d3c99b with merge base 2ae6a6d (image):

NEW FAILURE - The following job has failed:

  • Lint / python-types / linux-job (gh)
    RuntimeError: Command docker exec -t d6ce13663bcf70cb1b7cd660ab7e7cde005913decc9b2282a810db9f6c6b24c3 /exec failed with exit code 1

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR and sorry for the late review @mantasu !

@NicolasHug NicolasHug changed the title Tv tensor enhance Add expected shapes in tvtensors docs Apr 19, 2024
@NicolasHug NicolasHug merged commit ba94133 into pytorch:main Apr 19, 2024
78 of 81 checks passed
@mantasu mantasu deleted the tv-tensor-enhance branch April 19, 2024 17:02
facebook-github-bot pushed a commit that referenced this pull request May 8, 2024
Summary: Co-authored-by: Nicolas Hug <[email protected]>

Reviewed By: vmoens

Differential Revision: D57099471

fbshipit-source-id: fba5af694f9f2e800c7a0829327d67f2a67661bb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow ToImage to handle image paths Clarify TVTensor shapes
3 participants