Add GaussianNoise

[Richienb]

Fixes #6192
Fixes #6233

cc @vfdev-5

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8381

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

• Upgrade MacOS runner to 14

❌ 13 New Failures, 4 Unrelated Failures

As of commit d926a83 with merge base b0f9f7b ():

NEW FAILURES - The following jobs have failed:

• Build M1 Conda / pytorch/vision / upload / conda-py3_8-cpu (gh)
  Unable to find any artifacts for the associated workflow
• CMake / macos (macos-m1-stable) / macos-job (gh)
  RuntimeError: operator torchvision::nms does not exist
• CMake / windows (windows.4xlarge, cpu) / windows-job (gh)
  The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
• CMake / windows (windows.g5.4xlarge.nvidia.gpu, cuda, 11.8) / windows-job (gh)
  Process completed with exit code 1.
• Tests / unittests-linux (3.8, linux.12xlarge, cpu) / linux-job (gh)
  test/test_ops.py::TestRoIAlign::test_autocast_cpu[rois_dtype1-x_dtype1-False-True]
• Tests / unittests-macos (3.10, macos-m1-stable) / macos-job (gh)
  RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1
• Tests / unittests-macos (3.11, macos-m1-stable) / macos-job (gh)
  RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1
• Tests / unittests-windows (3.10, windows.4xlarge, cpu) / windows-job (gh)
  The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
• Tests / unittests-windows (3.11, windows.4xlarge, cpu) / windows-job (gh)
  The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
• Tests / unittests-windows (3.12, windows.4xlarge, cpu) / windows-job (gh)
  The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
• Tests / unittests-windows (3.8, windows.4xlarge, cpu) / windows-job (gh)
  The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
• Tests / unittests-windows (3.8, windows.g5.4xlarge.nvidia.gpu, cuda, 11.8) / windows-job (gh)
  Process completed with exit code 1.
• Tests / unittests-windows (3.9, windows.4xlarge, cpu) / windows-job (gh)
  The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

• Build M1 Wheels / pytorch/vision / upload / wheel-py3_8-cpu (gh) (trunk failure)
• Tests / unittests-macos (3.12, macos-m1-stable) / macos-job (gh) (trunk failure)
  RuntimeError: operator torchvision::nms does not exist
• Tests / unittests-macos (3.8, macos-m1-stable) / macos-job (gh) (trunk failure)
  RuntimeError: operator torchvision::nms does not exist
• Tests / unittests-macos (3.9, macos-m1-stable) / macos-job (gh) (trunk failure)
  RuntimeError: operator torchvision::nms does not exist

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[facebook-github-bot]

Hi @Richienb!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[Richienb]

I think sigma (σ) should instead be called var for "variance". For example, mean is not called mu (μ).

[NicolasHug]

That's fair @Richienb , I can't claim mean and sigma are the best name combination, but unfortunately for consistency this is probably what we'll need to use, as these are the names that are already used by GaussianBlur.

[Richienb]

Ok, let's save this for a future breaking change.

[NicolasHug]

Thanks for the PR @Richienb , as you've seen I've made a few changes to the original implementation, but this LGTM now. In particular the transform enforces tensors with float dtype (PIL isn't supported). We might add support for that later but that would require a dtype conversion to avoid over/underflows, so it's best to treat it separately. Thank you again for the PR!