-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return labels for FER2013 if possible #8452
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8452
Note: Links to docs will display an error until the docs builds have been completed. ❌ 12 New Failures, 4 Unrelated FailuresAs of commit 6802e1c with merge base ab0b9a4 (): NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Since the files cannot be downloaded by us, maybe add a sentence to the docstring on how to get test labels?
torchvision/datasets/fer2013.py
Outdated
@@ -47,14 +52,25 @@ def __init__( | |||
f"https://www.kaggle.com/c/challenges-in-representation-learning-facial-expression-recognition-challenge" | |||
) | |||
|
|||
pixels_key = " pixels" if use_icml else "pixels" # yes, for real |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh FFS. Took me two minutes to notice the extra space. I share your feelings here, but maybe point out the space in the comment?
Hey @NicolasHug! You merged this PR, but no labels were added. |
Reviewed By: vmoens Differential Revision: D58283847 fbshipit-source-id: 2d07b422bd8f0f308274ff81595f317a292fdc9d
Closes #8118
Closes #8368
Closes #8415
If either the
fer2013.csv
file oricml_face_data.csv
file is present, we use one of them instead oftrain.csv
andtest.csv
, and return the labels for the test data instead of None.fer2013
has precedence over the rest, thenicml_face_data.csv
is used, and thentrain/test.csv
are used.