Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow io.write_video to work with video_arrays on different devices #8537

Merged
merged 3 commits into from
Jul 25, 2024

Conversation

bmmtstb
Copy link
Contributor

@bmmtstb bmmtstb commented Jul 18, 2024

torchvision.io.write_video() fails if the video_array is on other devices, due to .numpy() not being able to convert properly.

Used .numpy(force=True) to make sure tensors on other devices get converted properly.

  • Added tests (which I can't test locally due to PyAV)

Copy link

pytorch-bot bot commented Jul 18, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8537

Note: Links to docs will display an error until the docs builds have been completed.

❌ 15 New Failures, 6 Unrelated Failures

As of commit bd6f0a4 with merge base 4a1cb63 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@bmmtstb bmmtstb changed the title Allow io.write_video to work with video_arrays on cuda devices Allow io.write_video to work with video_arrays on different devices Jul 18, 2024
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bmmtstb

@NicolasHug NicolasHug merged commit 3e60dbd into pytorch:main Jul 25, 2024
38 of 59 checks passed
facebook-github-bot pushed a commit that referenced this pull request Aug 2, 2024
Summary: Co-authored-by: Nicolas Hug <[email protected]>

Reviewed By: vmoens

Differential Revision: D60596226

fbshipit-source-id: b9ea4916a82a9e7c0e768ce329c3b9d88503f5ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants