Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a heartbeat() method to NoisyPublisher #63

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

pnuu
Copy link
Member

@pnuu pnuu commented Feb 23, 2024

The tests in pytroll/trollmoves#185 often fail with "NoisyPublisher has no attribute heartbeat". This PR fixes that.

@pnuu pnuu added the bug label Feb 23, 2024
@pnuu pnuu self-assigned this Feb 23, 2024
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.87%. Comparing base (07795c4) to head (a28fb72).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
+ Coverage   79.28%   79.87%   +0.58%     
==========================================
  Files          17       17              
  Lines        2192     2211      +19     
==========================================
+ Hits         1738     1766      +28     
+ Misses        454      445       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mraspaud mraspaud merged commit 0eb692e into pytroll:main Feb 26, 2024
7 checks passed
@pnuu pnuu deleted the bugfix-noisypublisher-heartbeat branch February 26, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants