Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding start to the Publisher #172

Merged
merged 1 commit into from
May 24, 2023
Merged

Adding start to the Publisher #172

merged 1 commit into from
May 24, 2023

Conversation

TAlonglong
Copy link
Collaborator

Add start to the Publisher due to updates in posttroll version 1.10.0

@TAlonglong TAlonglong requested review from pnuu and mraspaud as code owners May 24, 2023 09:17
@TAlonglong TAlonglong self-assigned this May 24, 2023
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #172 (a72712c) into main (47dd25f) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #172   +/-   ##
=======================================
  Coverage   90.00%   90.00%           
=======================================
  Files          24       24           
  Lines        5100     5100           
=======================================
  Hits         4590     4590           
  Misses        510      510           
Flag Coverage Δ
unittests 90.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
trollmoves/move_it_base.py 79.80% <100.00%> (ø)

Copy link
Member

@pnuu pnuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (well, I came up with the fix 😅)

@pnuu pnuu merged commit 8cdb573 into pytroll:main May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Publisher need to call start method as of version 1.10.0 of posttroll
2 participants