Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code style #30

Closed
GuillaumeFavelier opened this issue Jul 3, 2020 · 5 comments
Closed

Code style #30

GuillaumeFavelier opened this issue Jul 3, 2020 · 5 comments
Labels
question Further information is requested

Comments

@GuillaumeFavelier
Copy link
Contributor

I think the same question can be asked in this repo. And eventually the same solution could be applied.
@GuillaumeFavelier GuillaumeFavelier added the question Further information is requested label Jul 3, 2020
@banesullivan
Copy link
Member

It'd be easy to do it on this repo. I've used Black on other projects and have been enjoying it

@tkoyama010
Copy link
Member

+1 for using Black.

@GuillaumeFavelier
Copy link
Contributor Author

I notice some real motivation behind black 😅

To be honest, my nvim flake8 plugin is crying when I develop for pyvista and pyvistaqt so at this point, I am in favour of anything that can solve this 🙏

So, how does it work in terms of integration? What would be the plan?

@tkoyama010 tkoyama010 mentioned this issue Jul 17, 2020
Merged
@tkoyama010
Copy link
Member

I made a PR which add CI of checking by black. Could you give opinion?

banesullivan pushed a commit that referenced this issue Jul 22, 2020
@tkoyama010
🆕 black CI by GitHub Actions #30 (#38)
49ac22b 
* 🆕 black CI by GitHub Actions

* 📛 black

* 🔧 .github/workflows/pythonpackage.yml

* 👕 reformat by black

* ⬆️ .github/workflows/pythonpackage.yml

* ⬆️ .github/workflows/pythonpackage.yml

* ⬆️ .github/workflows/pythonpackage.yml

* ⬆️ .github/workflows/pythonpackage.yml

* 🆕 black in Makefile

* 🗑️ remove from doctest

* ♻️ commit for retry CI
@GuillaumeFavelier
Copy link
Contributor Author

Closing by #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tkoyama010 @GuillaumeFavelier @banesullivan