Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💚 Add flake8 in CI #46

Merged
merged 44 commits into from
Aug 16, 2020
Merged

💚 Add flake8 in CI #46

merged 44 commits into from
Aug 16, 2020

Conversation

tkoyama010
Copy link
Member

Let's add flake8 in CI !

@tkoyama010 tkoyama010 changed the title 💚 Add flake8 in CI 🚧 💚 Add flake8 in CI Jul 31, 2020
@codecov
Copy link

codecov bot commented Jul 31, 2020

Codecov Report

Merging #46 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #46   +/-   ##
=======================================
  Coverage   94.90%   94.90%           
=======================================
  Files           5        5           
  Lines         432      432           
=======================================
  Hits          410      410           
  Misses         22       22           

@tkoyama010 tkoyama010 changed the title 🚧 💚 Add flake8 in CI 💚 Add flake8 in CI Jul 31, 2020
@tkoyama010 tkoyama010 marked this pull request as ready for review July 31, 2020 16:28
@tkoyama010 tkoyama010 marked this pull request as draft August 1, 2020 06:12
@tkoyama010
Copy link
Member Author

Let's merge this PR after merging the #45 .

@GuillaumeFavelier
Copy link
Contributor

@tkoyama010, now that #45 has been merged, feel free to update your PR :)

@tkoyama010 tkoyama010 marked this pull request as ready for review August 14, 2020 09:48
@tkoyama010
Copy link
Member Author

Now. It is ready for merge. Thank @GuillaumeFavelier for help. 🚀

Copy link
Contributor

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty straightforward to me

@larsoner larsoner merged commit b4209e1 into pyvista:master Aug 16, 2020
@tkoyama010 tkoyama010 deleted the patch-4 branch August 16, 2020 13:12
@tkoyama010
Copy link
Member Author

Thanks @larsoner 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants