Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

excelize skip pages #1591

Closed
togemura opened this issue Jul 27, 2023 · 2 comments
Closed

excelize skip pages #1591

togemura opened this issue Jul 27, 2023 · 2 comments

Comments

@togemura
Copy link

Please replace in lib.go :
string 56 (

excelize/lib.go

Line 56 in 2e9c290

if strings.HasPrefix(fileName, "xl/worksheets/sheet") {
)

strings.HasPrefix(fileName, "xl/worksheets/sheet")

to

strings.HasPrefix(strings.ToLower(fileName), "xl/worksheets/sheet")

We have excel files with fileName like "xl/worksheets/Sheet" - and sheets just skip because of upper case
@xuri xuri closed this as completed in a07c8cd Jul 27, 2023
@xuri
Copy link
Member

xuri commented Jul 27, 2023

Thanks for your issue. I have made a changes for this, please try to upgrade the master branch code, and this patch will be released in the next version.

@togemura
Copy link
Author

Thanks a lot!

jenbonzhang pushed a commit to jenbonzhang/excelize that referenced this issue Oct 22, 2023
@xuri
This closes qax-os#1588, closes qax-os#1591, breaking changes for the…
ca5deeb 
… `AddChart` function

- Removed exported `ChartTitle` data type
- The `AddChart` function now supports formatting and setting rich text titles for the chart
- New exported function `GetFormControl` for getting form control
- Made case in-sensitive for internal worksheet XML path to improve compatibility
- Update the unit tests
- Update the documentation and internal comments on the codes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xuri @togemura