Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetComments lost author when comment has multi author #829

Closed
raochq opened this issue Apr 26, 2021 · 1 comment
Closed

GetComments lost author when comment has multi author #829

raochq opened this issue Apr 26, 2021 · 1 comment

Comments

@raochq
Copy link
Contributor

raochq commented Apr 26, 2021

I load a file edited by multiple users. I use function GetComments to get the comments, it renturn me an error author or none author.

i found when xml decode data into xlsxComments, it only remained the last author.

i think the Authors of xlsxComments may define like this

type xlsxComments struct {
	XMLName     xml.Name        `xml:"http://schemas.openxmlformats.org/spreadsheetml/2006/main comments"`
	Authors     xlsxAuthors    `xml:"authors"`
	CommentList xlsxCommentList `xml:"commentList"`
}

type xlsxAuthors struct {
	Author []string `xml:"author"`
}
@xuri xuri added the in progress Working in progress label Apr 27, 2021
@xuri xuri closed this as completed in a13ef55 Apr 27, 2021
@xuri
Copy link
Member

xuri commented Apr 27, 2021

Thanks for your feedback, I have fixed it, please try to use the master branch code, and this patch will be released in the next version.

@xuri xuri removed the in progress Working in progress label Apr 27, 2021
jenbonzhang pushed a commit to jenbonzhang/excelize that referenced this issue Oct 22, 2023
…ue when get and add comments on multi authors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants