add-FilterPrivacy-to-workbookPr #1154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuri
added
the
size/M
xuri
requested changes
Feb 19, 2022
| @@ -25,6 +25,8 @@ type SheetPrOptionPtr interface { | |||
| } | |||
|
|
|||
| type ( | |||
| // FilterPrivacy is an option used for SheetPrOption and WorkbookPrOption | |||
| FilterPrivacy bool | |||
There was a problem hiding this comment.
The filterPrivacy attribute didn't belong to worksheets properties, so I suggest defining it in the workbook.go, and correct doc comment for it.
| @@ -123,6 +123,11 @@ func (o CodeName) setWorkbookPrOption(pr *xlsxWorkbookPr) { | |||
| pr.CodeName = string(o) | |||
| } | |||
|
|
|||
| // setWorkbookPrOption implements the WorkbookPrOption interface. | |||
There was a problem hiding this comment.
I suggest the get and set implement functions following the order in OOXML Spec, move this function before CodeName, and update the available options document of the functions SetWorkbookPrOptions and GetWorkbookPrOptions
| // filter privacy of thw workbook. | ||
| func (o *FilterPrivacy) getWorkbookPrOption(pr *xlsxWorkbookPr) { | ||
| if pr == nil { | ||
| *o = true |
There was a problem hiding this comment.
This case was not been tested, please add a test case for this.
wangxuliBY
added a commit
to wangxuliBY/excelize
that referenced
this pull request
Feb 25, 2022
This fixed code review issue in PR qax-os#1154
10 tasks
wangxuliBY
added a commit
to wangxuliBY/excelize
that referenced
this pull request
Feb 25, 2022
This fixed code review issue in PR qax-os#1154
10 tasks
xuri
pushed a commit
that referenced
this pull request
Feb 25, 2022
xuri
pushed a commit
to carbin-gun/excelize
that referenced
this pull request
Oct 9, 2022
jenbonzhang
pushed a commit
to jenbonzhang/excelize
that referenced
this pull request
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
more information on this ticket: #1152