Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for the new method GetAllLinkedDataValidations to retrieve data validation content from linked sheets. #1834

Merged
merged 3 commits into from
Mar 6, 2024

Conversation

iEvan-lhr
Copy link
Contributor

PR Details

Description
This commit introduces the new GetAllLinkedDataValidations method as a temporary solution to address the issue where the GetDataValidations method fails to completely retrieve all data validations, especially those linked to other sheets. The addition of this method enhances the library's functionality by allowing users to extract associated data validation content from other sheets using the Ext structure. It's important to note that this is an interim fix and the Ext structure may encompass more than just the data validation components.

Related Issue

Motivation and Context
The motivation behind this change is to provide a reliable method for users to retrieve all data validations, including those linked to different sheets within a workbook. This is crucial for applications that rely on complete data validation information for data integrity and user input control.

How Has This Been Tested
The new method has been tested by integrating it within the existing test suite. Additional tests were written to ensure that the data validations are properly retrieved from linked sheets and that the Ext structure is parsed correctly. The tests involved various scenarios with different data validation configurations across multiple sheets.

Types of changes

Docs change / refactoring / dependency upgrade
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Checklist

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

@xuri xuri added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 1, 2024
@xuri xuri linked an issue Mar 5, 2024 that may be closed by this pull request
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.21%. Comparing base (9d4c2e6) to head (5af7e2e).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1834   +/-   ##
=======================================
  Coverage   99.21%   99.21%           
=======================================
  Files          32       32           
  Lines       23930    23959   +29     
=======================================
+ Hits        23741    23770   +29     
  Misses        101      101           
  Partials       88       88           
Flag Coverage Δ
unittests 99.21% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. I have made some changes based on this pull request, the GetDataValidations function now supports get data validations which storage in the extension lists. Please upgrade to the master branch code, and this change will be released in the next version.

@xuri xuri merged commit 4ed4938 into qax-os:master Mar 6, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
No open projects
Status: Improve the Compatibility
2 participants