Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the format '?' in number formatting #2080

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kurtinge
Copy link

Handle the format '?' in number formatting

Description

When excelize tries to read a cell where the formatCode in the style is "?" it will return an empty string instead of the number.

Motivation and Context

This handles that the formatCode "?" is valid and returns a the number correctly

How Has This Been Tested

This has been tested in the unit test and with an actual file.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant