Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(format): support text format in console with color #20

Merged
merged 1 commit into from
Jun 16, 2017

Conversation

vincenthou
Copy link
Contributor

This is helpful in CI building

@wgliang
Copy link
Collaborator

wgliang commented Jun 16, 2017

Very Cool !

@wgliang
Copy link
Collaborator

wgliang commented Jun 16, 2017

But why do you remove the template parameters.

@wgliang
Copy link
Collaborator

wgliang commented Jun 16, 2017

I think the user should have the right to customize the template.

@wgliang
Copy link
Collaborator

wgliang commented Jun 16, 2017

@vincenthou

@vincenthou
Copy link
Contributor Author

@wgliang I only remove the parameter in NewReporter funciton, it seems that it is not used in it, it seems that it is only useful for SaveAsHtml method

// Original funciton signature
func NewReporter(templateHtml string) *Reporter {
	return &Reporter{
		Metrics: make(map[string]Metric, 0),
		syncRW:  new(sync.RWMutex),
	}
}

// main.go
tools.SaveAsHtml(htmlData, *project, *report, startTime, templateHtml)

@wgliang
Copy link
Collaborator

wgliang commented Jun 16, 2017

Ok , I get! A good job!

@wgliang wgliang merged commit 15d8f82 into qax-os:master Jun 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants