Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for existing files in cache dir before instantiating a model #128

Merged
merged 3 commits into from
Feb 21, 2024
Merged

Check for existing files in cache dir before instantiating a model #128

merged 3 commits into from
Feb 21, 2024

Conversation

nleroy917
Copy link
Contributor

This is directly related to issue #127

macOS seems to flag temp files as up for deletion after about 3 days. This was causing issues with the model cache dir existing, but the model files themselves not.

Let me know if you guys have a better idea for this, or an entirely different approach!

@NirantK NirantK requested a review from Anush008 February 21, 2024 08:10
@NirantK
Copy link
Contributor

NirantK commented Feb 21, 2024

@Anush008 please merge once you've reviewed

Copy link
Member

@Anush008 Anush008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @nleroy917.

@Anush008 Anush008 merged commit 38c4eb1 into qdrant:main Feb 21, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants