Update chart to Qdrant 1.12.3 #263
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timvisee
commented
Nov 12, 2024
Comment on lines
11
to
20
| @test "no startup warnings in logs" { | ||
| skip "Skip for 1.12.2 which has a known warning" | ||
| run kubectl logs -n qdrant-helm-integration qdrant-0 | ||
| [ $status -eq 0 ] | ||
| [[ "${output}" =~ .*INFO.* ]] | ||
| if [[ ! "${output}" =~ .*WARN.* ]]; then | ||
| echo "Found warning output:" | ||
| echo "${output}" | ||
| return 1 | ||
| fi | ||
| [[ ! "${output}" =~ .*WARN.* ]] | ||
| } |
There was a problem hiding this comment.
Here I reverted the test change made in #262 because it's fixed in Qdrant 1.12.3.
Not entirely sure if reverting this is correct.
There was a problem hiding this comment.
@timvisee I think we can remove the skip as it is fixed now, but we can keep the additional echo's to see directly what is wrong.
There was a problem hiding this comment.
The logic seems wrong here, it is written as if output does not contain WARN, then return 1 and echo output. While it should be if it contains WARN I would say, so:
if [[ "${output}" =~ .*WARN.* ]]; then
This should fix the test as it currently errors without output that does not contain WARN 😛
There was a problem hiding this comment.
Makes sense, I just reverted it. It seems it was wrong before as well.
timvisee
force-pushed
the
feat/timvisee/qdrant-1.12.3
branch
from
f5cb782
to
49c9734
Compare
superseb
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update for Qdrant 1.12.3.
Follows the pattern of #262.