Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove plugin tags to reduce distraction #255

Merged
merged 1 commit into from
Aug 21, 2022

Conversation

faebebin
Copy link
Contributor

@faebebin faebebin commented Aug 20, 2022

The Plugin tags section is very long and puts the Sponsors footer very far down so that maybe rarely anone ever sees it. This PR suggests removing it from the main pages.

image

Above: with Plugin tags ; Below: without Plugin tags

image

@faebebin faebebin force-pushed the remove-plugin-tags branch from ea8ab38 to ebeb6ac Compare August 21, 2022 13:09
@codecov-commenter
Copy link

Codecov Report

Merging #255 (ebeb6ac) into master (9fbc616) will decrease coverage by 36.83%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #255       +/-   ##
===========================================
- Coverage   74.55%   37.72%   -36.84%     
===========================================
  Files         124       88       -36     
  Lines        4705     3714      -991     
===========================================
- Hits         3508     1401     -2107     
- Misses       1197     2313     +1116     
Impacted Files Coverage Δ
qgis-app/styles/tests/test_views.py 19.17% <0.00%> (-80.83%) ⬇️
qgis-app/api/tests/test_views.py 13.09% <0.00%> (-79.17%) ⬇️
qgis-app/styles/tests/test_filehandler.py 21.78% <0.00%> (-78.22%) ⬇️
qgis-app/styles/file_handler.py 9.09% <0.00%> (-77.28%) ⬇️
qgis-app/models/tests/test_views.py 23.41% <0.00%> (-76.59%) ⬇️
qgis-app/geopackages/tests/test_views.py 25.35% <0.00%> (-74.65%) ⬇️
qgis-app/wavefronts/tests/test_view.py 25.64% <0.00%> (-74.36%) ⬇️
qgis-app/layerdefinitions/tests/test_views.py 27.90% <0.00%> (-72.10%) ⬇️
qgis-app/wavefronts/tests/test_validator.py 28.26% <0.00%> (-71.74%) ⬇️
qgis-app/wavefronts/validator.py 24.28% <0.00%> (-70.00%) ⬇️
... and 59 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dimasciput
Copy link
Collaborator

@faebebin I think it's better to remove these for now. I'm going to merge this.

@dimasciput dimasciput merged commit ac26d15 into qgis:master Aug 21, 2022
@kannes
Copy link
Contributor

kannes commented Dec 2, 2022

I am super sad about this change. The tag cloud was a useful way to find plugins and not just meaningless "distraction" without any purpose. Was there any bigger discussion about this removal?

Is the tag cloud available elsewhere on the plugins website? Otherwise it feels almost useless to have tags anymore.

@elpaso
Copy link
Contributor

elpaso commented Dec 2, 2022

Why don't reduce the number of tags instead of removing them all?

@faebebin
Copy link
Contributor Author

faebebin commented Dec 3, 2022

Could reduce and/or display them less space consuming with a collapse / hover / ellipsis ... ? @dimasciput , @m-kuhn what you think? I could workout a suggestion if interested.

@m-kuhn
Copy link
Member

m-kuhn commented Dec 4, 2022

I think a dedicated page that lists all tags in a section "explore" would be nice.
How does that sound?

@faebebin
Copy link
Contributor Author

faebebin commented Dec 4, 2022

OK, that sounds good. I will be back with a PR.

@faebebin
Copy link
Contributor Author

faebebin commented Dec 12, 2022

To work with more realistic database (ie. a huge list of plugin tags) I wanted to make use of the backups.sh script. For me it is not working and I cannot get useful information from server. It basically hangs at [connecting ...] forever .

> ./backup.sh 
Source : /mnt/HC_Volume_4113275
Destination : backups
Objective : DOWNLOAD
cd `/mnt/HC_Volume_4113275' [Connecting...]

Trying to get more informtion:

> lftp -d -u kartoza, sftp://plugins.qgis.org -e "ls"
---- Running connect program (ssh -a -x -s -l kartoza plugins.qgis.org sft
p)
---> sending a packet, length=5, type=1(INIT), id=0
`ls' at 0 [Connecting...]

Trying to get more information via ssh:

> ssh -vvv -a -x -s -l kartoza plugins.qgis.org sftp
OpenSSH_8.9p1 Ubuntu-3, OpenSSL 3.0.2 15 Mar 2022
debug1: Reading configuration data /etc/ssh/ssh_config
debug1: /etc/ssh/ssh_config line 19: include /etc/ssh/ssh_config.d/*.conf 
matched no files
debug1: /etc/ssh/ssh_config line 21: Applying options for *
debug3: expanded UserKnownHostsFile '~/.ssh/known_hosts' -> '/home/faebe/.
ssh/known_hosts'
debug3: expanded UserKnownHostsFile '~/.ssh/known_hosts2' -> '/home/faebe/
.ssh/known_hosts2'
debug2: resolving "plugins.qgis.org" port 22
debug3: resolve_host: lookup plugins.qgis.org:22
debug3: ssh_connect_direct: entering
debug1: Connecting to plugins.qgis.org [2606:4700:3035::ac43:8f17] port 22
.
debug3: set_sock_tos: set socket 3 IPV6_TCLASS 0x10

Ignoring known hosts StrictHostKeyChecki ng=no -o UserKnownHostsFile=/dev/null -o GlobalKnownHostsFile=/dev/null leads to same connecting issue.

@timlinux , @dimasciput , @kannes or @elpaso could you help me based on the logs above? Else very happy to send more information from my system.

@faebebin faebebin deleted the remove-plugin-tags branch December 17, 2022 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants