Http3 #475
Merged
Http3 #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
November 4, 2021 16:17
# Conflicts: # library/src/main/java/com/qiniu/android/http/ResponseInfo.java # library/src/main/java/com/qiniu/android/http/request/IRequestClient.java
# Conflicts: # library/src/androidTest/java/com/qiniu/android/transaction/TransactionManagerTest.java
Codecov Report
@@ Coverage Diff @@
## develop #475 +/- ##
=============================================
- Coverage 70.01% 69.46% -0.55%
- Complexity 1328 1366 +38
=============================================
Files 103 105 +2
Lines 6877 7035 +158
Branches 1045 1057 +12
=============================================
+ Hits 4815 4887 +72
- Misses 1301 1382 +81
- Partials 761 766 +5
|
bachue
reviewed
Nov 17, 2021
| } | ||
| } | ||
|
|
||
| if (host != null && ip != null && live > 0) { |
There was a problem hiding this comment.
@YangSen-qn 这里应该是要对 port 进行解析的，否则 x-alt-src 返回的这个元素就失去意义了
library/build.gradle
Outdated
| } | ||
| } | ||
| //本地地址 | ||
| repositories { maven { url = "file:/Users/senyang/.m2/repository/" } } |
bachue
reviewed
Nov 22, 2021
| RequestClientProgress progress, | ||
| RequestClientCompleteHandler complete); | ||
| public abstract void request(Request request, | ||
| IUploadServer server, |
There was a problem hiding this comment.
@YangSen-qn 建议设计成即使接口增加新的参数，也不至于会做成不兼容变更的形态
bachue
approved these changes
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.