-
-
Notifications
You must be signed in to change notification settings - Fork 39.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ferris 0.2 #12133
Add ferris 0.2 #12133
Conversation
Use higher level functions of the i2c API to simplify my matrix.c implementation.
The Ferris 0.2 switches from an atmega32u4 chip to an stm32f072 chip. Write firmware for this. The most challenging bit was to configure i2c as the hardware uses the i2c2 pins: PB10 and PB11 which is uncommon. The ferris bling has backlighting leds which are not supported yet. Support will come in a later PR.
Is there anything holding this PR from getting merged? It looks like it was approved 13 days ago. When it's in, I'll want to raise a follow-up PR for the underglow :) |
Just time. We review PRs in our spare time, so it can take some time. |
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Ryan <[email protected]>
Hi @drashna , thanks for the reply. I'm sorry if I sounded impatient. I totally appreciate the time you all are spending on maintaining this huge project for the benefit of the hobbyist keyboard community. I also appreciate that so far I've been getting great quality code reviews in all of my PRs and people have been really helpful on discord when I had questions ❤️ I guess my question was more about the process than just the timeline: do PRs need two approving reviews before landing? I haven't found a clear indication here: https://docs.qmk.fm/#/contributing, so it's a bit hard to know what to expect. Maybe I haven't been looking at the right place in the documentation to find this kind of information? |
Thanks for the review, @fauxpark. I've committed all of your suggestions 👍 I learnt something about controlling the size of an imgur image preview today 😄 |
No worries. And yeah, we generally want 2 approvals before a PR is merged in. And I've been meaning to add that info to the docs. |
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Ryan <[email protected]>
Description
The Ferris 0.2 switches from an atmega32u4 chip to an stm32f072 chip.
Write firmware for this. The most challenging bit was to configure i2c
as the hardware uses the i2c2 pins: PB10 and PB11 which is uncommon.
The ferris bling has backlighting leds which are not supported yet.
Support will come in a later PR.
Note that part of this change refactors the 0.1's matrix.c implementation for
consistency as only higher level functions are available to call with chibios
and I prefer to have code that is closer to each other between revisions.
Types of Changes
Issues Fixed or Closed by This PR
Checklist