Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Vida to QMK #24225

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Add Vida to QMK #24225

wants to merge 10 commits into from
+1,122 −0

Conversation

awkannan
Copy link
Contributor

@awkannan awkannan commented Aug 1, 2024 •
edited
Loading

Description

Adding the Vida keyboard PCBs to QMK

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keymap via Adds via keymap and/or updates keyboard for via support labels Aug 1, 2024
dunk2k
dunk2k suggested changes Aug 1, 2024
View reviewed changes
keyboards/cannonkeys/vida/keyboard.json Outdated Show resolved Hide resolved
@awkannan
Copy link
Contributor Author

@zvecr this one has also been split into the two variants

waffle87
waffle87 reviewed Aug 16, 2024
View reviewed changes
Copy link
Member

@waffle87 waffle87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

keyboards/cannonkeys/vida/hotswap/keyboard.json Outdated Show resolved Hide resolved
@drashna
Copy link
Member

drashna commented Aug 30, 2024

As of August 26, 2024, qmk/qmk_firmware is no longer accepting VIA-enabled keymaps as these have now transitioned to a repository under the VIA team's control.

As you've submitted a PR consisting entirely of via or VIA-enabled keymap(s), this PR has been closed. You should submit an equivalent PR to the VIA QMK Userspace repository with your associated via or VIA-enabled keymaps instead.

Otherwise, LGTM

@awkannan
Copy link
Contributor Author

I’ll remove the VIA related stuff tomorrow!

@awkannan
Copy link
Contributor Author

awkannan commented Oct 2, 2024

@drashna should be good to go here too

dunk2k
dunk2k suggested changes Oct 3, 2024
View reviewed changes
keyboards/cannonkeys/vida/solderable/keymaps/default/keymap.c
QK_GESC, KC_1, KC_2, KC_3, KC_4, KC_5, KC_6, KC_7, KC_8, KC_9, KC_0, KC_MINS, KC_EQL, KC_BSPC, KC_DEL,
KC_TAB, KC_Q, KC_W, KC_E, KC_R, KC_T, KC_Y, KC_U, KC_I, KC_O, KC_P, KC_LBRC, KC_RBRC, KC_BSLS,
KC_CAPS, KC_A, KC_S, KC_D, KC_F, KC_G, KC_H, KC_J, KC_K, KC_L, KC_SCLN, KC_QUOT, KC_ENT,
KC_LSFT, KC_BSLS, KC_Z, KC_X, KC_C, KC_V, KC_B, KC_N, KC_M, KC_COMM, KC_DOT, KC_SLSH, KC_RSFT, MO(_FN1),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
KC_LSFT, KC_BSLS, KC_Z, KC_X, KC_C, KC_V, KC_B, KC_N, KC_M, KC_COMM, KC_DOT, KC_SLSH, KC_RSFT, MO(_FN1),
KC_LSFT, KC_NUBS, KC_Z, KC_X, KC_C, KC_V, KC_B, KC_N, KC_M, KC_COMM, KC_DOT, KC_SLSH, KC_RSFT, MO(_FN1),

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still outstanding - this is the correct keycode.

@dunk2k
Copy link
Contributor

dunk2k commented Oct 3, 2024 •
edited
Loading

@awkannan
Does either variant support 60_*_wkl* Community Layouts?

@drashna drashna requested a review from a team October 11, 2024 03:29
@awkannan
Copy link
Contributor Author

awkannan commented Nov 1, 2024

@fauxpark thanks for the catch - this is ready for another review

fauxpark
fauxpark requested changes Nov 2, 2024
View reviewed changes
keyboards/cannonkeys/vida/hotswap/keymaps/default/keymap.c Outdated
Comment on lines 23 to 24
BL_BRTG, KC_LEFT, KC_DOWN, KC_RGHT, _______, _______, _______, _______, _______, _______, _______, _______, _______,
BL_UP, BL_DOWN, BL_TOGG, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No backlight config for hotswap

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this - removed these keys because they don't apply to hotswap.

Ready for another review again.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waffle87 waffle87 waffle87 left review comments

@zvecr zvecr zvecr left review comments

@fauxpark fauxpark fauxpark requested changes

@dunk2k dunk2k dunk2k requested changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap stale Issues or pull requests that have become inactive without resolution. via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@awkannan @drashna @dunk2k @fauxpark @zvecr @waffle87