Serial port detection loop #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nooges
approved these changes
Apr 28, 2021
|
Reverted the Windows changes. I've seen a few instances of Caterina devices with the correct Additionally, although the detection logic appears to be run in a separate thread from the UI, the while loop would run forever in this situation, or if the driver is not usbser (tested this with WinUSB). Which may potentially cause issues. I think I will probably refactor the macOS serial detection code to match against the serial device itself, so that there's no need for this loop or a UI-freezing sleep. |
nooges
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an attempt to fix a crash that occurs on macOS when the callout device does not appear within 0.5 seconds of the USB device. Instead of sleeping for that time, we just continually loop, under the assumption that a callout device will appear. I think this would be perfectly fine except that as far as I know this is running in the same thread as the UI - but that may be something for another day. It should not block for too long.
The logic is copied on the Windows side, although I think the COM port appears at the same time as the USB device anyway.
Types of Changes
Issues Fixed or Closed by This PR