Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reset repository to QuantumCore.jl #2

Merged
merged 1 commit into from
Nov 26, 2022
Merged

reset repository to QuantumCore.jl #2

merged 1 commit into from
Nov 26, 2022

Conversation

Krastanov
Copy link
Collaborator

This follows up on #1 (comment)

It basically copies over https://github.com/Krastanov/QuantumCore.jl

@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@ad31d68). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             main      #2   +/-   ##
======================================
  Coverage        ?   0.00%           
======================================
  Files           ?       2           
  Lines           ?      99           
  Branches        ?       0           
======================================
  Hits            ?       0           
  Misses          ?      99           
  Partials        ?       0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Krastanov
Copy link
Collaborator Author

@david-pl , if this looks good:

  • I can go ahead an merge it
  • Could you rename the repository to QuantumCore.jl
  • I will finish some minor polish and hopefully make the CI tasks work better -- I would not wait for review on these initial polishing tasks
  • Submit a pull request to QuantumOpticsBase.jl - that would probably be a good place to do the actual review
  • Register this package
  • Merge the pull request to QuantumOpticsBase
  • Protect the main branch here, and continue iterating on this package through pull requests (we will figure out some reviewer rules that we are happy with -- I do not know the rules you follow for the rest of qojulia, but probably we can just follow them)
  • Register QSymbolics (and decide on a home organization for it)

@david-pl
Copy link
Member

@Krastanov I renamed the repository. The definitions included so far make sense and look good to me, so go ahead and merge it.

I also agree with the overall plan you detailed. Thanks for all your input!

@Krastanov Krastanov merged commit 917558a into main Nov 26, 2022
@Krastanov Krastanov deleted the quantumcore branch November 26, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants