Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAL-33: Use maven-bnd-plugin to automate OSGi manifest generation #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

loicalbertin
Copy link

Hi,

kindly find a commit integrating maven-bnd-plugin in your build to allow automatic generation of the bundle manifest for the cal10n-api module.

Thanks & regards,
Loïc

@kcris
Copy link

kcris commented Mar 2, 2018

can someone merge this, please?

just got 0.8.1 jar from maven central, with an empty Export-Package manifest entry, which makes it unusable with OSGi.

however, your manifest.mf does include the export, so I don't know how that jar in maven central was built

@fskexp
Copy link

fskexp commented Jul 8, 2019

can someone merge this, please?

just got 0.8.1 jar from maven central, with an empty Export-Package manifest entry, which makes it unusable with OSGi.

however, your manifest.mf does include the export, so I don't know how that jar in maven central was built

I realized that version 0.7.4 had the Export-Package entry but not the version 0.8.1. Maybe it is related to the version of maven-jar-plugin: in version 0.8.1 its version became explicit in the parent pom. Before that maybe it was the one given by the local Maven installation. If I add a new line at the end of "cal10n-api\src\main\resources\META-INF\MANIFEST.MF" (currently the last line does not end with a new line), then when I build the Export-Package directive appears in the built jar file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants