Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MPS import in TFQ #394

Merged
merged 3 commits into from
Aug 4, 2021
Merged

Fix MPS import in TFQ #394

merged 3 commits into from
Aug 4, 2021

Conversation

jaeyoo
Copy link
Contributor

@jaeyoo jaeyoo commented Aug 3, 2021

Resolves #393

@google-cla google-cla bot added the cla: yes Override CLA status to unblock PR. label Aug 3, 2021
@jaeyoo jaeyoo changed the title Update BUILD Fix MPS import in TFQ Aug 3, 2021
@95-martin-orion 95-martin-orion self-requested a review August 3, 2021 15:09
95-martin-orion
95-martin-orion requested changes Aug 3, 2021
View reviewed changes
Copy link
Collaborator

@95-martin-orion 95-martin-orion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly seems fine, one comment on qsimh.

lib/BUILD Outdated Show resolved Hide resolved
95-martin-orion
95-martin-orion approved these changes Aug 4, 2021
View reviewed changes
Copy link
Collaborator

@95-martin-orion 95-martin-orion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. To confirm, #393 is resolved by this, but not #395 - is that correct?

@95-martin-orion 95-martin-orion added the kokoro:run Trigger Kokoro builds for this PR. label Aug 4, 2021
@qsim-qsimh-bot qsim-qsimh-bot removed the kokoro:run Trigger Kokoro builds for this PR. label Aug 4, 2021
@jaeyoo
Copy link
Contributor Author

jaeyoo commented Aug 4, 2021

Looks good to me. To confirm, #393 is resolved by this, but not #395 - is that correct?

Yes, right. #394 resolves #393 . #396 resolves #395 . Thanks!

@95-martin-orion 95-martin-orion merged commit d0260ab into quantumlib:master Aug 4, 2021
@sergeisakov
Copy link
Collaborator

Mostly seems fine, one comment on qsimh.

I think the same comment is valid for "run_qsim_lib". This should have been added only to "qsim_lib".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@95-martin-orion 95-martin-orion 95-martin-orion approved these changes

Assignees
No one assigned
Labels
cla: yes Override CLA status to unblock PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mps is not included in BUILD.
4 participants
@jaeyoo @sergeisakov @95-martin-orion @qsim-qsimh-bot