Review #2

RobinDavid · 2023-06-15T07:51:06Z

Many changes.

@rc-94

Merge @rc-94 branch in review

Data and string references are using the value itself, not the address. The only excpetion is for structure references where it's using the structure (and field) name instead of the value

patacca

@RobinDavid

src/qbindiff/features/extractor.py

src/qbindiff/features/wlgk.py

Weight doesn't need to be between 0 and 1. Even though it can theoretically always be normalized to [0, 1] sometimes it's better to use a wider range to avoid float rounding errors.

src/qbindiff/features/graph.py

src/qbindiff/loader/backend/abstract.py

Since we were not able to reconstruct the correct context we cannot disassemble the basic block

src/qbindiff/loader/backend/binexport.py

src/qbindiff/loader/backend/quokka.py

src/qbindiff/loader/basic_block.py

…iate level

src/qbindiff/features/graph.py

BinExport doesn't export the raw binary path in the protobuf message so we have to guess the correct path by removing the .BinExport extension

Since we are still relying on capstone instruction ID the MAX_ID has been created to hold all the possible capstone IDs.

rc-94 and others added 27 commits May 4, 2023 17:39

fix N to n

2b68b10

Add try except for case with empty func

d5261e7

Add sparsity doc

863306e

Add warning about archi

3233c30

Add typing and fix an undefined var for cortexm

e6a2fa4

whole review

ec3df2a

Fix quokka bug with ref

037bb4a

rework loader interface

6b249bc

add comments

86758bd

change immutable to immediate

decfbab

rework bindiff database file creation

ade1466

docstring & co

705a24e

update README

0dd127b

add CI for releases

7e5eae8

add some doc files

5b026f9

fixups for opensourcing branch

e84a38c

Merge branch 'review' into opensourcing

eae6ec8

Merge pull request #1 from quarkslab/opensourcing

94f35f4

Merge @rc-94 branch in review

delete version

9711d2e

delete version

ddc8b0c

fix bindifffile

0aceca0

fix :

8b42a7a

del bindiff

cecf497

fix bugs

eaa1ff7

fix bugs

6eda5e8

fix bugs

f25e611

fix fixme

f8b1385

RobinDavid assigned patacca Jun 15, 2023

patacca added 2 commits June 19, 2023 09:37

Fix link and typo

505098d

Fix wrong link

bc36a83

Fix wrong description of StrRef and DatName

500add6

Data and string references are using the value itself, not the address. The only excpetion is for structure references where it's using the structure (and field) name instead of the value

patacca reviewed Jun 19, 2023

View reviewed changes

src/qbindiff/features/extractor.py Show resolved Hide resolved

src/qbindiff/features/extractor.py Show resolved Hide resolved

src/qbindiff/features/wlgk.py Show resolved Hide resolved

patacca added 4 commits June 19, 2023 10:47

Add python-bindiff as a dependency

8a60a15

Fix doc string. NFC.

4422637

Weight doesn't need to be between 0 and 1. Even though it can theoretically always be normalized to [0, 1] sometimes it's better to use a wider range to avoid float rounding errors.

Fix wrong indentation

4a77c30

Removed unused variable. NFC.

864ecab

patacca reviewed Jun 19, 2023

View reviewed changes

src/qbindiff/features/graph.py Outdated Show resolved Hide resolved

patacca reviewed Jun 19, 2023

View reviewed changes

src/qbindiff/features/graph.py Outdated Show resolved Hide resolved

patacca added 4 commits June 19, 2023 11:18

Update docstring. NFC.

42e4433

Update docstring. NFC.

85b4a51

Update docstring to be more general. NFC.

33ffe93

Fix typo in docstring. NFC.

60c82d0

patacca reviewed Jun 19, 2023

View reviewed changes

src/qbindiff/loader/backend/abstract.py Outdated Show resolved Hide resolved

Raise an exception when we cannot guess the capstone context

1792a49

Since we were not able to reconstruct the correct context we cannot disassemble the basic block

patacca reviewed Jun 19, 2023

View reviewed changes

src/qbindiff/loader/backend/binexport.py Show resolved Hide resolved

patacca reviewed Jun 19, 2023

View reviewed changes

src/qbindiff/loader/backend/quokka.py Outdated Show resolved Hide resolved

Fix typo

f9407a0

patacca reviewed Jun 19, 2023

View reviewed changes

src/qbindiff/loader/basic_block.py Show resolved Hide resolved

patacca added 4 commits June 19, 2023 14:00

Change features JumpNb and ReadWriteAccess to operates at the appropr…

cc273a1

…iate level

Fix missing imports, variables and wrong syntax

0b4855a

Add tabulation to avoid click complains

856f9ab

Reintroduce program exec_path property

371cf99

patacca reviewed Jun 19, 2023

View reviewed changes

src/qbindiff/features/graph.py Outdated Show resolved Hide resolved

patacca added 5 commits June 19, 2023 18:22

Make exec_path mandatory

4b297a9

BinExport doesn't export the raw binary path in the protobuf message so we have to guess the correct path by removing the .BinExport extension

Better handling of instruction ID

9d6d6a0

Since we are still relying on capstone instruction ID the MAX_ID has been created to hold all the possible capstone IDs.

Use the backend __len__ method in basic blocks

7588689

Check properly enums

9abae10

Fix imported module

fc5f2e0

RobinDavid merged commit be5aa96 into main Jun 21, 2023

RobinDavid deleted the review branch June 21, 2023 08:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Review #2

Review #2

RobinDavid commented Jun 15, 2023

patacca left a comment

Review #2

Review #2

Conversation

RobinDavid commented Jun 15, 2023

patacca left a comment

Choose a reason for hiding this comment