-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Create and update S2I procedures for the Deploying on OpenShift guide #45954
base: main
Are you sure you want to change the base?
Conversation
a9bb223
to
590b096
Compare
🎊 PR Preview 7ff0fcf has been successfully built and deployed to https://quarkus-pr-main-45954-preview.surge.sh/version/main/guides/
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work, @sheilamjones. Thanks for bringing this valuable content upstream. I've offered some suggestions for clarity and consistency. Feel free to adapt as you see fit.
Signed-off-by: shjones <shjones@redhat.com>
Signed-off-by: shjones <shjones@redhat.com>
Signed-off-by: shjones <shjones@redhat.com>
Signed-off-by: shjones <shjones@redhat.com>
Signed-off-by: shjones <shjones@redhat.com>
Signed-off-by: shjones <shjones@redhat.com>
Signed-off-by: shjones <shjones@redhat.com>
590b096
to
8a1818d
Compare
Status for workflow
|
@@ -0,0 +1,233 @@ | |||
//// |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the filename use only lower-case characters?
|
||
[IMPORTANT] | ||
==== | ||
S2I is not supported for native deployments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not relevant for upstream. It works upstream, but support not provided for it downstream.
This PR aims to draft a procedure for the following use case:
Reference: Using S2I to deploy on OpenShift