-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TreeAny, accessors/rename, JSONPath #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* change traverse_by_key signature to make name optional and static * derive macro: support rename, drop __MINICONF_NAMES for tuple struct * increment_error -> Error::increment * major docs cleanup, rework
* makes behavior of path/indices/packed consistent * otherwise finding correct indices length during iteration becomes very inefficient * annoying to return packed in conversion
chore: Release miniconf version 0.10.1 * tag 'miniconf-v0.10.1': chore: Release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot here, so I went over it the best I could, but wasn't able to look at some of the implementation in detail.
8 tasks
ryan-summers
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the changelog:
Changed
Traversal
error enum has been split from theError<E>
enum to reduce genericism.Increment
trait and blanket impl removed in favor ofincrement_result
/Error::increment
/Traversal::increment
traverse_by_key
callback receives the field name as anOption<&'static str>
(
None
in the case of arrays and tuple structs).getter -> get
,setter -> get_mut
,and
validate
with more idiomatic and flexible usage and call sequencing.Metadata.separator()
has been changed to only return the new maximum length forconsistency and renamed to
max_length(separator: &str)
.Added
TreeAny
to access nodes troughAny
trait objects.TreeKey::json_path()
for JSON path notation.bar[5]
JsonPath: Keys
rename
field attribute for derive macrosExactSizeIterator
) through thecount()
"augmentation" methods on the iterators.
Removed
TreeKey::iter_*_unchecked()
have been removed. Uncounted iteration is the default.