Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send ICMP Packet Too Large if packet doesn't fit into QUIC datagram #28

Merged
merged 1 commit into from
Nov 10, 2024

Conversation

marten-seemann
Copy link
Member

@marten-seemann marten-seemann commented Nov 10, 2024

Part of #15. Fixes #27.

Copy link

codecov bot commented Nov 10, 2024

Codecov Report

Attention: Patch coverage is 89.06250% with 7 lines in your changes missing coverage. Please review.

Project coverage is 87.83%. Comparing base (84ab8bf) to head (cab0d28).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
conn.go 42.85% 3 Missing and 1 partial ⚠️
icmp.go 94.73% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
- Coverage   88.21%   87.83%   -0.39%     
==========================================
  Files           7        8       +1     
  Lines         611      674      +63     
==========================================
+ Hits          539      592      +53     
- Misses         56       63       +7     
- Partials       16       19       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marten-seemann marten-seemann force-pushed the icmp-packet-too-large branch 2 times, most recently from 73bc7cd to c7f0a58 Compare November 10, 2024 16:24
@marten-seemann marten-seemann merged commit 25cbbbc into master Nov 10, 2024
23 checks passed
@marten-seemann marten-seemann deleted the icmp-packet-too-large branch November 10, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add an integration test that transfers a large file
1 participant