Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve the packet API #30

Merged
merged 1 commit into from
Nov 10, 2024
Merged

improve the packet API #30

merged 1 commit into from
Nov 10, 2024

Conversation

marten-seemann
Copy link
Member

We need a way to easily return an ICMP packet to the caller.

Copy link

codecov bot commented Nov 10, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.96%. Comparing base (25cbbbc) to head (0ca27fd).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
conn.go 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
+ Coverage   87.83%   87.96%   +0.13%     
==========================================
  Files           8        8              
  Lines         674      673       -1     
==========================================
  Hits          592      592              
+ Misses         63       62       -1     
  Partials       19       19              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marten-seemann marten-seemann merged commit 892f6e9 into master Nov 10, 2024
23 checks passed
@marten-seemann marten-seemann deleted the packet-api branch November 10, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant