Publish linux/arm64 images #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| - name: Set up QEMU | ||
| id: qemu | ||
| uses: docker/setup-qemu-action@v1 |
There was a problem hiding this comment.
What does this do?
There was a problem hiding this comment.
It is installing QEMU binaries to support building for ARM.
The suggestion to use this came from docker/buildx#495 (comment), prior to including this I was getting many errors in my local fork, such as:
#15 28.06 Error while loading /usr/sbin/dpkg-split: No such file or directory
#15 28.07 Error while loading /usr/sbin/dpkg-deb: No such file or directory
#15 28.07 dpkg: error processing archive /tmp/apt-dpkg-install-Gsh52m/00-libssl1.1_1.1.1f-1ubuntu2.12_arm64.deb (--unpack):
#15 28.07 dpkg-deb --control subprocess returned error exit status 1
|
Hi @marten-seemann, can this be merged? |
|
@WesleyRosenblum CI seems unhappy with this change. Can you check what's going on? |
I can't see the exact issue, but I'm guessing it's because pull requests from forked repos do not have access to the secrets needed to login to Docker hub |
|
Ok, let's see how it behaves on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change upgrades to docker/build-push-action v2 (which supports building multi-platform images) and adds support for
linux/arm64. This is needed for running the quic network simulator locally on ARM hardware, such as Apple M1.