Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Check for PipeWire as well as PulseAudio before falling back to ALSA #1565

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Check for PipeWire as well as PulseAudio before falling back to ALSA #1565

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion quickemu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -882,7 +882,7 @@ function configure_storage() {
function configure_display() {
# Determine which audio driver use between Pulseaudio or ALSA
local AUDIO_DRIVER="pa"
if ! command -v pacmd >/dev/null 2>&1 ; then
if ! command -v pacmd >/dev/null 2>&1 && ! command -v pipewire-pulse >/dev/null 2>&1; then
AUDIO_DRIVER="alsa"
fi
Comment on lines +885 to 887
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if ! command -v pacmd >/dev/null 2>&1 && ! command -v pipewire-pulse >/dev/null 2>&1; then
AUDIO_DRIVER="alsa"
fi
if pidof pipewire >/dev/null 2>&1; then
# QEMU's pipewire audio backend was added in version 8.1
if [ "${QEMU_VER_SHORT}" -ge 81 ]; then
AUDIO_DRIVER="pipewire"
fi
elif ! pidof pulseaudio >/dev/null 2>&1; then
AUDIO_DRIVER="alsa"
fi

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea to test pipewire and pulseaudio with pidof and this include pipewire to the project :)


Expand Down