Fix no-protection
option in perf crate
#1550
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While profiling stuff with perf_server and perf_client, I discovered that the
no-protection
option was not working as expected (it did not disable packet encryption / decryption, as my flamegraphs revealed). It looks like the original feature did disable encryption after a key update, but forgot to do so right after the handshake. This PR fixes that.In case you are curious, you can observe the problem by running the following commands:
cargo run --release --bin perf_server
cargo run --release --bin perf_client -- --no-protection