proto: Connection side enum #2084
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ralith
approved these changes
Dec 14, 2024
gretchenfrage
force-pushed
the
connection-side-enum
branch
from
f59b9b6 to
e729e93
Compare
Ralith
reviewed
Dec 14, 2024
gretchenfrage
force-pushed
the
connection-side-enum
branch
2 times, most recently
from
9395751 to
ea8bb80
Compare
gretchenfrage
force-pushed
the
connection-side-enum
branch
from
ea8bb80 to
81a3ea2
Compare
Ralith
approved these changes
Dec 14, 2024
Moves server/client-specific fields of proto::Connection to a new SideState enum.
Server/client-specific args to proto::Connection::new are now passed through a new SideArgs enum.
gretchenfrage
force-pushed
the
connection-side-enum
branch
from
81a3ea2 to
2d21680
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some notable differences from how I approached this in #1912:
ConnectionSiderather thanSideStateConnection.siderather thanConnection.side_state. The causes changes to be necessary to a different, but smaller set of lines of code, since now every existing instance ofself.side.is_client()orself.side.is_server()just works as-is. And it's terser.SideArgsand animpl From<SideArgs> for ConnectionSide, in the interest of taking some complexity load off ofConnection::new, which is already over 100 lines.