Prepare libQuotient for operating without being able to reach the server #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Great job, tobias, create a merge request that does everything except the thing it says it does 🤦♂️ |
TobiasFella
force-pushed
the
tobias/no-eventloop
branch
from
479a8df to
b8e932d
Compare
TobiasFella
changed the title
|
Slightly hijacked the merge request to do the rest of what I want to do; see individual commits for details |
KitsuneRal
requested changes
Jul 19, 2024
KitsuneRal
reviewed
Jul 23, 2024
KitsuneRal
reviewed
Jul 23, 2024
This is important for clients to know the point from which it is safe to load state without risking problems due to the e2ee machinery not being ready yet.
… before connecting to the server This allows libQuotient-based clients to operate with the cached state (and in the future, room events) when there is no network connection. It's losing the check whether userid and deviceid correspond to the given token, but I don't see a strong need for that.
Linux pipelines fail mysteriously since the rewrite, with the keychain job getting deleted before yielding the result - maybe the newest Qt Keychain would be better?
TobiasFella
force-pushed
the
tobias/no-eventloop
branch
from
18592a6 to
e3fbbc5
Compare
KitsuneRal
force-pushed
the
tobias/no-eventloop
branch
from
61fe407 to
45adeee
Compare
Qt 6.4 doesn't handle QFutures with move-only results well. The workaround for now is to pass the reference to the ultimate move-only result (i.e. Connection::Private::encryptionData) into all the continuations as a captured variable. Once we require at least Qt 6.5 this workaround can be removed and normal QFuture logic used to pass defered results around.
KitsuneRal
force-pushed
the
tobias/no-eventloop
branch
from
45adeee to
e447f41
Compare
|
The last round and then merge. |
KitsuneRal
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.