Add TCP Socket Support #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Initial feedback:
|
|
Socket model has been changed over to use streams for all responses from the connections. (similar to what we use for serial/usb connections) |
|
Client hasn't provided feedback, we'll merge as-is and improve on master as we move forward. Please consider this API volatile until there's more use-cases for it. (Disclaimer added to this bug report, the wiki and sample.html). Unrelated, but this PR will probably cause a few merge conflicts do to some well needed reformatting that occurs as part of this branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft documentation: https://qz.io/wiki/Socket-Communication
Note, this feature is a work-in-progress. To use this feature, you must compile this branch by hand.