Use fs for all file path operations

[mpadge]

I recently got an email about gtfsrouter luckily with reprex pasted in to show that file paths on windows were unusable, just because of combining temp.dir() with file.path(). Using fs solves those issues be standardising paths on windows, which I suggest would also be good to implement here. Happy to do this if nobody else is?

[polettif]

Sounds good, thanks 👍 I probably should look into fs, haven't used it so far.

[rafapereirabr]

Hi @mpadge , thanks for the heads up ! Could you please share the reprex they sent you?

ps. I usually use tempdir() and tools::R_user_dir() in others packages but I haven't come across any issues so far.

[mpadge]

The reprex was this:

> f <- berlin_gtfs_to_zip ()
> gtfs <- extract_gtfs (f, quiet = TRUE)

#> Errore in check_extract_pars(filename, stn_suffixes) :
#>  filename C:\Users\<User>\AppData\Local\Temp\Rtmp4GhleE/vbb.zip does not exist

The filepath for f constructed in berlin_gtfs_to_zip() just used file.path(tempdir(), "vbb.zip"). And on windows that led to tempdir() using \, but file.path() appending filename with /. This can always happen with windows systems, which was one of the motivations for the fs package. fs always normalises paths to use consistent deilimiters. The package has no additional deps at all, is very lightweight, and has 1-1 replacements for all standard functions:

fs::path(fs::path_temp(), "vbb.zip")

[rafapereirabr]

Thanks for sharing, @mpadge !