Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix text field name #192

Merged
merged 9 commits into from
Oct 26, 2023
Merged

Fix text field name #192

merged 9 commits into from
Oct 26, 2023

Conversation

YoussefHachicha
Copy link
Contributor

  • fixed the name text field in the CardBuilder
  • improved text field user experience by adding keyboard options and when clicked outside the text fields it will hide the keyboard automaticlly

@r0adkll r0adkll self-requested a review October 24, 2023 16:41
@YoussefHachicha
Copy link
Contributor Author

how do i run the cicd to check if there is an issue or not, I am sorry this is my first time contributing

@r0adkll
Copy link
Owner

r0adkll commented Oct 24, 2023

how do i run the cicd to check if there is an issue or not, I am sorry this is my first time contributing

Workflows are by default not automatically run from PRs based on public forks (see: https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks). This should not be the case once you are no longer a first time contributor (i.e. after we get this PR merged 🎉 )

For now just ping me when you are ready to run it again, or you can run the ./scripts/spotlessApply script in the repo to check/fix your code style mistakes.

@r0adkll
Copy link
Owner

r0adkll commented Oct 24, 2023

Additionally, I have this ./gradlew boostrap task that you can run to apply a pre-push git hook to run the above script before you push changes, ensuring that your code styling is proper before pushing

@YoussefHachicha
Copy link
Contributor Author

@r0adkll
thanks,i have a question regarding the spotless how does it run? do you just add the .editorconfig and everyone who clones the project will get the same code style from there?

@r0adkll
Copy link
Owner

r0adkll commented Oct 25, 2023

@r0adkll thanks,i have a question regarding the spotless how does it run? do you just add the .editorconfig and everyone who clones the project will get the same code style from there?

.editorconfig is part of it, but the Spotless plugin applies ktlint under the hood which takes into account the .editorconfig along with a default codestyle rule set that it applies/checks.

r0adkll
r0adkll requested changes Oct 26, 2023
View reviewed changes
Copy link
Owner

@r0adkll r0adkll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The kotlinScripting.xml file is still deleted and needs to be re-added.

@r0adkll r0adkll merged commit dee40b8 into r0adkll:modern Oct 26, 2023
5 checks passed
@r0adkll
Copy link
Owner

r0adkll commented Oct 26, 2023

Congrats on your first contribution! I really appreciate helping to improve this project.

@YoussefHachicha
Copy link
Contributor Author

thanks @r0adkll, if you have the time in the weekend do you want to share ideas and thoughts about Kotlin, I see that we could learn from each other, let me know if you are down and I will organize a meeting over zoom. also I want to say thanks for taking the time and effort to review my code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r0adkll r0adkll r0adkll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YoussefHachicha @r0adkll