Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: build spec experience #331

Merged
merged 35 commits into from
Dec 5, 2024
Merged

fix: build spec experience #331

merged 35 commits into from
Dec 5, 2024

Conversation

AlexD10S
Copy link
Collaborator

@AlexD10S AlexD10S commented Nov 1, 2024 •
edited
Loading

Fixes #305

Changes

  1. Add the flag --chain to specify the chain specification. Is to add this flag: https://github.com/paritytech/polkadot-sdk/blob/master/substrate/client/cli/src/params/shared_params.rs#L32 when running the build-spec command of the binary.
    To generate pop-node chain_spec mainnet for example can be done with:
    pop build spec --release --id 4024 --type live --relay paseo --chain mainnet
    (https://github.com/r0gue-io/pop-node/blob/main/node/src/command.rs#L73)

  2. As pointed in the issue the --default-bootnode was a bit confusing because by default was set to true and to don't include localhost as the default bootnode has to be specified with --default-bootnode false.
    Set by default to false and included if specified --default-bootnode.
    The other approach is to change the name to --disable-default-bootnode and set it by default to false unless the flag is included.

@codecov Codecov
Copy link

codecov bot commented Nov 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 81.43564% with 150 lines in your changes missing coverage. Please review.

Project coverage is 74.29%. Comparing base (d1cf48d) to head (3cd8194).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/pop-cli/src/commands/build/spec.rs 81.49% 52 Missing and 42 partials ⚠️
crates/pop-cli/src/cli.rs 46.34% 22 Missing ⚠️
crates/pop-parachains/src/build.rs 75.86% 4 Missing and 10 partials ⚠️
crates/pop-cli/src/commands/build/mod.rs 66.66% 8 Missing and 4 partials ⚠️
crates/pop-cli/src/commands/build/parachain.rs 66.66% 0 Missing and 4 partials ⚠️
crates/pop-common/src/manifest.rs 95.08% 0 Missing and 3 partials ⚠️
crates/pop-common/src/build.rs 98.18% 0 Missing and 1 partial ⚠️ 
@@            Coverage Diff             @@
##             main     #331      +/-   ##
==========================================
+ Coverage   72.59%   74.29%   +1.69%     
==========================================
  Files          56       56              
  Lines       10700    11233     +533     
  Branches    10700    11233     +533     
==========================================
+ Hits         7768     8345     +577     
+ Misses       1844     1746      -98     
- Partials     1088     1142      +54
Files with missing lines Coverage Δ
crates/pop-cli/src/commands/call/contract.rs 83.40% <100.00%> (+0.05%) ⬆️
crates/pop-cli/src/commands/mod.rs 16.32% <100.00%> (ø)
crates/pop-common/src/build.rs 98.48% <98.18%> (-1.52%) ⬇️
crates/pop-common/src/manifest.rs 93.51% <95.08%> (+0.30%) ⬆️
crates/pop-cli/src/commands/build/parachain.rs 73.49% <66.66%> (+0.32%) ⬆️
crates/pop-cli/src/commands/build/mod.rs 50.00% <66.66%> (-0.71%) ⬇️
crates/pop-parachains/src/build.rs 88.17% <75.86%> (-0.72%) ⬇️
crates/pop-cli/src/cli.rs 65.46% <46.34%> (-1.90%) ⬇️
crates/pop-cli/src/commands/build/spec.rs 73.64% <81.49%> (+73.64%) ⬆️

@AlexD10S AlexD10S requested a review from brunopgalvao November 4, 2024 10:47
@brunopgalvao
Copy link
Contributor

Looking good. Some notes:

--release option is confusing, what does this do? It says: "For production, always build in release mode to exclude debug features", so will the pop build spec --release build the parachain in release mode?

I think --release should be removed and the default should be so that when the user runs pop build spec it will build in release mode by default.

pop build spec --release --id 4024 --type live --relay paseo --chain mainnet

For some reason this does not work, not sure if it is a pop-cli issue or a pop-node issue, also something to keep in mind, mainnet on pop-node uses the polkadot relay, so I guess the user would have to be aware to use the appropriate flags to generate the chain spec.

@AlexD10S
Copy link
Collaborator Author

AlexD10S commented Nov 5, 2024 •
edited
Loading

Looking good. Some notes:

--release option is confusing, what does this do? It says: "For production, always build in release mode to exclude debug features", so will the pop build spec --release build the parachain in release mode?

I think --release should be removed and the default should be so that when the user runs pop build spec it will build in release mode by default.

pop build spec --release --id 4024 --type live --relay paseo --chain mainnet

For some reason this does not work, not sure if it is a pop-cli issue or a pop-node issue, also something to keep in mind, mainnet on pop-node uses the polkadot relay, so I guess the user would have to be aware to use the appropriate flags to generate the chain spec.

You are right about the --release flag been confusing, similar as the problem above with --default-bootnode flag, it has the default_value to true. I like your suggestion, I deprecated it the release flag and it builds in RELEASE mode by default.

About this: pop build spec --release --id 4024 --type live --relay paseo --chain mainnet not working, you probably have an old version of pop-node. See https://github.com/r0gue-io/pop-node/blob/main/node/src/command.rs#L73
You can check if your build has the mainnet available running:./target/release/pop-node build-spec --chain mainnet

@AlexD10S AlexD10S marked this pull request as ready for review November 5, 2024 09:37
@evilrobot-01 evilrobot-01 requested a review from al3mart November 5, 2024 12:50
evilrobot-01
evilrobot-01 reviewed Nov 5, 2024
View reviewed changes
Copy link
Contributor

@evilrobot-01 evilrobot-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, would just appreciate some context in terms of the deprecation of release option. Why not leave the flexibility?

Would also want @al3mart to look this PR over before being merged.

crates/pop-cli/src/commands/build/spec.rs Outdated Show resolved Hide resolved
crates/pop-cli/src/commands/build/spec.rs Outdated Show resolved Hide resolved
crates/pop-cli/src/commands/build/spec.rs Outdated Show resolved Hide resolved
@AlexD10S
Copy link
Collaborator Author

AlexD10S commented Nov 5, 2024

Looks good, would just appreciate some context in terms of the deprecation of release option. Why not leave the flexibility?

Would also want @al3mart to look this PR over before being merged.

My apologies for not mentioning it in the PR description. The deprecation of the --release flag was implemented in response to a feedback comment #331 (comment) on the flag being confusing.

The changes were made in a single commit 37bb25d. so will be easy to revert if we decide to keep it. What are your thoughts, @al3mart? A better approach suggested?

al3mart
al3mart reviewed Nov 5, 2024
View reviewed changes
Copy link
Contributor

@al3mart al3mart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build spec might trigger a compilation. I feel that having the option of declaring if we want the profile to be release or debug can be convenient .

If we didn't have the flag anywhere else I think removing it might make more sense.
The flag was added mainly so the options for builds were consistent across sub commands
Maybe we can improve the doc as a way to clarify why that flag is present..

@AlexD10S
Copy link
Collaborator Author

AlexD10S commented Nov 5, 2024

build spec might trigger a compilation. I feel that having the option of declaring if we want the profile to be release or debug can be convenient .

If we didn't have the flag anywhere else I think removing it might make more sense. The flag was added mainly so the options for builds were consistent across sub commands Maybe we can improve the doc as a way to clarify why that flag is present..

You are right, It makes sense to keep it consistent across the comment. I removed the deprecation message and added more information in the docs to clarify that this command builds the node if it hasn't been built yet.

@brunopgalvao
Copy link
Contributor

brunopgalvao commented Nov 6, 2024 •
edited
Loading

build spec might trigger a compilation. I feel that having the option of declaring if we want the profile to be release or debug can be convenient .

If we didn't have the flag anywhere else I think removing it might make more sense. The flag was added mainly so the options for builds were consistent across sub commands Maybe we can improve the doc as a way to clarify why that flag is present..

What is the difference in the outputted chain spec artifacts when using debug vs release? Can the runtime wasm be different?

@brunopgalvao
Copy link
Contributor

About this: pop build spec --release --id 4024 --type live --relay paseo --chain mainnet not working, you probably have an old version of pop-node. See https://github.com/r0gue-io/pop-node/blob/main/node/src/command.rs#L73
You can check if your build has the mainnet available running:./target/release/pop-node build-spec --chain mainnet

Yes you are right. Since there are quite a few options for this command that are needed, it would be nice to have an error if for example --chain mainnet does not exist instead of the CLI doing nothing which is what it currently does.

@AlexD10S AlexD10S mentioned this pull request Nov 6, 2024
Open
@AlexD10S
Copy link
Collaborator Author

AlexD10S commented Nov 6, 2024

Yes you are right. Since there are quite a few options for this command that are needed, it would be nice to have an error if for example --chain mainnet does not exist instead of the CLI doing nothing which is what it currently does.

Yes, makes sense. Logs of the command ./target/release/pop-node build-spec are hidden, maybe we should show them if there is an error: #337

@al3mart
Copy link
Contributor

al3mart commented Nov 6, 2024

build spec might trigger a compilation. I feel that having the option of declaring if we want the profile to be release or debug can be convenient .
If we didn't have the flag anywhere else I think removing it might make more sense. The flag was added mainly so the options for builds were consistent across sub commands Maybe we can improve the doc as a way to clarify why that flag is present..

What is the difference in the outputted chain spec artifacts when using debug vs release? Can the runtime wasm be different?

Regarding the resulting wasm I'd say that the only possible difference is that if it is not built in release it may contain some extra debug information that can be logged. Release also tries to compile with optimization. This comes to mind - https://paritytech.github.io/polkadot-sdk/master/frame_support/derive.RuntimeDebugNoBound.html

al3mart
al3mart approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@al3mart al3mart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the change on default value for --default-bootnode makes sense. I can see how that was confusing.

Love the addition of --chain. Was definitely something needed.

crates/pop-cli/src/commands/build/spec.rs Outdated Show resolved Hide resolved
crates/pop-cli/src/commands/build/spec.rs Outdated Show resolved Hide resolved
crates/pop-cli/src/commands/build/spec.rs Outdated Show resolved Hide resolved
evilrobot-01
evilrobot-01 requested changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@evilrobot-01 evilrobot-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the multi/spinner can be improved a little quite easily.

crates/pop-cli/src/commands/build/spec.rs Outdated Show resolved Hide resolved
crates/pop-cli/src/commands/build/spec.rs Outdated Show resolved Hide resolved
@evilrobot-01
Copy link
Contributor

As mentioned separately, there is no consideration for builds using the production profile, which is potentially an important use case. Whilst this may have no effect on the resulting wasm, it did mean a rebuild of the node despite me already having a production build at target/production. This obviously is a waste of time and local storage and also might be frustrating to an end user.

This might be an edge case, but I think the tooling should ideally cater to both novice and professional devs.

evilrobot-01
evilrobot-01 approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@evilrobot-01 evilrobot-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks!

@evilrobot-01
Copy link
Contributor

As mentioned separately, there is no consideration for builds using the production profile, which is potentially an important use case. Whilst this may have no effect on the resulting wasm, it did mean a rebuild of the node despite me already having a production build at target/production. This obviously is a waste of time and local storage and also might be frustrating to an end user.

Related to this, the same happens if you have a binary built already using the default debug profile and then run the build spec command - it rebuilds it all with the release profile as that is defaulted to true. Purely based on UX, might it be best to allow the user to either specify via --debug (-d), --release (-r), --profile name (-p) and if not specified, simply add a prompt with these same options?

@AlexD10S AlexD10S mentioned this pull request Nov 27, 2024
Merged
al3mart
al3mart approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@al3mart al3mart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Looking forward to merging this one!

@Daanvdplas Daanvdplas self-requested a review December 5, 2024 17:39
al3mart
al3mart approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@al3mart al3mart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new commits after my last approval seem to make sense. Thanks for addressing those!

@AlexD10S AlexD10S merged commit 3f86d18 into main Dec 5, 2024
20 checks passed
@AlexD10S AlexD10S deleted the fix/build-spec branch December 5, 2024 19:38
AlexD10S added a commit that referenced this pull request Dec 11, 2024
@AlexD10S @al3mart @Daanvdplas
fix: build spec experience (#331)
1bc52dc 
* fix: add chain to specify the chain specification

* fix: default_bootnode by default to true

* chore: fmt

* chore: deprecate flag --release in build specs

* fix: clean output (#334)

* fix: undo deprecation of --release flag

* refactor: small fix

* style: remove extra space

* fix(spec): better handling of spinner

* style: use spinner instead of multispinner

* docs: help message to include build

* feat: reuse existing chain spec

* refactor: remove clone

* refactor: opt in to edit provided chain spec

* docs: improve

* refactor: flow flag input

* fix: prepare_output_path

* refactor: resolve small improvements

* fix: protocol id prompt

* fix: spinner

* fix: docs

* test: test cli

* chore: refactor

* chore: amend test

* feat: production profile

* refactor: improve profile experience

* chore: feedback and rebase

* chore: add profile tests

* fix(test): parachain_lifecycle

* style: fmt

* fix: clippy

* fix: cli required changes introduced by PR

* fix: test

* fix: clippy

* docs: deprecation message

---------

Co-authored-by: Alejandro Martinez Andres <[email protected]>
Co-authored-by: Daanvdplas <[email protected]>
AlexD10S added a commit that referenced this pull request Dec 11, 2024
@AlexD10S @al3mart @Daanvdplas
fix: build spec experience (#331)
bf5fc96 
* fix: add chain to specify the chain specification

* fix: default_bootnode by default to true

* chore: fmt

* chore: deprecate flag --release in build specs

* fix: clean output (#334)

* fix: undo deprecation of --release flag

* refactor: small fix

* style: remove extra space

* fix(spec): better handling of spinner

* style: use spinner instead of multispinner

* docs: help message to include build

* feat: reuse existing chain spec

* refactor: remove clone

* refactor: opt in to edit provided chain spec

* docs: improve

* refactor: flow flag input

* fix: prepare_output_path

* refactor: resolve small improvements

* fix: protocol id prompt

* fix: spinner

* fix: docs

* test: test cli

* chore: refactor

* chore: amend test

* feat: production profile

* refactor: improve profile experience

* chore: feedback and rebase

* chore: add profile tests

* fix(test): parachain_lifecycle

* style: fmt

* fix: clippy

* fix: cli required changes introduced by PR

* fix: test

* fix: clippy

* docs: deprecation message

---------

Co-authored-by: Alejandro Martinez Andres <[email protected]>
Co-authored-by: Daanvdplas <[email protected]>
peterwht added a commit that referenced this pull request Dec 16, 2024
@AlexD10S @peterwht
@evilrobot-01 @al3mart @Daanvdplas
feat: wallet integration call contract (#378)
6c6de9a 
* feat(wallet-integration): server and API (#362)

* feat(wallet-integration): implement server and API

* feat(wallet-integration): add a few tests to server. Needs more

* refactor(wallet-integration): just use call_data, remove data types

* feat(wallet-integration): add frontend type for flexible serving

* feat(wallet-integration): StateHandler in WalletIntegrationManager. Add terminate method

* refactor(wallet-integration): move to module with pop-cli crate

* feat(wallet-integration): server-side error handling, update port to 9090

* refactor(wallet-integration): restructure server for easier use in thread

* fix(wallet-integration): remove invalid fn `finish`

* docs(wallet-integration): inline comments

* test(wallet-integration): unit tests for wallet-integration server. Add new frontend type

* feat(wallet-integration): two new routes: error and terminate

* refactor(wallet-integration): consistent comments, remove unnecessary code in tests

* feat: add TransactionData::new

* refactor(wallet-integration: shutdown channel error handling, terminate helper, take_error and TranscationData::new tests

* chore: clippy warning

* feat(up-contract): get call data for upload-only and pass to wallet integration -- PoC

* feat(up-contract): get call data for instantiate and pass to wallet integration -- PoC

* feat(up-contract): run server and pass call_data for signing -- PoC

* feat(up-contract): submit signed payload to node

* fix(up-contract): update to FrontendFromDir type

* refactor(pop-up): create functions for wallet integration, plus general cleanup

* chore: use git branch for cargo contract

* feat(pop-up-contract): better error handling and prompt displays

* chore(up-contract): outdated field name and clippy allow

* feat(up-contract): handle subxt events better, various improvements

* feat(up-contract): custom errors in contracts crate

* feat(wallet-integration): implement server and API

* feat(wallet-integration): add a few tests to server. Needs more

* refactor(wallet-integration): just use call_data, remove data types

* feat(wallet-integration): add frontend type for flexible serving

* feat(wallet-integration): StateHandler in WalletIntegrationManager. Add terminate method

* refactor(wallet-integration): move to module with pop-cli crate

* feat(wallet-integration): server-side error handling, update port to 9090

* refactor(wallet-integration): restructure server for easier use in thread

* fix(wallet-integration): remove invalid fn `finish`

* docs(wallet-integration): inline comments

* test(wallet-integration): unit tests for wallet-integration server. Add new frontend type

* feat(wallet-integration): two new routes: error and terminate

* refactor(wallet-integration): consistent comments, remove unnecessary code in tests

* feat: add TransactionData::new

* feat: guide user to call a contract (#306)

* feat: guide user for calling a contract

* feat: get metadata contract from the contract path

* refactor: refactor test and validate address input

* fix: apply feedback

* feat: prompt to have another call and skip questions for queries

* refactor: use Cli module instead of cliclack

* test: unit test pop-cli crate

* test: unit contracts crate

* chore: format

* test: refactor and improve test cases

* fix: fix todos and refactor

* test: fix unit test

* feat: parse types of parameters and display it to the user in the placeholder

* refactor: error handling for pop call

* refactor: display call to be executed after guide and reorder

* refactor: when repeat call use same contract values and dont clean screen

* test: add dry-run test

* test: refactor and add more test coverage

* test: more coverage

* fix: unit test

* feat: dev mode to skip certain user prompts

* refactor: test functions, renaming and fix clippy

* refactor: improve devex of pop call contract

* test: adjust tests to refactor

* chore: reset_for_new_call fields

* fix: build contract if has not been built

* refactor: use command state (#338)

Merged set_up_call_config and guide_user_to_call_contract into a single function. Also adds short symbols for arguments.

* fix: parse user inputs for Option arguments (#332)

* fix: automatically add some or none to Option argument

* test: refactor and tests

* refactor: improve code and comments

* fix: renaming and clean code

* chore: option params not mandatory

* fix: parse user inputs for Option arguments in constructor (#335)

* fix: automatically add some or none to Option argument

* fix: tests

* refactor: process_function_args

* test: update tests accordingly last changes

* fix: issue with delimiter

* test: fix unit test

* refactor: renaming and fix comments

* refactor: format types (#339)

Shows the full type representation, making it easier to see the entry format of parameter values.

* fix: logo doesn't show in README

---------

Co-authored-by: Frank Bell <[email protected]>
Co-authored-by: Alejandro Martinez Andres <[email protected]>

* test: fix unit test

* feat: allow users to specify custom contract metadata files (#347)

* chore: allow the user specify the metadata file to call a contract

* test: unit test to parse metadata from a file

* docs: fix docs

* refactor: ensure_contract_built after user input path

* fix: call contract when metadata file

* fix: remove default_input in contract address

* docs: rename metadata with artifact

* fix: panic at has_contract_been_built

* fix: clippy

* refactor: keep ensure_contract_built as a CallContractCommand function

* fix: ensure_contract_built

* docs: improve comments

* fix: feedback and include wasm file for testing

* fix: clippy

* chore: after build contract prompt the user if the contract is already deployed

* refactor: ensure_contract_built

* refactor: has_contract_been_built function

* docs: fix comments and messages

* refactor: get_messages and get_constructors

* test: fix unit tests call ui

---------

Co-authored-by: Frank Bell <[email protected]>
Co-authored-by: Alejandro Martinez Andres <[email protected]>

* fix: support new substrate-contracts-node structure and stabilize integration tests (#360)

* fix: parse new structure substrate-contracts-node

* fix: paseo+coretime integration test

* fix: sourcing latest version substrate-contracts-node

* refactor: set_executable_permission function

* fix: clippy

* chore: CI configuration

* test: specify port in run_contracts_node

* fix: use random ports instead of hardcoded ones

* fix: build spec experience (#331)

* fix: add chain to specify the chain specification

* fix: default_bootnode by default to true

* chore: fmt

* chore: deprecate flag --release in build specs

* fix: clean output (#334)

* fix: undo deprecation of --release flag

* refactor: small fix

* style: remove extra space

* fix(spec): better handling of spinner

* style: use spinner instead of multispinner

* docs: help message to include build

* feat: reuse existing chain spec

* refactor: remove clone

* refactor: opt in to edit provided chain spec

* docs: improve

* refactor: flow flag input

* fix: prepare_output_path

* refactor: resolve small improvements

* fix: protocol id prompt

* fix: spinner

* fix: docs

* test: test cli

* chore: refactor

* chore: amend test

* feat: production profile

* refactor: improve profile experience

* chore: feedback and rebase

* chore: add profile tests

* fix(test): parachain_lifecycle

* style: fmt

* fix: clippy

* fix: cli required changes introduced by PR

* fix: test

* fix: clippy

* docs: deprecation message

---------

Co-authored-by: Alejandro Martinez Andres <[email protected]>
Co-authored-by: Daanvdplas <[email protected]>

* feat: guide user to call a parachain (#316)

* feat: guide user for calling a contract

* feat: get metadata contract from the contract path

* refactor: refactor test and validate address input

* fix: apply feedback

* feat: prompt to have another call and skip questions for queries

* refactor: use Cli module instead of cliclack

* test: unit test pop-cli crate

* test: unit contracts crate

* chore: format

* test: refactor and improve test cases

* fix: fix todos and refactor

* test: fix unit test

* feat: parse types of parameters and display it to the user in the placeholder

* refactor: error handling for pop call

* refactor: display call to be executed after guide and reorder

* refactor: when repeat call use same contract values and dont clean screen

* test: add dry-run test

* test: refactor and add more test coverage

* test: more coverage

* fix: unit test

* feat: dev mode to skip certain user prompts

* refactor: test functions, renaming and fix clippy

* refactor: improve devex of pop call contract

* test: adjust tests to refactor

* chore: reset_for_new_call fields

* fix: build contract if has not been built

* refactor: use command state (#338)

Merged set_up_call_config and guide_user_to_call_contract into a single function. Also adds short symbols for arguments.

* fix: automatically add some or none to Option argument

* test: refactor and tests

* refactor: improve code and comments

* fix: renaming and clean code

* chore: option params not mandatory

* fix: parse user inputs for Option arguments in constructor (#335)

* fix: automatically add some or none to Option argument

* fix: tests

* refactor: process_function_args

* test: update tests accordingly last changes

* fix: issue with delimiter

* test: fix unit test

* refactor: renaming and fix comments

* refactor: format types (#339)

Shows the full type representation, making it easier to see the entry format of parameter values.

* fix: logo doesn't show in README

* feat: pop call parachain prototype

* feat: dispaly arguments of extrinsic

* refactor: structure similar to pop call contract

* feat: parse all values for extrinsic/storage

* refactor: signer in common

* refactor: improve messages

* feat: call parachain ui

* fix: calls working

* refactor: remove unused code

* refactor: remove unused code

* refactor: various fixes

* refactor: various fixes

* feat: add option to include params from command line

* refactor: clean docs and refactor code

* fix: tests

* refactor: parse all the metadata again

* refactor: reorganize and clean metadata functions

* feat: display specific use cases to the user

* refactor: predefined actions

* fix: various fixes

* fix: error message not supported for complex types

* refactor: parse all metadata, including parameters at once

* refactor: clean docs and move code

* fix: format_type

* fix: parse user inputs for Option arguments (#332)

* fix: automatically add some or none to Option argument

* test: refactor and tests

* refactor: improve code and comments

* fix: renaming and clean code

* chore: option params not mandatory

* fix: parse user inputs for Option arguments in constructor (#335)

* fix: automatically add some or none to Option argument

* fix: tests

* refactor: process_function_args

* test: update tests accordingly last changes

* fix: issue with delimiter

* test: fix unit test

* refactor: renaming and fix comments

* refactor: format types (#339)

Shows the full type representation, making it easier to see the entry format of parameter values.

* fix: logo doesn't show in README

---------

Co-authored-by: Frank Bell <[email protected]>
Co-authored-by: Alejandro Martinez Andres <[email protected]>

* test: fix unit test

* refactor: clean the way to parse and prompt parameters

* feat: add Purchase on-demand coretime use cases

* test: add skip_confirm, move when prompt for the signer and create the integration test

* test: call parachain ui unit test

* refactor: separate structs

* fmt

* test: pop-cli unit testing

* test: pop-common unit tests

* test: parse metadata unit tests

* test: refactor and test processing parameters

* test: comments and unit test in call functions

* fix: clippy warnings

* chore: fmt

* fix: solve conflicts and unit tests (#359)

* test: call parachain ui unit test

* test: pop-cli unit testing

* test: pop-common unit tests

* test: parse metadata unit tests

* test: refactor and test processing parameters

* test: comments and unit test in call functions

* fix: clippy warnings

* chore: fmt

* fix: conflicts and unit tests

* test: remove test and improve test

* feat: guide user for calling a contract

* feat: get metadata contract from the contract path

* refactor: refactor test and validate address input

* fix: apply feedback

* feat: prompt to have another call and skip questions for queries

* refactor: use Cli module instead of cliclack

* test: unit test pop-cli crate

* test: unit contracts crate

* chore: format

* test: refactor and improve test cases

* fix: fix todos and refactor

* test: fix unit test

* feat: parse types of parameters and display it to the user in the placeholder

* refactor: error handling for pop call

* refactor: display call to be executed after guide and reorder

* refactor: when repeat call use same contract values and dont clean screen

* test: add dry-run test

* test: refactor and add more test coverage

* test: more coverage

* fix: unit test

* feat: dev mode to skip certain user prompts

* refactor: test functions, renaming and fix clippy

* refactor: improve devex of pop call contract

* test: adjust tests to refactor

* chore: reset_for_new_call fields

* fix: build contract if has not been built

* refactor: use command state (#338)

Merged set_up_call_config and guide_user_to_call_contract into a single function. Also adds short symbols for arguments.

* fix: automatically add some or none to Option argument

* test: refactor and tests

* refactor: improve code and comments

* fix: renaming and clean code

* chore: option params not mandatory

* fix: parse user inputs for Option arguments in constructor (#335)

* fix: automatically add some or none to Option argument

* fix: tests

* refactor: process_function_args

* test: update tests accordingly last changes

* fix: issue with delimiter

* test: fix unit test

* refactor: renaming and fix comments

* refactor: format types (#339)

Shows the full type representation, making it easier to see the entry format of parameter values.

* feat: pop call parachain prototype

* feat: dispaly arguments of extrinsic

* refactor: structure similar to pop call contract

* feat: parse all values for extrinsic/storage

* refactor: signer in common

* refactor: improve messages

* feat: call parachain ui

* fix: calls working

* refactor: remove unused code

* refactor: remove unused code

* refactor: various fixes

* refactor: various fixes

* feat: add option to include params from command line

* refactor: clean docs and refactor code

* fix: tests

* refactor: parse all the metadata again

* refactor: reorganize and clean metadata functions

* feat: display specific use cases to the user

* refactor: predefined actions

* fix: various fixes

* fix: error message not supported for complex types

* refactor: parse all metadata, including parameters at once

* refactor: clean docs and move code

* fix: format_type

* test: fix unit test

* refactor: clean the way to parse and prompt parameters

* feat: add Purchase on-demand coretime use cases

* test: add skip_confirm, move when prompt for the signer and create the integration test

* test: call parachain ui unit test

* test: pop-cli unit testing

* test: pop-common unit tests

* test: parse metadata unit tests

* test: refactor and test processing parameters

* test: comments and unit test in call functions

* fix: clippy warnings

* chore: fmt

* feat: repeat call only if using guide UI

* fix: clippy

* refactor: various improvements

* chore: parser for pallet and extrinsic input names

* refactor: only move to pop_common the needed functions

* refactor: improve test, docs and errors

* test: fix unit tests

* fix: reset_for_new_call when extrinisc is not supported

* fix: build with parachain features

* test: wait before call parachain in integration test

* docs: minor improvements

* test: migrate find_free_port to pop_common

* test: fix increase waiting time

* test: remove unnecesary test case

* refactor: rename api with client

* refactor: naming and docs

* docs: improve docs and missing comments

* test: remove unnecesary verbose

* test: find_free_port

* docs: improve parameter documentation

* test: add missing test to sign_and_submit_extrinsic

* fix: apply feedback from auxiliar PRs, remove unnecesary clones

* docs: public modules

* refactor: clean unused params

* fix: mark all extrinsics that uses calls as parameter as unsupported

* test: fix expect_select

* docs: improve documentation

* feat: submit extrinsic from call_data (#348)

* feat: submit extrinsic from call_data

* test: unit test for initialize_api_client

* test: unit test for send_extrinsic_from_call_data

* fix: CallData struct

* fix: skip_confirm for send_extrinsic_from_call_data

* chore: clippy

* chore: fmt

* refactor: minor doc and naming changes

* refactor: remove unnecesary clones and return early when submit_extrinsic_from_call_data

* chore: fmt

* refactor: split decode_call_data logic outside sign_and_submit_extrinsic_with_call_data

* feat: parse files when the argument values are very big (#363)

* feat: parse files when the argument values are very big

* test: unit test

* chore: fmt

* feat: file logic using the command line

* fix: sequence arguments

* test: fix unit test

* refactor: remove prompting the user if input is file or value

* refactor: parse_extrinsic_arguments

* fix: CI deny

* refactor: reorder Param  derive macros

* test: fix decode_call_data_works unit test

* refactor: use Default derive macro and define constants for test values (#366)

* feat: parse files when the argument values are very big

* chore: fmt

* feat: file logic using the command line

* fix: sequence arguments

* refactor: parse_extrinsic_arguments

* refactor: use Default in pop_parachain structs

* refactor: use Default in CallParachainCommand struct

* refactor: use constant in tests

* chore: fmt and small refactor

* feat: flag sudo to wrap extrinsic (#349)

* feat: submit extrinsic from call_data

* test: unit test for initialize_api_client

* feat: wrap call into a sudo call

* test: add unit test to the new logic

* fix: skip_confirm for send_extrinsic_from_call_data

* chore: clippy

* docs: renaming and improve docs

* test: use force_transfer for testing

* fix: check if sudo exist before prompt the user

* chore: fmt

* chore: fmt

* test: fix wrong assert

* docs: improve comments and output messages

* refactor: split decode_call_data logic outside sign_and_submit_extrinsic_with_call_data

* fix: test construct_sudo_extrinsic_works and formatting

* refactor: various fixes and improvements (#367)

* refactor: sort pallets/dispatchables

* refactor: remove unnecessary async

* fix: resolve issue after rebase

* fix: more async issues after rebase

* refactor: use single constant

* refactor: terminology (#368)

* refactor: terminology

* refactor: simply pallet/function relationship

* fix: amend call_data conflicts after refactor

* refactor: improvements (#370)

* fix: add missing short arg option

* refactor: note that extrinsic wait includes finalization

* refactor: remove clones

* style: formatting

* refactor: make file prompt more generic

* refactor: add missing license headers

* style: formatting

* docs: comments

* docs: comments

* docs: comments

* refactor: reuse existing metadata

* refactor: minimise clones

* docs: comments

* refactor: naming

* docs: fix parameter doc comments

* refactor: address clippy warnings

* refactor: rename parachain with chain as the primary command and retain parachain as an alias (#373)

* refactor: rename parachain with chain in visible messages

* refactor: rename parachain with chain internal code

* chore: solve fmt after rebase

* refactor: small fix, use alias instead aliases

* refactor: rename CallParachain struct into Call

---------

Co-authored-by: Frank Bell <[email protected]>
Co-authored-by: Alejandro Martinez Andres <[email protected]>
Co-authored-by: Daanvdplas <[email protected]>

* feat(wallet-integration): server and API (#362)

* feat(wallet-integration): implement server and API

* feat(wallet-integration): add a few tests to server. Needs more

* refactor(wallet-integration): just use call_data, remove data types

* feat(wallet-integration): add frontend type for flexible serving

* feat(wallet-integration): StateHandler in WalletIntegrationManager. Add terminate method

* refactor(wallet-integration): move to module with pop-cli crate

* feat(wallet-integration): server-side error handling, update port to 9090

* refactor(wallet-integration): restructure server for easier use in thread

* fix(wallet-integration): remove invalid fn `finish`

* docs(wallet-integration): inline comments

* test(wallet-integration): unit tests for wallet-integration server. Add new frontend type

* feat(wallet-integration): two new routes: error and terminate

* refactor(wallet-integration): consistent comments, remove unnecessary code in tests

* feat: add TransactionData::new

* refactor(wallet-integration: shutdown channel error handling, terminate helper, take_error and TranscationData::new tests

* chore: clippy warning

* feat(up-contract): get call data for upload-only and pass to wallet integration -- PoC

* chore: use git branch for cargo contract

* feat(up-contract): handle subxt events better, various improvements

* refactor: reuse pop up logic

* chore: rebase fixes

* refactor: clean after rebase

* fix: cargo.lock after rebase

* refactor: move terminate node into common::contracts

* fix: sp-core not only for contracts

* feat(up-contract): serve HTML from string, fix deployment message on error, cors, and other misc. improvements

* fix: rebase

* chore: deny.toml license

* feat: secure signing logic for pop call contract

* feat: integrate secure signing with pop call contract

* test: adapt pop-cli ui tests

* refactor: clean code

* docs: improve docs functions

* test: ignore failing test (fixed in another PR), and remove println

* fix: import removed by mistake

* feat(up-contract): serve HTML from string, fix deployment message on error, cors, and other misc. improvements

* feat(up-contract): serve HTML from string, fix deployment message on error, cors, and other misc. improvements

* feat(wallet-integration): server and API (#362)

* feat(wallet-integration): implement server and API

* feat(wallet-integration): add a few tests to server. Needs more

* refactor(wallet-integration): just use call_data, remove data types

* feat(wallet-integration): add frontend type for flexible serving

* feat(wallet-integration): StateHandler in WalletIntegrationManager. Add terminate method

* refactor(wallet-integration): move to module with pop-cli crate

* feat(wallet-integration): server-side error handling, update port to 9090

* refactor(wallet-integration): restructure server for easier use in thread

* fix(wallet-integration): remove invalid fn `finish`

* docs(wallet-integration): inline comments

* test(wallet-integration): unit tests for wallet-integration server. Add new frontend type

* feat(wallet-integration): two new routes: error and terminate

* refactor(wallet-integration): consistent comments, remove unnecessary code in tests

* feat: add TransactionData::new

* refactor(wallet-integration: shutdown channel error handling, terminate helper, take_error and TranscationData::new tests

* chore: clippy warning

* feat(up-contract): get call data for upload-only and pass to wallet integration -- PoC

* feat(up-contract): get call data for instantiate and pass to wallet integration -- PoC

* refactor(pop-up): create functions for wallet integration, plus general cleanup

* chore: use git branch for cargo contract

* feat(up-contract): handle subxt events better, various improvements

* feat(wallet-integration): implement server and API

* feat(wallet-integration): add a few tests to server. Needs more

* refactor(wallet-integration): just use call_data, remove data types

* feat(wallet-integration): add frontend type for flexible serving

* feat(wallet-integration): StateHandler in WalletIntegrationManager. Add terminate method

* refactor(wallet-integration): move to module with pop-cli crate

* feat(wallet-integration): server-side error handling, update port to 9090

* refactor(wallet-integration): restructure server for easier use in thread

* fix(wallet-integration): remove invalid fn `finish`

* docs(wallet-integration): inline comments

* test(wallet-integration): unit tests for wallet-integration server. Add new frontend type

* feat(wallet-integration): two new routes: error and terminate

* refactor(wallet-integration): consistent comments, remove unnecessary code in tests

* feat: guide user to call a contract (#306)

* feat: guide user for calling a contract

* feat: get metadata contract from the contract path

* refactor: refactor test and validate address input

* fix: apply feedback

* feat: prompt to have another call and skip questions for queries

* refactor: use Cli module instead of cliclack

* test: unit test pop-cli crate

* test: unit contracts crate

* chore: format

* test: refactor and improve test cases

* fix: fix todos and refactor

* test: fix unit test

* feat: parse types of parameters and display it to the user in the placeholder

* refactor: error handling for pop call

* refactor: display call to be executed after guide and reorder

* refactor: when repeat call use same contract values and dont clean screen

* test: add dry-run test

* test: refactor and add more test coverage

* test: more coverage

* fix: unit test

* feat: dev mode to skip certain user prompts

* refactor: test functions, renaming and fix clippy

* refactor: improve devex of pop call contract

* test: adjust tests to refactor

* chore: reset_for_new_call fields

* fix: build contract if has not been built

* refactor: use command state (#338)

Merged set_up_call_config and guide_user_to_call_contract into a single function. Also adds short symbols for arguments.

* fix: parse user inputs for Option arguments (#332)

* fix: automatically add some or none to Option argument

* test: refactor and tests

* refactor: improve code and comments

* fix: renaming and clean code

* chore: option params not mandatory

* fix: parse user inputs for Option arguments in constructor (#335)

* fix: automatically add some or none to Option argument

* fix: tests

* refactor: process_function_args

* test: update tests accordingly last changes

* fix: issue with delimiter

* test: fix unit test

* refactor: renaming and fix comments

* refactor: format types (#339)

Shows the full type representation, making it easier to see the entry format of parameter values.

* fix: logo doesn't show in README

---------

Co-authored-by: Frank Bell <[email protected]>
Co-authored-by: Alejandro Martinez Andres <[email protected]>

* test: fix unit test

* feat: allow users to specify custom contract metadata files (#347)

* chore: allow the user specify the metadata file to call a contract

* test: unit test to parse metadata from a file

* docs: fix docs

* refactor: ensure_contract_built after user input path

* fix: call contract when metadata file

* fix: remove default_input in contract address

* docs: rename metadata with artifact

* fix: panic at has_contract_been_built

* fix: clippy

* refactor: keep ensure_contract_built as a CallContractCommand function

* fix: ensure_contract_built

* docs: improve comments

* fix: feedback and include wasm file for testing

* fix: clippy

* chore: after build contract prompt the user if the contract is already deployed

* refactor: ensure_contract_built

* refactor: has_contract_been_built function

* docs: fix comments and messages

* refactor: get_messages and get_constructors

* test: fix unit tests call ui

---------

Co-authored-by: Frank Bell <[email protected]>
Co-authored-by: Alejandro Martinez Andres <[email protected]>

* fix: support new substrate-contracts-node structure and stabilize integration tests (#360)

* fix: parse new structure substrate-contracts-node

* fix: paseo+coretime integration test

* fix: sourcing latest version substrate-contracts-node

* refactor: set_executable_permission function

* fix: clippy

* chore: CI configuration

* test: specify port in run_contracts_node

* fix: use random ports instead of hardcoded ones

* feat: guide user to call a parachain (#316)

* feat: guide user for calling a contract

* feat: get metadata contract from the contract path

* refactor: refactor test and validate address input

* fix: apply feedback

* feat: prompt to have another call and skip questions for queries

* refactor: use Cli module instead of cliclack

* test: unit test pop-cli crate

* test: unit contracts crate

* chore: format

* test: refactor and improve test cases

* fix: fix todos and refactor

* test: fix unit test

* feat: parse types of parameters and display it to the user in the placeholder

* refactor: error handling for pop call

* refactor: display call to be executed after guide and reorder

* refactor: when repeat call use same contract values and dont clean screen

* test: add dry-run test

* test: refactor and add more test coverage

* test: more coverage

* fix: unit test

* feat: dev mode to skip certain user prompts

* refactor: test functions, renaming and fix clippy

* refactor: improve devex of pop call contract

* test: adjust tests to refactor

* chore: reset_for_new_call fields

* fix: build contract if has not been built

* refactor: use command state (#338)

Merged set_up_call_config and guide_user_to_call_contract into a single function. Also adds short symbols for arguments.

* fix: automatically add some or none to Option argument

* test: refactor and tests

* refactor: improve code and comments

* fix: renaming and clean code

* chore: option params not mandatory

* fix: parse user inputs for Option arguments in constructor (#335)

* fix: automatically add some or none to Option argument

* fix: tests

* refactor: process_function_args

* test: update tests accordingly last changes

* fix: issue with delimiter

* test: fix unit test

* refactor: renaming and fix comments

* refactor: format types (#339)

Shows the full type representation, making it easier to see the entry format of parameter values.

* fix: logo doesn't show in README

* feat: pop call parachain prototype

* feat: dispaly arguments of extrinsic

* refactor: structure similar to pop call contract

* feat: parse all values for extrinsic/storage

* refactor: signer in common

* refactor: improve messages

* feat: call parachain ui

* fix: calls working

* refactor: remove unused code

* refactor: remove unused code

* refactor: various fixes

* refactor: various fixes

* feat: add option to include params from command line

* refactor: clean docs and refactor code

* fix: tests

* refactor: parse all the metadata again

* refactor: reorganize and clean metadata functions

* feat: display specific use cases to the user

* refactor: predefined actions

* fix: various fixes

* fix: error message not supported for complex types

* refactor: parse all metadata, including parameters at once

* refactor: clean docs and move code

* fix: format_type

* fix: parse user inputs for Option arguments (#332)

* fix: automatically add some or none to Option argument

* test: refactor and tests

* refactor: improve code and comments

* fix: renaming and clean code

* chore: option params not mandatory

* fix: parse user inputs for Option arguments in constructor (#335)

* fix: automatically add some or none to Option argument

* fix: tests

* refactor: process_function_args

* test: update tests accordingly last changes

* fix: issue with delimiter

* test: fix unit test

* refactor: renaming and fix comments

* refactor: format types (#339)

Shows the full type representation, making it easier to see the entry format of parameter values.

* fix: logo doesn't show in README

---------

Co-authored-by: Frank Bell <[email protected]>
Co-authored-by: Alejandro Martinez Andres <[email protected]>

* test: fix unit test

* refactor: clean the way to parse and prompt parameters

* feat: add Purchase on-demand coretime use cases

* test: add skip_confirm, move when prompt for the signer and create the integration test

* test: call parachain ui unit test

* refactor: separate structs

* fmt

* test: pop-cli unit testing

* test: pop-common unit tests

* test: parse metadata unit tests

* test: refactor and test processing parameters

* test: comments and unit test in call functions

* fix: clippy warnings

* chore: fmt

* fix: solve conflicts and unit tests (#359)

* test: call parachain ui unit test

* test: pop-cli unit testing

* test: pop-common unit tests

* test: parse metadata unit tests

* test: refactor and test processing parameters

* test: comments and unit test in call functions

* fix: clippy warnings

* chore: fmt

* fix: conflicts and unit tests

* test: remove test and improve test

* feat: guide user for calling a contract

* feat: get metadata contract from the contract path

* refactor: refactor test and validate address input

* fix: apply feedback

* feat: prompt to have another call and skip questions for queries

* refactor: use Cli module instead of cliclack

* test: unit test pop-cli crate

* test: unit contracts crate

* chore: format

* test: refactor and improve test cases

* fix: fix todos and refactor

* test: fix unit test

* feat: parse types of parameters and display it to the user in the placeholder

* refactor: error handling for pop call

* refactor: display call to be executed after guide and reorder

* refactor: when repeat call use same contract values and dont clean screen

* test: add dry-run test

* test: refactor and add more test coverage

* test: more coverage

* fix: unit test

* feat: dev mode to skip certain user prompts

* refactor: test functions, renaming and fix clippy

* refactor: improve devex of pop call contract

* test: adjust tests to refactor

* chore: reset_for_new_call fields

* fix: build contract if has not been built

* refactor: use command state (#338)

Merged set_up_call_config and guide_user_to_call_contract into a single function. Also adds short symbols for arguments.

* fix: automatically add some or none to Option argument

* test: refactor and tests

* refactor: improve code and comments

* fix: renaming and clean code

* chore: option params not mandatory

* fix: parse user inputs for Option arguments in constructor (#335)

* fix: automatically add some or none to Option argument

* fix: tests

* refactor: process_function_args

* test: update tests accordingly last changes

* fix: issue with delimiter

* test: fix unit test

* refactor: renaming and fix comments

* refactor: format types (#339)

Shows the full type representation, making it easier to see the entry format of parameter values.

* feat: pop call parachain prototype

* feat: dispaly arguments of extrinsic

* refactor: structure similar to pop call contract

* feat: parse all values for extrinsic/storage

* refactor: signer in common

* refactor: improve messages

* feat: call parachain ui

* fix: calls working

* refactor: remove unused code

* refactor: remove unused code

* refactor: various fixes

* refactor: various fixes

* feat: add option to include params from command line

* refactor: clean docs and refactor code

* fix: tests

* refactor: parse all the metadata again

* refactor: reorganize and clean metadata functions

* feat: display specific use cases to the user

* refactor: predefined actions

* fix: various fixes

* fix: error message not supported for complex types

* refactor: parse all metadata, including parameters at once

* refactor: clean docs and move code

* fix: format_type

* test: fix unit test

* refactor: clean the way to parse and prompt parameters

* feat: add Purchase on-demand coretime use cases

* test: add skip_confirm, move when prompt for the signer and create the integration test

* test: call parachain ui unit test

* test: pop-cli unit testing

* test: pop-common unit tests

* test: parse metadata unit tests

* test: refactor and test processing parameters

* test: comments and unit test in call functions

* fix: clippy warnings

* chore: fmt

* feat: repeat call only if using guide UI

* fix: clippy

* refactor: various improvements

* chore: parser for pallet and extrinsic input names

* refactor: only move to pop_common the needed functions

* refactor: improve test, docs and errors

* test: fix unit tests

* fix: reset_for_new_call when extrinisc is not supported

* fix: build with parachain features

* test: wait before call parachain in integration test

* docs: minor improvements

* test: migrate find_free_port to pop_common

* test: fix increase waiting time

* test: remove unnecesary test case

* refactor: rename api with client

* refactor: naming and docs

* docs: improve docs and missing comments

* test: remove unnecesary verbose

* test: find_free_port

* docs: improve parameter documentation

* test: add missing test to sign_and_submit_extrinsic

* fix: apply feedback from auxiliar PRs, remove unnecesary clones

* docs: public modules

* refactor: clean unused params

* fix: mark all extrinsics that uses calls as parameter as unsupported

* test: fix expect_select

* docs: improve documentation

* feat: submit extrinsic from call_data (#348)

* feat: submit extrinsic from call_data

* test: unit test for initialize_api_client

* test: unit test for send_extrinsic_from_call_data

* fix: CallData struct

* fix: skip_confirm for send_extrinsic_from_call_data

* chore: clippy

* chore: fmt

* refactor: minor doc and naming changes

* refactor: remove unnecesary clones and return early when submit_extrinsic_from_call_data

* chore: fmt

* refactor: split decode_call_data logic outside sign_and_submit_extrinsic_with_call_data

* feat: parse files when the argument values are very big (#363)

* feat: parse files when the argument values are very big

* test: unit test

* chore: fmt

* feat: file logic using the command line

* fix: sequence arguments

* test: fix unit test

* refactor: remove prompting the user if input is file or value

* refactor: parse_extrinsic_arguments

* fix: CI deny

* refactor: reorder Param  derive macros

* test: fix decode_call_data_works unit test

* refactor: use Default derive macro and define constants for test values (#366)

* feat: parse files when the argument values are very big

* chore: fmt

* feat: file logic using the command line

* fix: sequence arguments

* refactor: parse_extrinsic_arguments

* refactor: use Default in pop_parachain structs

* refactor: use Default in CallParachainCommand struct

* refactor: use constant in tests

* chore: fmt and small refactor

* feat: flag sudo to wrap extrinsic (#349)

* feat: submit extrinsic from call_data

* test: unit test for initialize_api_client

* feat: wrap call into a sudo call

* test: add unit test to the new logic

* fix: skip_confirm for send_extrinsic_from_call_data

* chore: clippy

* docs: renaming and improve docs

* test: use force_transfer for testing

* fix: check if sudo exist before prompt the user

* chore: fmt

* chore: fmt

* test: fix wrong assert

* docs: improve comments and output messages

* refactor: split decode_call_data logic outside sign_and_submit_extrinsic_with_call_data

* fix: test construct_sudo_extrinsic_works and formatting

* refactor: various fixes and improvements (#367)

* refactor: sort pallets/dispatchables

* refactor: remove unnecessary async

* fix: resolve issue after rebase

* fix: more async issues after rebase

* refactor: use single constant

* refactor: terminology (#368)

* refactor: terminology

* refactor: simply pallet/function relationship

* fix: amend call_data conflicts after refactor

* refactor: improvements (#370)

* fix: add missing short arg option

* refactor: note that extrinsic wait includes finalization

* refactor: remove clones

* style: formatting

* refactor: make file prompt more generic

* refactor: add missing license headers

* style: formatting

* docs: comments

* docs: comments

* docs: comments

* refactor: reuse existing metadata

* refactor: minimise clones

* docs: comments

* refactor: naming

* docs: fix parameter doc comments

* refactor: address clippy warnings

* refactor: rename parachain with chain as the primary command and retain parachain as an alias (#373)

* refactor: rename parachain with chain in visible messages

* refactor: rename parachain with chain internal code

* chore: solve fmt after rebase

* refactor: small fix, use alias instead aliases

* refactor: rename CallParachain struct into Call

---------

Co-authored-by: Frank Bell <[email protected]>
Co-authored-by: Alejandro Martinez Andres <[email protected]>
Co-authored-by: Daanvdplas <[email protected]>

* feat(wallet-integration): server and API (#362)

* feat(wallet-integration): implement server and API

* feat(wallet-integration): add a few tests to server. Needs more

* refactor(wallet-integration): just use call_data, remove data types

* feat(wallet-integration): add frontend type for flexible serving

* feat(wallet-integration): StateHandler in WalletIntegrationManager. Add terminate method

* refactor(wallet-integration): move to module with pop-cli crate

* feat(wallet-integration): server-side error handling, update port to 9090

* refactor(wallet-integration): restructure server for easier use in thread

* fix(wallet-integration): remove invalid fn `finish`

* docs(wallet-integration): inline comments

* test(wallet-integration): unit tests for wallet-integration server. Add new frontend type

* feat(wallet-integration): two new routes: error and terminate

* refactor(wallet-integration): consistent comments, remove unnecessary code in tests

* feat: add TransactionData::new

* refactor(wallet-integration: shutdown channel error handling, terminate helper, take_error and TranscationData::new tests

* chore: clippy warning

* feat(up-contract): get call data for upload-only and pass to wallet integration -- PoC

* chore: use git branch for cargo contract

* feat(up-contract): handle subxt events better, various improvements

* refactor: reuse pop up logic

* chore: rebase fixes

* refactor: clean after rebase

* fix: cargo.lock after rebase

* refactor: move terminate node into common::contracts

* fix: sp-core not only for contracts

* feat(up-contract): serve HTML from string, fix deployment message on error, cors, and other misc. improvements

* fix: rebase

* feat: secure signing logic for pop call chain

* test: unit tests in pop-cli

* feat: secure signing for call from call_data

* refactor: docs and remove unneded functions

* refactor: replace hex library

* fix: rebase issues

* fix: merge issues

* feat(wallet-integration): server and API (#362)

* feat(wallet-integration): implement server and API

* feat(wallet-integration): add a few tests to server. Needs more

* refactor(wallet-integration): just use call_data, remove data types

* feat(wallet-integration): add frontend type for flexible serving

* feat(wallet-integration): StateHandler in WalletIntegrationManager. Add terminate method

* refactor(wallet-integration): move to module with pop-cli crate

* feat(wallet-integration): server-side error handling, update port to 9090

* refactor(wallet-integration): restructure server for easier use in thread

* fix(wallet-integration): remove invalid fn `finish`

* docs(wallet-integration): inline comments

* test(wallet-integration): unit tests for wallet-integration server. Add new frontend type

* feat(wallet-integration): two new routes: error and terminate

* refactor(wallet-integration): consistent comments, remove unnecessary code in tests

* feat: add TransactionData::new

* refactor(wallet-integration: shutdown channel error handling, terminate helper, take_error and TranscationData::new tests

* chore: clippy warning

* feat(up-contract): get call data for upload-only and pass to wallet integration -- PoC

* refactor(pop-up): create functions for wallet integration, plus general cleanup

* chore: use git branch for cargo contract

* feat(up-contract): handle subxt events better, various improvements

* feat(wallet-integration): implement server and API

* feat(wallet-integration): add a few tests to server. Needs more

* refactor(wallet-integration): just use call_data, remove data types

* feat(wallet-integration): add frontend type for flexible serving

* feat(wallet-integration): StateHandler in WalletIntegrationManager. Add terminate method

* refactor(wallet-integration): move to module with pop-cli crate

* feat(wallet-integration): server-side error handling, update port to 9090

* refactor(wallet-integration): restructure server for easier use in thread

* fix(wallet-integration): remove invalid fn `finish`

* docs(wallet-integration): inline comments

* test(wallet-integration): unit tests for wallet-integration server. Add new frontend type

* feat(wallet-integration): two new routes: error and terminate

* refactor(wallet-integration): consistent comments, remove unnecessary code in tests

* feat: guide user to call a contract (#306)

* feat: guide user for calling a contract

* feat: get metadata contract from the contract path

* refactor: refactor test and validate address input

* fix: apply feedback

* feat: prompt to have another call and skip questions for queries

* refactor: use Cli module instead of cliclack

* test: unit test pop-cli crate

* test: unit contracts crate

* chore: format

* test: refactor and improve test cases

* fix: fix todos and refactor

* test: fix unit test

* feat: parse types of parameters and display it to the user in the placeholder

* refactor: error handling for pop call

* refactor: display call to be executed after guide and reorder

* refactor: when repeat call use same contract values and dont clean screen

* test: add dry-run test

* test: refactor and add more test coverage

* test: more coverage

* fix: unit test

* feat: dev mode to skip certain user prompts

* refactor: test functions, renaming and fix clippy

* refactor: improve devex of pop call contract

* test: adjust tests to refactor

* chore: reset_for_new_call fields

* fix: build contract if has not been built

* refactor: use command state (#338)

Merged set_up_call_config and guide_user_to_call_contract into a single function. Also adds short symbols for arguments.

* fix: parse user inputs for Option arguments (#332)

* fix: automatically add some or none to Option argument

* test: refactor and tests

* refactor: improve code and comments

* fix: renaming and clean code

* chore: option params not mandatory

* fix: parse user inputs for Option arguments in constructor (#335)

* fix: automatically add some or none to Option argument

* fix: tests

* refactor: process_function_args

* test: update tests accordingly last changes

* fix: issue with delimiter

* test: fix unit test

* refactor: renaming and fix comments

* refactor: format types (#339)

Shows the full type representation, making it easier to see the entry format of parameter values.

* fix: logo doesn't show in README

---------

Co-authored-by: Frank Bell <[email protected]>
Co-authored-by: Alejandro Martinez Andres <[email protected]>

* test: fix unit test

* feat: allow users to specify custom contract metadata files (#347)

* chore: allow the user specify the metadata file to call a contract

* test: unit test to parse metadata from a file

* docs: fix docs

* refactor: ensure_contract_built after user input path

* fix: call contract when metadata file

* fix: remove default_input in contract address

* docs: rename metadata with artifact

* fix: panic at has_contract_been_built

* fix: clippy

* refactor: keep ensure_contract_built as a CallContractCommand function

* fix: ensure_contract_built

* docs: improve comments

* fix: feedback and include wasm file for testing

* fix: clippy

* chore: after build contract prompt the user if the contract is already deployed

* refactor: ensure_contract_built

* refactor: has_contract_been_built function

* docs: fix comments and messages

* refactor: get_messages and get_constructors

* test: fix unit tests call ui

---------

Co-authored-by: Frank Bell <[email protected]>
Co-authored-by: Alejandro Martinez Andres <[email protected]>

* fix: support new substrate-contracts-node structure and stabilize integration tests (#360)

* fix: parse new structure substrate-contracts-node

* fix: paseo+coretime integration test

* fix: sourcing latest version substrate-contracts-node

* refactor: set_executable_permission function

* fix: clippy

* chore: CI configuration

* test: specify port in run_contracts_node

* fix: use random ports instead of hardcoded ones

* feat: guide user to call a parachain (#316)

* feat: guide user for calling a contract

* feat: get metadata contract from the contract path

* refactor: refactor test and validate address input

* fix: apply feedback

* feat: prompt to have another call and skip questions for queries

* refactor: use Cli module instead of cliclack

* test: unit test pop-cli crate

* test: unit contracts crate

* chore: format

* test: refactor and improve test cases

* fix: fix todos and refactor

* test: fix unit test

* feat: parse types of parameters and display it to the user in the placeholder

* refactor: error handling for pop call

* refactor: display call to be executed after guide and reorder

* refactor: when repeat call use same contract values and dont clean screen

* test: add dry-run test

* test: refactor and add more test coverage

* test: more coverage

* fix: unit test

* feat: dev mode to skip certain user prompts

* refactor: test functions, renaming and fix clippy

* refactor: improve devex of pop call contract

* test: adjust tests to refactor

* chore: reset_for_new_call fields

* fix: build contract if has not been built

* refactor: use command state (#338)

Merged set_up_call_config and guide_user_to_call_contract into a single function. Also adds short symbols for arguments.

* fix: automatically add some or none to Option argument

* test: refactor and tests

* refactor: improve code and comments

* fix: renaming and clean code

* chore: option params not mandatory

* fix: parse user inputs for Option arguments in constructor (#335)

* fix: automatically add some or none to Option argument

* fix: tests

* refactor: process_function_args

* test: update tests accordingly last changes

* fix: issue with delimiter

* test: fix unit test

* refactor: renaming and fix comments

* refactor: format types (#339)

Shows the full type representation, making it easier to see the entry format of parameter values.

* fix: logo doesn't show in README

* feat: pop call parachain prototype

* feat: dispaly arguments of extrinsic

* refactor: structure similar to pop call contract

* feat: parse all values for extrinsic/storage

* refactor: signer in common

* refactor: improve messages

* feat: call parachain ui

* fix: calls working

* refactor: remove unused code

* refactor: remove unused code

* refactor: various fixes

* refactor: various fixes

* feat: add option to include params from command line

* refactor: clean docs and refactor code

* fix: tests

* refactor: parse all the metadata again

* refactor: reorganize and clean metadata functions

* feat: display specific use cases to the user

* refactor: predefined actions

* fix: various fixes

* fix: error message not supported for complex types

* refactor: parse all metadata, including parameters at once

* refactor: clean docs and move code

* fix: format_type

* fix: parse user inputs for Option arguments (#332)

* fix: automatically add some or none to Option argument

* test: refactor and tests

* refactor: improve code and comments

* fix: renaming and clean code

* chore: option params not mandatory

* fix: parse user inputs for Option arguments in constructor (#335)

* fix: automatically add some or none to Option argument

* fix: tests

* refactor: process_function_args

* test: update tests accordingly last changes

* fix: issue with delimiter

* test: fix unit test

* refactor: renaming and fix comments

* refactor: format types (#339)

Shows the full type representation, making it easier to see the entry format of parameter values.

* fix: logo doesn't show in README

---------

Co-authored-by: Frank Bell <[email protected]>
Co-authored-by: Alejandro Martinez Andres <[email protected]>

* test: fix unit test

* refactor: clean the way to parse and prompt parameters

* feat: add Purchase on-demand coretime use cases

* test: add skip_confirm, move when prompt for the signer and create the integration test

* test: call parachain ui unit test

* refactor: separate structs

* fmt

* test: pop-cli unit testing

* test: pop-common unit tests

* test: parse metadata unit tests

* test: refactor and test processing parameters

* test: comments and unit test in call functions

* fix: clippy warnings

* chore: fmt

* fix: solve conflicts and unit tests (#359)

* test: call parachain ui unit test

* test: pop-cli unit testing

* test: pop-common unit tests

* test: parse metadata unit tests

* test: refactor and test processing parameters

* test: comments and unit test in call functions

* fix: clippy warnings

* chore: fmt

* fix: conflicts and unit tests

* test: remove test and improve test

* feat: guide user for calling a contract

* feat: get metadata contract from the contract path

* refactor: refactor test and validate address input

* fix: apply feedback

* feat: prompt to have another call and skip questions for queries

* refactor: use Cli module instead of cliclack

* test: unit test pop-cli crate

* test: unit contracts crate

* chore: format

* test: refactor and improve test cases

* fix: fix todos and refactor

* test: fix unit test

* feat: parse types of parameters and display it to the user in the placeholder

* refactor: error handling for pop call

* refactor: display call to be executed after guide and reorder

* refactor: when repeat call use same contract values and dont clean screen

* test: add dry-run test

* test: refactor and add more test coverage

* test: more coverage

* fix: unit test

* feat: dev mode to skip certain user prompts

* refactor: test functions, renaming and fix clippy

* refactor: improve devex of pop call contract

* test: adjust tests to refactor

* chore: reset_for_new_call fields

* fix: build contract if has not been built

* refactor: use command state (#338)

Merged set_up_call_config and guide_user_to_call_contract into a single function. Also adds short symbols for arguments.

* fix: automatically add some or none to Option argument

* test: refactor and tests

* refactor: improve code and comments

* fix: renaming and clean code

* chore: option params not mandatory

* fix: parse user inputs for Option arguments in constructor (#335)

* fix: automatically add some or none to Option argument

* fix: tests

* refactor: process_function_args

* test: update tests accordingly last changes

* fix: issue with delimiter

* test: fix unit test

* refactor: renaming and fix comments

* refactor: format types (#339)

Shows the full type representation, making it easier to see the entry format of parameter values.

* feat: pop call parachain prototype

* feat: dispaly arguments of extrinsic

* refactor: structure similar to pop call contract

* feat: parse all values for extrinsic/storage

* refactor: signer in common

* refactor: improve messages

* feat: call parachain ui

* fix: calls working

* refactor: remove unused code

* refactor: remove unused code

* refactor: various fixes

* refactor: various fixes

* feat: add option to include params from command line

* refactor: clean docs and refactor code

* fix: tests

* refactor: parse all the metadata again

* refactor: reorganize and clean metadata functions

* feat: display specific use cases to the user

* refactor: predefined actions

* fix: various fixes

* fix: error message not supported for complex types

* refactor: parse all metadata, including parameters at once

* refactor: clean docs and move code

* fix: format_type

* test: fix unit test

* refactor: clean the way to parse and prompt parameters

* feat: add Purchase on-demand coretime use cases

* test: add skip_confirm, move when prompt for the signer and create the integration test

* test: call parachain ui unit test

* test: pop-cli unit testing

* test: pop-common unit tests

* test: parse metadata unit tests

* test: refactor and test processing parameters

* test: comments and unit test in call functions

* fix: clippy warnings

* chore: fmt

* feat: repeat call only if using guide UI

* fix: clippy

* refactor: various improvements

* chore: parser for pallet and extrinsic input names

* refactor: only move to pop_common the needed functions

* refactor: improve test, docs and errors

* test: fix unit tests

* fix: reset_for_new_call when extrinisc is not supported

* fix: build with parachain features

* test: wait before call parachain in integration test

* docs: minor improvements

* test: migrate find_free_port to pop_common

* test: fix increase waiting time

* test: remove unnecesary test case

* refactor: rename api with client

* refactor: naming and docs

* docs: improve docs and missing comments

* test: remove unnecesary verbose

* test: find_free_port

* docs: improve parameter documentation

* test: add missing test to sign_and_submit_extrinsic

* fix: apply feedback from auxiliar PRs, remove unnecesary clones

* docs: public modules

* refactor: clean unused params

* fix: mark all extrinsics that uses calls as parameter as unsupported

* test: fix expect_select

* docs: improve documentation

* feat: submit extrinsic from call_data (#348)

* feat: submit extrinsic from call_data

* test: unit test for initialize_api_client

* test: unit test for send_extrinsic_from_call_data

* fix: CallData struct

* fix: skip_confirm for send_extrinsic_from_call_data

* chore: clippy

* chore: fmt

* refactor: minor doc and naming changes

* refactor: remove unnecesary clones and return early when submit_extrinsic_from_call_data

* chore: fmt

* refactor: split decode_call_data logic outside sign_and_submit_extrinsic_with_call_data

* feat: parse files when the argument values are very big (#363)

* feat: parse files when the argument values are very big

* test: unit test

* chore: fmt

* feat: file logic using the command line

* fix: sequence arguments

* test: fix unit test

* refactor: remove prompting the user if input is file or value

* refactor: parse_extrinsic_arguments

* fix: CI deny

* refactor: reorder Param  derive macros

* test: fix decode_call_data_works unit test

* refactor: use Default derive macro and define constants for test values (#366)

* feat: parse files when the argument values are very big

* chore: fmt

* feat: file logic using the command line

* fix: sequence arguments

* refactor: parse_extrinsic_arguments

* refactor: use Default in pop_parachain structs

* refactor: use Default in CallParachainCommand struct

* refactor: use constant in tests

* chore: fmt and small refactor

* feat: flag sudo to wrap extrinsic (#349)

* feat: submit extrinsic from call_data

* test: unit test for initialize_api_client

* feat: wrap call into a sudo call

* test: add unit test to the new logic

* fix: skip_confirm for send_extrinsic_from_call_data

* chore: clippy

* docs: renaming and improve docs

* test: use force_transfer for testing

* fix: check if sudo exist before prompt the user

* chore: fmt

* chore: fmt

* test: fix wrong assert

* docs: improve comments and output messages

* refactor: split decode_call_data logic outside sign_and_submit_extrinsic_with_call_data

* fix: test construct_sudo_extrinsic_works and formatting

* refactor: various fixes and improvements (#367)

* refactor: sort pallets/dispatchables

* refactor: remove unnecessary async

* fix: resolve issue after rebase

* fix: more async issues after rebase

* refactor: use single constant

* refactor: terminology (#368)

* refactor: terminology

* refactor: simply pallet/function relationship

* fix: amend call_data conflicts after refactor

* refactor: improvements (#370)

* fix: add missing short arg option

* refactor: note that extrinsic wait includes finalization

* refactor: remove clones

* style: formatting

* refactor: make file prompt more generic

* refactor: add missing license headers

* style: formatting

* docs: comments

* docs: comments

* docs: comments

* refactor: reuse existing metadata

* refactor: minimise clones

* docs: comments

* refactor: naming

* docs: fix parameter doc comments

* refactor: address clippy warnings

* refactor: rename parachain with chain as the primary command and retain parachain as an alias (#373)

* refactor: rename parachain with chain in visible messages

* refactor: rename parachain with chain internal code

* chore: solve fmt after rebase

* refactor: small fix, use alias instead aliases

* refactor: rename CallParachain struct into Call

---------

Co-authored-by: Frank Bell <[email protected]>
Co-authored-by: Alejandro Martinez Andres <[email protected]>
Co-authored-by: Daanvdplas <[email protected]>

* feat(wallet-integration): server and API (#362)

* feat(wallet-integration): implement server and API

* feat(wallet-integration): add a few tests to server. Needs more

* refactor(wallet-integration): just use call_data, remove data types

* feat(wallet-integration): add frontend type for flexible serving

* feat(wallet-integration): StateHandler in WalletIntegrationManager. Add terminate method

* refacto…
peterwht added a commit that referenced this pull request Dec 16, 2024
@AlexD10S @peterwht
@evilrobot-01 @al3mart @Daanvdplas
feat: wallet integration pop call chain (#379)
074e2f9 
* feat(wallet-integration): server and API (#362)

* feat(wallet-integration): implement server and API

* feat(wallet-integration): add a few tests to server. Needs more

* refactor(wallet-integration): just use call_data, remove data types

* feat(wallet-integration): add frontend type for flexible serving

* feat(wallet-integration): StateHandler in WalletIntegrationManager. Add terminate method

* refactor(wallet-integration): move to module with pop-cli crate

* feat(wallet-integration): server-side error handling, update port to 9090

* refactor(wallet-integration): restructure server for easier use in thread

* fix(wallet-integration): remove invalid fn `finish`

* docs(wallet-integration): inline comments

* test(wallet-integration): unit tests for wallet-integration server. Add new frontend type

* feat(wallet-integration): two new routes: error and terminate

* refactor(wallet-integration): consistent comments, remove unnecessary code in tests

* feat: add TransactionData::new

* refactor(wallet-integration: shutdown channel error handling, terminate helper, take_error and TranscationData::new tests

* chore: clippy warning

* feat(up-contract): get call data for upload-only and pass to wallet integration -- PoC

* feat(up-contract): get call data for instantiate and pass to wallet integration -- PoC

* feat(up-contract): run server and pass call_data for signing -- PoC

* feat(up-contract): submit signed payload to node

* fix(up-contract): update to FrontendFromDir type

* refactor(pop-up): create functions for wallet integration, plus general cleanup

* chore: use git branch for cargo contract

* feat(pop-up-contract): better error handling and prompt displays

* chore(up-contract): outdated field name and clippy allow

* feat(up-contract): handle subxt events better, various improvements

* feat(up-contract): custom errors in contracts crate

* fix: minor fixes after rebase

* fix(up-contract): test compilation after rebase

* feat(up-contract): suri and use-wallet can't be used together

* refactor: wait for finalization

* feat(up-contract): serve HTML from string, fix deployment message on error, cors, and other misc. improvements (#380)

* feat(wallet-integration): server and API (#362)

* feat(wallet-integration): implement server and API

* feat(wallet-integration): add a few tests to server. Needs more

* refactor(wallet-integration): just use call_data, remove data types

* feat(wallet-integration): add frontend type for flexible serving

* feat(wallet-integration): StateHandler in WalletIntegrationManager. Add terminate method

* refactor(wallet-integration): move to module with pop-cli crate

* feat(wallet-integration): server-side error handling, update port to 9090

* refactor(wallet-integration): restructure server for easier use in thread

* fix(wallet-integration): remove invalid fn `finish`

* docs(wallet-integration): inline comments

* test(wallet-integration): unit tests for wallet-integration server. Add new frontend type

* feat(wallet-integration): two new routes: error and terminate

* refactor(wallet-integration): consistent comments, remove unnecessary code in tests

* feat: add TransactionData::new

* refactor(wallet-integration: shutdown channel error handling, terminate helper, take_error and TranscationData::new tests

* chore: clippy warning

* feat(up-contract): get call data for upload-only and pass to wallet integration -- PoC

* refactor(pop-up): create functions for wallet integration, plus general cleanup

* chore: use git branch for cargo contract

* feat(up-contract): handle subxt events better, various improvements

* feat(wallet-integration): implement server and API

* feat(wallet-integration): add a few tests to server. Needs more

* refactor(wallet-integration): just use call_data, remove data types

* feat(wallet-integration): add frontend type for flexible serving

* feat(wallet-integration): StateHandler in WalletIntegrationManager. Add terminate method

* refactor(wallet-integration): move to module with pop-cli crate

* feat(wallet-integration): server-side error handling, update port to 9090

* refactor(wallet-integration): restructure server for easier use in thread

* fix(wallet-integration): remove invalid fn `finish`

* docs(wallet-integration): inline comments

* test(wallet-integration): unit tests for wallet-integration server. Add new frontend type

* feat(wallet-integration): two new routes: error and terminate

* refactor(wallet-integration): consistent comments, remove unnecessary code in tests

* feat: guide user to call a contract (#306)

* feat: guide user for calling a contract

* feat: get metadata contract from the contract path

* refactor: refactor test and validate address input

* fix: apply feedback

* feat: prompt to have another call and skip questions for queries

* refactor: use Cli module instead of cliclack

* test: unit test pop-cli crate

* test: unit contracts crate

* chore: format

* test: refactor and improve test cases

* fix: fix todos and refactor

* test: fix unit test

* feat: parse types of parameters and display it to the user in the placeholder

* refactor: error handling for pop call

* refactor: display call to be executed after guide and reorder

* refactor: when repeat call use same contract values and dont clean screen

* test: add dry-run test

* test: refactor and add more test coverage

* test: more coverage

* fix: unit test

* feat: dev mode to skip certain user prompts

* refactor: test functions, renaming and fix clippy

* refactor: improve devex of pop call contract

* test: adjust tests to refactor

* chore: reset_for_new_call fields

* fix: build contract if has not been built

* refactor: use command state (#338)

Merged set_up_call_config and guide_user_to_call_contract into a single function. Also adds short symbols for arguments.

* fix: parse user inputs for Option arguments (#332)

* fix: automatically add some or none to Option argument

* test: refactor and tests

* refactor: improve code and comments

* fix: renaming and clean code

* chore: option params not mandatory

* fix: parse user inputs for Option arguments in constructor (#335)

* fix: automatically add some or none to Option argument

* fix: tests

* refactor: process_function_args

* test: update tests accordingly last changes

* fix: issue with delimiter

* test: fix unit test

* refactor: renaming and fix comments

* refactor: format types (#339)

Shows the full type representation, making it easier to see the entry format of parameter values.

* fix: logo doesn't show in README

---------

Co-authored-by: Frank Bell <[email protected]>
Co-authored-by: Alejandro Martinez Andres <[email protected]>

* test: fix unit test

* feat: allow users to specify custom contract metadata files (#347)

* chore: allow the user specify the metadata file to call a contract

* test: unit test to parse metadata from a file

* docs: fix docs

* refactor: ensure_contract_built after user input path

* fix: call contract when metadata file

* fix: remove default_input in contract address

* docs: rename metadata with artifact

* fix: panic at has_contract_been_built

* fix: clippy

* refactor: keep ensure_contract_built as a CallContractCommand function

* fix: ensure_contract_built

* docs: improve comments

* fix: feedback and include wasm file for testing

* fix: clippy

* chore: after build contract prompt the user if the contract is already deployed

* refactor: ensure_contract_built

* refactor: has_contract_been_built function

* docs: fix comments and messages

* refactor: get_messages and get_constructors

* test: fix unit tests call ui

---------

Co-authored-by: Frank Bell <[email protected]>
Co-authored-by: Alejandro Martinez Andres <[email protected]>

* fix: support new substrate-contracts-node structure and stabilize integration tests (#360)

* fix: parse new structure substrate-contracts-node

* fix: paseo+coretime integration test

* fix: sourcing latest version substrate-contracts-node

* refactor: set_executable_permission function

* fix: clippy

* chore: CI configuration

* test: specify port in run_contracts_node

* fix: use random ports instead of hardcoded ones

* feat: guide user to call a parachain (#316)

* feat: guide user for calling a contract

* feat: get metadata contract from the contract path

* refactor: refactor test and validate address input

* fix: apply feedback

* feat: prompt to have another call and skip questions for queries

* refactor: use Cli module instead of cliclack

* test: unit test pop-cli crate

* test: unit contracts crate

* chore: format

* test: refactor and improve test cases

* fix: fix todos and refactor

* test: fix unit test

* feat: parse types of parameters and display it to the user in the placeholder

* refactor: error handling for pop call

* refactor: display call to be executed after guide and reorder

* refactor: when repeat call use same contract values and dont clean screen

* test: add dry-run test

* test: refactor and add more test coverage

* test: more coverage

* fix: unit test

* feat: dev mode to skip certain user prompts

* refactor: test functions, renaming and fix clippy

* refactor: improve devex of pop call contract

* test: adjust tests to refactor

* chore: reset_for_new_call fields

* fix: build contract if has not been built

* refactor: use command state (#338)

Merged set_up_call_config and guide_user_to_call_contract into a single function. Also adds short symbols for arguments.

* fix: automatically add some or none to Option argument

* test: refactor and tests

* refactor: improve code and comments

* fix: renaming and clean code

* chore: option params not mandatory

* fix: parse user inputs for Option arguments in constructor (#335)

* fix: automatically add some or none to Option argument

* fix: tests

* refactor: process_function_args

* test: update tests accordingly last changes

* fix: issue with delimiter

* test: fix unit test

* refactor: renaming and fix comments

* refactor: format types (#339)

Shows the full type representation, making it easier to see the entry format of parameter values.

* fix: logo doesn't show in README

* feat: pop call parachain prototype

* feat: dispaly arguments of extrinsic

* refactor: structure similar to pop call contract

* feat: parse all values for extrinsic/storage

* refactor: signer in common

* refactor: improve messages

* feat: call parachain ui

* fix: calls working

* refactor: remove unused code

* refactor: remove unused code

* refactor: various fixes

* refactor: various fixes

* feat: add option to include params from command line

* refactor: clean docs and refactor code

* fix: tests

* refactor: parse all the metadata again

* refactor: reorganize and clean metadata functions

* feat: display specific use cases to the user

* refactor: predefined actions

* fix: various fixes

* fix: error message not supported for complex types

* refactor: parse all metadata, including parameters at once

* refactor: clean docs and move code

* fix: format_type

* fix: parse user inputs for Option arguments (#332)

* fix: automatically add some or none to Option argument

* test: refactor and tests

* refactor: improve code and comments

* fix: renaming and clean code

* chore: option params not mandatory

* fix: parse user inputs for Option arguments in constructor (#335)

* fix: automatically add some or none to Option argument

* fix: tests

* refactor: process_function_args

* test: update tests accordingly last changes

* fix: issue with delimiter

* test: fix unit test

* refactor: renaming and fix comments

* refactor: format types (#339)

Shows the full type representation, making it easier to see the entry format of parameter values.

* fix: logo doesn't show in README

---------

Co-authored-by: Frank Bell <[email protected]>
Co-authored-by: Alejandro Martinez Andres <[email protected]>

* test: fix unit test

* refactor: clean the way to parse and prompt parameters

* feat: add Purchase on-demand coretime use cases

* test: add skip_confirm, move when prompt for the signer and create the integration test

* test: call parachain ui unit test

* refactor: separate structs

* fmt

* test: pop-cli unit testing

* test: pop-common unit tests

* test: parse metadata unit tests

* test: refactor and test processing parameters

* test: comments and unit test in call functions

* fix: clippy warnings

* chore: fmt

* fix: solve conflicts and unit tests (#359)

* test: call parachain ui unit test

* test: pop-cli unit testing

* test: pop-common unit tests

* test: parse metadata unit tests

* test: refactor and test processing parameters

* test: comments and unit test in call functions

* fix: clippy warnings

* chore: fmt

* fix: conflicts and unit tests

* test: remove test and improve test

* feat: guide user for calling a contract

* feat: get metadata contract from the contract path

* refactor: refactor test and validate address input

* fix: apply feedback

* feat: prompt to have another call and skip questions for queries

* refactor: use Cli module instead of cliclack

* test: unit test pop-cli crate

* test: unit contracts crate

* chore: format

* test: refactor and improve test cases

* fix: fix todos and refactor

* test: fix unit test

* feat: parse types of parameters and display it to the user in the placeholder

* refactor: error handling for pop call

* refactor: display call to be executed after guide and reorder

* refactor: when repeat call use same contract values and dont clean screen

* test: add dry-run test

* test: refactor and add more test coverage

* test: more coverage

* fix: unit test

* feat: dev mode to skip certain user prompts

* refactor: test functions, renaming and fix clippy

* refactor: improve devex of pop call contract

* test: adjust tests to refactor

* chore: reset_for_new_call fields

* fix: build contract if has not been built

* refactor: use command state (#338)

Merged set_up_call_config and guide_user_to_call_contract into a single function. Also adds short symbols for arguments.

* fix: automatically add some or none to Option argument

* test: refactor and tests

* refactor: improve code and comments

* fix: renaming and clean code

* chore: option params not mandatory

* fix: parse user inputs for Option arguments in constructor (#335)

* fix: automatically add some or none to Option argument

* fix: tests

* refactor: process_function_args

* test: update tests accordingly last changes

* fix: issue with delimiter

* test: fix unit test

* refactor: renaming and fix comments

* refactor: format types (#339)

Shows the full type representation, making it easier to see the entry format of parameter values.

* feat: pop call parachain prototype

* feat: dispaly arguments of extrinsic

* refactor: structure similar to pop call contract

* feat: parse all values for extrinsic/storage

* refactor: signer in common

* refactor: improve messages

* feat: call parachain ui

* fix: calls working

* refactor: remove unused code

* refactor: remove unused code

* refactor: various fixes

* refactor: various fixes

* feat: add option to include params from command line

* refactor: clean docs and refactor code

* fix: tests

* refactor: parse all the metadata again

* refactor: reorganize and clean metadata functions

* feat: display specific use cases to the user

* refactor: predefined actions

* fix: various fixes

* fix: error message not supported for complex types

* refactor: parse all metadata, including parameters at once

* refactor: clean docs and move code

* fix: format_type

* test: fix unit test

* refactor: clean the way to parse and prompt parameters

* feat: add Purchase on-demand coretime use cases

* test: add skip_confirm, move when prompt for the signer and create the integration test

* test: call parachain ui unit test

* test: pop-cli unit testing

* test: pop-common unit tests

* test: parse metadata unit tests

* test: refactor and test processing parameters

* test: comments and unit test in call functions

* fix: clippy warnings

* chore: fmt

* feat: repeat call only if using guide UI

* fix: clippy

* refactor: various improvements

* chore: parser for pallet and extrinsic input names

* refactor: only move to pop_common the needed functions

* refactor: improve test, docs and errors

* test: fix unit tests

* fix: reset_for_new_call when extrinisc is not supported

* fix: build with parachain features

* test: wait before call parachain in integration test

* docs: minor improvements

* test: migrate find_free_port to pop_common

* test: fix increase waiting time

* test: remove unnecesary test case

* refactor: rename api with client

* refactor: naming and docs

* docs: improve docs and missing comments

* test: remove unnecesary verbose

* test: find_free_port

* docs: improve parameter documentation

* test: add missing test to sign_and_submit_extrinsic

* fix: apply feedback from auxiliar PRs, remove unnecesary clones

* docs: public modules

* refactor: clean unused params

* fix: mark all extrinsics that uses calls as parameter as unsupported

* test: fix expect_select

* docs: improve documentation

* feat: submit extrinsic from call_data (#348)

* feat: submit extrinsic from call_data

* test: unit test for initialize_api_client

* test: unit test for send_extrinsic_from_call_data

* fix: CallData struct

* fix: skip_confirm for send_extrinsic_from_call_data

* chore: clippy

* chore: fmt

* refactor: minor doc and naming changes

* refactor: remove unnecesary clones and return early when submit_extrinsic_from_call_data

* chore: fmt

* refactor: split decode_call_data logic outside sign_and_submit_extrinsic_with_call_data

* feat: parse files when the argument values are very big (#363)

* feat: parse files when the argument values are very big

* test: unit test

* chore: fmt

* feat: file logic using the command line

* fix: sequence arguments

* test: fix unit test

* refactor: remove prompting the user if input is file or value

* refactor: parse_extrinsic_arguments

* fix: CI deny

* refactor: reorder Param  derive macros

* test: fix decode_call_data_works unit test

* refactor: use Default derive macro and define constants for test values (#366)

* feat: parse files when the argument values are very big

* chore: fmt

* feat: file logic using the command line

* fix: sequence arguments

* refactor: parse_extrinsic_arguments

* refactor: use Default in pop_parachain structs

* refactor: use Default in CallParachainCommand struct

* refactor: use constant in tests

* chore: fmt and small refactor

* feat: flag sudo to wrap extrinsic (#349)

* feat: submit extrinsic from call_data

* test: unit test for initialize_api_client

* feat: wrap call into a sudo call

* test: add unit test to the new logic

* fix: skip_confirm for send_extrinsic_from_call_data

* chore: clippy

* docs: renaming and improve docs

* test: use force_transfer for testing

* fix: check if sudo exist before prompt the user

* chore: fmt

* chore: fmt

* test: fix wrong assert

* docs: improve comments and output messages

* refactor: split decode_call_data logic outside sign_and_submit_extrinsic_with_call_data

* fix: test construct_sudo_extrinsic_works and formatting

* refactor: various fixes and improvements (#367)

* refactor: sort pallets/dispatchables

* refactor: remove unnecessary async

* fix: resolve issue after rebase

* fix: more async issues after rebase

* refactor: use single constant

* refactor: terminology (#368)

* refactor: terminology

* refactor: simply pallet/function relationship

* fix: amend call_data conflicts after refactor

* refactor: improvements (#370)

* fix: add missing short arg option

* refactor: note that extrinsic wait includes finalization

* refactor: remove clones

* style: formatting

* refactor: make file prompt more generic

* refactor: add missing license headers

* style: formatting

* docs: comments

* docs: comments

* docs: comments

* refactor: reuse existing metadata

* refactor: minimise clones

* docs: comments

* refactor: naming

* docs: fix parameter doc comments

* refactor: address clippy warnings

* refactor: rename parachain with chain as the primary command and retain parachain as an alias (#373)

* refactor: rename parachain with chain in visible messages

* refactor: rename parachain with chain internal code

* chore: solve fmt after rebase

* refactor: small fix, use alias instead aliases

* refactor: rename CallParachain struct into Call

---------

Co-authored-by: Frank Bell <[email protected]>
Co-authored-by: Alejandro Martinez Andres <[email protected]>
Co-authored-by: Daanvdplas <[email protected]>

* feat(wallet-integration): server and API (#362)

* feat(wallet-integration): implement server and API

* feat(wallet-integration): add a few tests to server. Needs more

* refactor(wallet-integration): just use call_data, remove data types

* feat(wallet-integration): add frontend type for flexible serving

* feat(wallet-integration): StateHandler in WalletIntegrationManager. Add terminate method

* refactor(wallet-integration): move to module with pop-cli crate

* feat(wallet-integration): server-side error handling, update port to 9090

* refactor(wallet-integration): restructure server for easier use in thread

* fix(wallet-integration): remove invalid fn `finish`

* docs(wallet-integration): inline comments

* test(wallet-integration): unit tests for wallet-integration server. Add new frontend type

* feat(wallet-integration): two new routes: error and terminate

* refactor(wallet-integration): consistent comments, remove unnecessary code in tests

* feat: add TransactionData::new

* refactor(wallet-integration: shutdown channel error handling, terminate helper, take_error and TranscationData::new tests

* chore: clippy warning

* feat(up-contract): get call data for upload-only and pass to wallet integration -- PoC

* chore: use git branch for cargo contract

* feat(up-contract): handle subxt events better, various improvements

* refactor: reuse pop up logic

* chore: rebase fixes

* refactor: clean after rebase

* fix: cargo.lock after rebase

* refactor: move terminate node into common::contracts

* fix: sp-core not only for contracts

* feat(up-contract): serve HTML from string, fix deployment message on error, cors, and other misc. improvements

* fix: rebase

* feat: secure signing logic for pop call chain

* test: unit tests in pop-cli

* feat: secure signing for call from call_data

* refactor: docs and remove unneded functions

* refactor: replace hex library

* fix: rebase issues

* fix: rebase

* refactor: small changes

* refactor: renaming

* feat: wallet integration call contract (#378)

* feat(wallet-integration): server and API (#362)

* feat(wallet-integration): implement server and API

* feat(wallet-integration): add a few tests to server. Needs more

* refactor(wallet-integration): just use call_data, remove data types

* feat(wallet-integration): add frontend type for flexible serving

* feat(wallet-integration): StateHandler in WalletIntegrationManager. Add terminate method

* refactor(wallet-integration): move to module with pop-cli crate

* feat(wallet-integration): server-side error handling, update port to 9090

* refactor(wallet-integration): restructure server for easier use in thread

* fix(wallet-integration): remove invalid fn `finish`

* docs(wallet-integration): inline comments

* test(wallet-integration): unit tests for wallet-integration server. Add new frontend type

* feat(wallet-integration): two new routes: error and terminate

* refactor(wallet-integration): consistent comments, remove unnecessary code in tests

* feat: add TransactionData::new

* refactor(wallet-integration: shutdown channel error handling, terminate helper, take_error and TranscationData::new tests

* chore: clippy warning

* feat(up-contract): get call data for upload-only and pass to wallet integration -- PoC

* feat(up-contract): get call data for instantiate and pass to wallet integration -- PoC

* feat(up-contract): run server and pass call_data for signing -- PoC

* feat(up-contract): submit signed payload to node

* fix(up-contract): update to FrontendFromDir type

* refactor(pop-up): create functions for wallet integration, plus general cleanup

* chore: use git branch for cargo contract

* feat(pop-up-contract): better error handling and prompt displays

* chore(up-contract): outdated field name and clippy allow

* feat(up-contract): handle subxt events better, various improvements

* feat(up-contract): custom errors in contracts crate

* feat(wallet-integration): implement server and API

* feat(wallet-integration): add a few tests to server. Needs more

* refactor(wallet-integration): just use call_data, remove data types

* feat(wallet-integration): add frontend type for flexible serving

* feat(wallet-integration): StateHandler in WalletIntegrationManager. Add terminate method

* refactor(wallet-integration): move to module with pop-cli crate

* feat(wallet-integration): server-side error handling, update port to 9090

* refactor(wallet-integration): restructure server for easier use in thread

* fix(wallet-integration): remove invalid fn `finish`

* docs(wallet-integration): inline comments

* test(wallet-integration): unit tests for wallet-integration server. Add new frontend type

* feat(wallet-integration): two new routes: error and terminate

* refactor(wallet-integration): consistent comments, remove unnecessary code in tests

* feat: add TransactionData::new

* feat: guide user to call a contract (#306)

* feat: guide user for calling a contract

* feat: get metadata contract from the contract path

* refactor: refactor test and validate address input

* fix: apply feedback

* feat: prompt to have another call and skip questions for queries

* refactor: use Cli module instead of cliclack

* test: unit test pop-cli crate

* test: unit contracts crate

* chore: format

* test: refactor and improve test cases

* fix: fix todos and refactor

* test: fix unit test

* feat: parse types of parameters and display it to the user in the placeholder

* refactor: error handling for pop call

* refactor: display call to be executed after guide and reorder

* refactor: when repeat call use same contract values and dont clean screen

* test: add dry-run test

* test: refactor and add more test coverage

* test: more coverage

* fix: unit test

* feat: dev mode to skip certain user prompts

* refactor: test functions, renaming and fix clippy

* refactor: improve devex of pop call contract

* test: adjust tests to refactor

* chore: reset_for_new_call fields

* fix: build contract if has not been built

* refactor: use command state (#338)

Merged set_up_call_config and guide_user_to_call_contract into a single function. Also adds short symbols for arguments.

* fix: parse user inputs for Option arguments (#332)

* fix: automatically add some or none to Option argument

* test: refactor and tests

* refactor: improve code and comments

* fix: renaming and clean code

* chore: option params not mandatory

* fix: parse user inputs for Option arguments in constructor (#335)

* fix: automatically add some or none to Option argument

* fix: tests

* refactor: process_function_args

* test: update tests accordingly last changes

* fix: issue with delimiter

* test: fix unit test

* refactor: renaming and fix comments

* refactor: format types (#339)

Shows the full type representation, making it easier to see the entry format of parameter values.

* fix: logo doesn't show in README

---------

Co-authored-by: Frank Bell <[email protected]>
Co-authored-by: Alejandro Martinez Andres <[email protected]>

* test: fix unit test

* feat: allow users to specify custom contract metadata files (#347)

* chore: allow the user specify the metadata file to call a contract

* test: unit test to parse metadata from a file

* docs: fix docs

* refactor: ensure_contract_built after user input path

* fix: call contract when metadata file

* fix: remove default_input in contract address

* docs: rename metadata with artifact

* fix: panic at has_contract_been_built

* fix: clippy

* refactor: keep ensure_contract_built as a CallContractCommand function

* fix: ensure_contract_built

* docs: improve comments

* fix: feedback and include wasm file for testing

* fix: clippy

* chore: after build contract prompt the user if the contract is already deployed

* refactor: ensure_contract_built

* refactor: has_contract_been_built function

* docs: fix comments and messages

* refactor: get_messages and get_constructors

* test: fix unit tests call ui

---------

Co-authored-by: Frank Bell <[email protected]>
Co-authored-by: Alejandro Martinez Andres <[email protected]>

* fix: support new substrate-contracts-node structure and stabilize integration tests (#360)

* fix: parse new structure substrate-contracts-node

* fix: paseo+coretime integration test

* fix: sourcing latest version substrate-contracts-node

* refactor: set_executable_permission function

* fix: clippy

* chore: CI configuration

* test: specify port in run_contracts_node

* fix: use random ports instead of hardcoded ones

* fix: build spec experience (#331)

* fix: add chain to specify the chain specification

* fix: default_bootnode by default to true

* chore: fmt

* chore: deprecate flag --release in build specs

* fix: clean output (#334)

* fix: undo deprecation of --release flag

* refactor: small fix

* style: remove extra space

* fix(spec): better handling of spinner

* style: use spinner instead of multispinner

* docs: help message to include build

* feat: reuse existing chain spec

* refactor: remove clone

* refactor: opt in to edit provided chain spec

* docs: improve

* refactor: flow flag input

* fix: prepare_output_path

* refactor: resolve small improvements

* fix: protocol id prompt

* fix: spinner

* fix: docs

* test: test cli

* chore: refactor

* chore: amend test

* feat: production profile

* refactor: improve profile experience

* chore: feedback and rebase

* chore: add profile tests

* fix(test): parachain_lifecycle

* style: fmt

* fix: clippy

* fix: cli required changes introduced by PR

* fix: test

* fix: clippy

* docs: deprecation message

---------

Co-authored-by: Alejandro Martinez Andres <[email protected]>
Co-authored-by: Daanvdplas <[email protected]>

* feat: guide user to call a parachain (#316)

* feat: guide user for calling a contract

* feat: get metadata contract from the contract path

* refactor: refactor test and validate address input

* fix: apply feedback

* feat: prompt to have another call and skip questions for queries

* refactor: use Cli module instead of cliclack

* test: unit test pop-cli crate

* test: unit contracts crate

* chore: format

* test: refactor and improve test cases

* fix: fix todos and refactor

* test: fix unit test

* feat: parse types of parameters and display it to the user in the placeholder

* refactor: error handling for pop call

* refactor: display call to be executed after guide and reorder

* refactor: when repeat call use same contract values and dont clean screen

* test: add dry-run test

* test: refactor and add more test coverage

* test: more coverage

* fix: unit test

* feat: dev mode to skip certain user prompts

* refactor: test functions, renaming and fix clippy

* refactor: improve devex of pop call contract

* test: adjust tests to refactor

* chore: reset_for_new_call fields

* fix: build contract if has not been built

* refactor: use command state (#338)

Merged set_up_call_config and guide_user_to_call_contract into a single function. Also adds short symbols for arguments.

* fix: automatically add some or none to Option argument

* test: refactor and tests

* refactor: improve code and comments

* fix: renaming and clean code

* chore: option params not mandatory

* fix: parse user inputs for Option arguments in constructor (#335)

* fix: automatically add some or none to Option argument

* fix: tests

* refactor: process_function_args

* test: update tests accordingly last changes

* fix: issue with delimiter

* test: fix unit test

* refactor: renaming and fix comments

* refactor: format types (#339)

Shows the full type representation, making it easier to see the entry format of parameter values.

* fix: logo doesn't show in README

* feat: pop call parachain prototype

* feat: dispaly arguments of extrinsic

* refactor: structure similar to pop call contract

* feat: parse all values for extrinsic/storage

* refactor: signer in common

* refactor: improve messages

* feat: call parachain ui

* fix: calls working

* refactor: remove unused code

* refactor: remove unused code

* refactor: various fixes

* refactor: various fixes

* feat: add option to include params from command line

* refactor: clean docs and refactor code

* fix: tests

* refactor: parse all the metadata again

* refactor: reorganize and clean metadata functions

* feat: display specific use cases to the user

* refactor: predefined actions

* fix: various fixes

* fix: error message not supported for complex types

* refactor: parse all metadata, including parameters at once

* refactor: clean docs and move code

* fix: format_type

* fix: parse user inputs for Option arguments (#332)

* fix: automatically add some or none to Option argument

* test: refactor and tests

* refactor: improve code and comments

* fix: renaming and clean code

* chore: option params not mandatory

* fix: parse user inputs for Option arguments in constructor (#335)

* fix: automatically add some or none to Option argument

* fix: tests

* refactor: process_function_args

* test: update tests accordingly last changes

* fix: issue with delimiter

* test: fix unit test

* refactor: renaming and fix comments

* refactor: format types (#339)

Shows the full type representation, making it easier to see the entry format of parameter values.

* fix: logo doesn't show in README

---------

Co-authored-by: Frank Bell <[email protected]>
Co-authored-by: Alejandro Martinez Andres <[email protected]>

* test: fix unit test

* refactor: clean the way to parse and prompt parameters

* feat: add Purchase on-demand coretime use cases

* test: add skip_confirm, move when prompt for the signer and create the integration test

* test: call parachain ui unit test

* refactor: separate structs

* fmt

* test: pop-cli unit testing

* test: pop-common unit tests

* test: parse metadata unit tests

* test: refactor and test processing parameters

* test: comments and unit test in call functions

* fix: clippy warnings

* chore: fmt

* fix: solve conflicts and unit tests (#359)

* test: call parachain ui unit test

* test: pop-cli unit testing

* test: pop-common unit tests

* test: parse metadata unit tests

* test: refactor and test processing parameters

* test: comments and unit test in call functions

* fix: clippy warnings

* chore: fmt

* fix: conflicts and unit tests

* test: remove test and improve test

* feat: guide user for calling a contract

* feat: get metadata contract from the contract path

* refactor: refactor test and validate address input

* fix: apply feedback

* feat: prompt to have another call and skip questions for queries

* refactor: use Cli module instead of cliclack

* test: unit test pop-cli crate

* test: unit contracts crate

* chore: format

* test: refactor and improve test cases

* fix: fix todos and refactor

* test: fix unit test

* feat: parse types of parameters and display it to the user in the placeholder

* refactor: error handling for pop call

* refactor: display call to be executed after guide and reorder

* refactor: when repeat call use same contract values and dont clean screen

* test: add dry-run test

* test: refactor and add more test coverage

* test: more coverage

* fix: unit test

* feat: dev mode to skip certain user prompts

* refactor: test functions, renaming and fix clippy

* refactor: improve devex of pop call contract

* test: adjust tests to refactor

* chore: reset_for_new_call fields

* fix: build contract if has not been built

* refactor: use command state (#338)

Merged set_up_call_config and guide_user_to_call_contract into a single function. Also adds short symbols for arguments.

* fix: automatically add some or none to Option argument

* test: refactor and tests

* refactor: improve code and comments

* fix: renaming and clean code

* chore: option params not mandatory

* fix: parse user inputs for Option arguments in constructor (#335)

* fix: automatically add some or none to Option argument

* fix: tests

* refactor: process_function_args

* test: update tests accordingly last changes

* fix: issue with delimiter

* test: fix unit test

* refactor: renaming and fix comments

* refactor: format types (#339)

Shows the full type representation, making it easier to see the entry format of parameter values.

* feat: pop call parachain prototype

* feat: dispaly arguments of extrinsic

* refactor: structure similar to pop call contract

* feat: parse all values for extrinsic/storage

* refactor: signer in common

* refactor: improve messages

* feat: call parachain ui

* fix: calls working

* refactor: remove unused code

* refactor: remove unused code

* refactor: various fixes

* refactor: various fixes

* feat: add option to include params from command line

* refactor: clean docs and refactor code

* fix: tests

* refactor: parse all the metadata again

* refactor: reorganize and clean metadata functions

* feat: display specific use cases to the user

* refactor: predefined actions

* fix: various fixes

* fix: error message not supported for complex types

* refactor: parse all metadata, including parameters at once

* refactor: clean docs and move code

* fix: format_type

* test: fix unit test

* refactor: clean the way to parse and prompt parameters

* feat: add Purchase on-demand coretime use cases

* test: add skip_confirm, move when prompt for the signer and create the integration test

* test: call parachain ui unit test

* test: pop-cli unit testing

* test: pop-common unit tests

* test: parse metadata unit tests

* test: refactor and test processing parameters

* test: comments and unit test in call functions

* fix: clippy warnings

* chore: fmt

* feat: repeat call only if using guide UI

* fix: clippy

* refactor: various improvements

* chore: parser for pallet and extrinsic input names

* refactor: only move to pop_common the needed functions

* refactor: improve test, docs and errors

* test: fix unit tests

* fix: reset_for_new_call when extrinisc is not supported

* fix: build with parachain features

* test: wait before call parachain in integration test

* docs: minor improvements

* test: migrate find_free_port to pop_common

* test: fix increase waiting time

* test: remove unnecesary test case

* refactor: rename api with client

* refactor: naming and docs

* docs: improve docs and missing comments

* test: remove unnecesary verbose

* test: find_free_port

* docs: improve parameter documentation

* test: add missing test to sign_and_submit_extrinsic

* fix: apply feedback from auxiliar PRs, remove unnecesary clones

* docs: public modules

* refactor: clean unused params

* fix: mark all extrinsics that uses calls as parameter as unsupported

* test: fix expect_select

* docs: improve documentation

* feat: submit extrinsic from call_data (#348)

* feat: submit extrinsic from call_data

* test: unit test for initialize_api_client

* test: unit test for send_extrinsic_from_call_data

* fix: CallData struct

* fix: skip_confirm for send_extrinsic_from_call_data

* chore: clippy

* chore: fmt

* refactor: minor doc and naming changes

* refactor: remove unnecesary clones and return early when submit_extrinsic_from_call_data

* chore: fmt

* refactor: split decode_call_data logic outside sign_and_submit_extrinsic_with_call_data

* feat: parse files when the argument values are very big (#363)

* feat: parse files when the argument values are very big

* test: unit test

* chore: fmt

* feat: file logic using the command line

* fix: sequence arguments

* test: fix unit test

* refactor: remove prompting the user if input is file or value

* refactor: parse_extrinsic_arguments

* fix: CI deny

* refactor: reorder Param  derive macros

* test: fix decode_call_data_works unit test

* refactor: use Default derive macro and define constants for test values (#366)

* feat: parse files when the argument values are very big

* chore: fmt

* feat: file logic using the command line

* fix: sequence arguments

* refactor: parse_extrinsic_arguments

* refactor: use Default in pop_parachain structs

* refactor: use Default in CallParachainCommand struct

* refactor: use constant in tests

* chore: fmt and small refactor

* feat: flag sudo to wrap extrinsic (#349)

* feat: submit extrinsic from call_data

* test: unit test for initialize_api_client

* feat: wrap call into a sudo call

* test: add unit test to the new logic

* fix: skip_confirm for send_extrinsic_from_call_data

* chore: clippy

* docs: renaming and improve docs

* test: use force_transfer for testing

* fix: check if sudo exist before prompt the user

* chore: fmt

* chore: fmt

* test: fix wrong assert

* docs: improve comments and output messages

* refactor: split decode_call_data logic outside sign_and_submit_extrinsic_with_call_data

* fix: test construct_sudo_extrinsic_works and formatting

* refactor: various fixes and improvements (#367)

* refactor: sort pallets/dispatchables

* refactor: remove unnecessary async

* fix: resolve issue after rebase

* fix: more async issues after rebase

* refactor: use single constant

* refactor: terminology (#368)

* refactor: terminology

* refactor: simply pallet/function relationship

* fix: amend call_data conflicts after refactor

* refactor: improvements (#370)

* fix: add missing short arg option

* refactor: note that extrinsic wait includes finalization

* refactor: remove clones

* style: formatting

* refactor: make file prompt more generic

* refactor: add missing license headers

* style: formatting

* docs: comments

* docs: comments

* docs: comments

* refactor: reuse existing metadata

* refactor: minimise clones

* docs: comments

* refactor: naming

* docs: fix parameter doc comments

* refactor: address clippy warnings

* refactor: rename parachain with chain as the primary command and retain parachain as an alias (#373)

* refactor: rename parachain with chain in visible messages

* refactor: rename parachain with chain internal code

* chore: solve fmt after rebase

* refactor: small fix, use alias instead aliases

* refactor: rename CallParachain struct into Call

---------

Co-authored-by: Frank Bell <[email protected]>
Co-authored-by: Alejandro Martinez Andres <[email protected]>
Co-authored-by: Daanvdplas <[email protected]>

* feat(wallet-integration): server and API (#362)

* feat(wallet-integration): implement server and API

* feat(wallet-integration): add a few tests to server. Needs more

* refactor(wallet-integration): just use call_data, remove data types

* feat(wallet-integration): add frontend type for flexible serving

* feat(wallet-integration): StateHandler in WalletIntegrationManager. Add terminate method

* refactor(wallet-integration): move to module with pop-cli crate

* feat(wallet-integration): server-side error handling, update port to 9090

* refactor(wallet-integration): restructure server for easier use in thread

* fix(wallet-integration): remove invalid fn `finish`

* docs(wallet-integration): inline comments

* test(wallet-integration): unit tests for wallet-integration server. Add new frontend type

* feat(wallet-integration): two new routes: error and terminate

* refactor(wallet-integration): consistent comments, remove unnecessary code in tests

* feat: add TransactionData::new

* refactor(wallet-integration: shutdown channel error handling, terminate helper, take_error and TranscationData::new tests

* chore: clippy warning

* feat(up-contract): get call data for upload-only and pass to wallet integration -- PoC

* chore: use git branch for cargo contract

* feat(up-contract): handle subxt events better, various improvements

* refactor: reuse pop up logic

* chore: rebase fixes

* refactor: clean after rebase

* fix: cargo.lock after rebase

* refactor: move terminate node into common::contracts

* fix: sp-core not only for contracts

* feat(up-contract): serve HTML from string, fix deployment message on error, cors, and other misc. improvements

* fix: rebase

* chore: deny.toml license

* feat: secure signing logic for pop call contract

* feat: integrate secure signing with pop call contract

* test: adapt pop-cli ui tests

* refactor: clean code

* docs: improve docs functions

* test: ignore failing test (fixed in another PR), and remove println

* fix: import removed by mistake

* feat(up-contract): serve HTML from string, fix deployment message on error, cors, and other misc. improvements

* feat(up-contract): serve HTML from string, fix deployment message on error, cors, and other misc. improvements

* feat(wallet-integration): server and API (#362)

* feat(wallet-integration): implement server and API

* feat(wallet-integration): add a few tests to server. Needs more

* refactor(wallet-integration): just use call_data, remove data types

* feat(wallet-integration): add frontend type for flexible serving

* feat(wallet-integration): StateHandler in WalletIntegrationManager. Add terminate method

* refactor(wallet-integration): move to module with pop-cli crate

* feat(wallet-integration): server-side error handling, update port to 9090

* refactor(wallet-integration): restructure server for easier use in thread

* fix(wallet-integration): remove invalid fn `finish`

* docs(wallet-integration): inline comments

* test(wallet-integration): unit tests for wallet-integration server. Add new frontend type

* feat(wallet-integration): two new routes: error and terminate

* refactor(wallet-integration): consistent comments, remove unnecessary code in tests

* feat: add TransactionData::new

* refactor(wallet-integration: shutdown channel error handling, terminate helper, take_error and TranscationData::new tests

* chore: clippy warning

* feat(up-contract): get call data for upload-only and pass to wallet integration -- PoC

* feat(up-contract): get call data for instantiate and pass to wallet integration -- PoC

* refactor(pop-up): create functions for wallet integration, plus general cleanup

* chore: use git branch for cargo contract

* feat(up-contract): handle subxt events better, various improvements

* feat(wallet-integration): implement server and API

* feat(wallet-integration): add a few tests to server. Needs more

* refactor(wallet-integration): just use call_data, remove data types

* feat(wallet-integration): add frontend type for flexible serving

* feat(wallet-integration): StateHandler in WalletIntegrationManager. Add terminate method

* refactor(wallet-integration): move to module with pop-cli crate

* feat(wallet-integration): server-side error handling, update port to 9090

* refactor(wallet-integration): restructure server for easier use in thread

* fix(wallet-integration): remove invalid fn `finish`

* docs(wallet-integration): inline comments

* test(wallet-integration): unit tests for wallet-integration server. Add new frontend type

* feat(wallet-integration): two new routes: error and terminate

* refactor(wallet-integration): consistent comments, remove unnecessary code in tests

* feat: guide user to call a contract (#306)

* feat: guide user for calling a contract

* feat: get metadata contract from the contract path

* refactor: refactor test and validate address input

* fix: apply feedback

* feat: prompt to have another call and skip questions for queries

* refactor: use Cli module instead of cliclack

* test: unit test pop-cli crate

* test: unit contracts crate

* chore: format

* test: refactor and improve test cases

* fix: fix todos and refactor

* test: fix unit test

* feat: parse types of parameters and display it to the user in the placeholder

* refactor: error handling for pop call

* refactor: display call to be executed after guide and reorder

* refactor: when repeat call use same contract values and dont clean screen

* test: add dry-run test

* test: refactor and add more test coverage

* test: more coverage

* fix: unit test

* feat: dev mode to skip certain user prompts

* refactor: test functions, renaming and fix clippy

* refactor: improve devex of pop call contract

* test: adjust tests to refactor

* chore: reset_for_new_call fields

* fix: build contract if has not been built

* refactor: use command state (#338)

Merged set_up_call_config and guide_user_to_call_contract into a single function. Also adds short symbols for arguments.

* fix: parse user inputs for Option arguments (#332)

* fix: automatically add some or none to Option argument

* test: refactor and tests

* refactor: improve code and comments

* fix: renaming and clean code

* chore: option params not mandatory

* fix: parse user inputs for Option arguments in constructor (#335)

* fix: automatically add some or none to Option argument

* fix: tests

* refactor: process_function_args

* test: update tests accordingly last changes

* fix: issue with delimiter

* test: fix unit test

* refactor: renaming and fix comments

* refactor: format types (#339)

Shows the full type representation, making it easier to see the entry format of parameter values.

* fix: logo doesn't show in README

---------

Co-authored-by: Frank Bell <[email protected]>
Co-authored-by: Alejandro Martinez Andres <[email protected]>

* test: fix unit test

* feat: allow users to specify custom contract metadata files (#347)

* chore: allow the user specify the metadata file to call a contract

* test: unit test to parse metadata from a file

* docs: fix docs

* refactor: ensure_contract_built after user input path

* fix: call contract when metadata file

* fix: remove default_input in contract address

* docs: rename metadata with artifact

* fix: panic at has_contract_been_built

* fix: clippy

* refactor: keep ensure_contract_built as a CallContractCommand function

* fix: ensure_contract_built

* docs: improve comments

* fix: feedback and include wasm file for testing

* fix: clippy

* chore: after build contract prompt the user if the contract is already deployed

* refactor: ensure_contract_built

* refactor: has_contract_been_built function

* docs: fix comments and messages

* refactor: get_messages and get_constructors

* test: fix unit tests call ui

---------

Co-authored-by: Frank Bell <[email protected]>
Co-authored-by: Alejandro Martinez Andres <[email protected]>

* fix: support new substrate-contracts-node structure and stabilize integration tests (#360)

* fix: parse new structure substrate-contracts-node

* fix: paseo+coretime integration test

* fix: sourcing latest version substrate-contracts-node

* refactor: set_executable_permission function

* fix: clippy

* chore: CI configuration

* test: specify port in run_contracts_node

* fix: use random ports instead of hardcoded ones

* feat: guide user to call a parachain (#316)

* feat: guide user for calling a contract

* feat: get metadata contract from the contract path

* refactor: refactor test and validate address input

* fix: apply feedback

* feat: prompt to have another call and skip questions for queries

* refactor: use Cli module instead of cliclack

* test: unit test pop-cli crate

* test: unit contracts crate

* chore: format

* test: refactor and improve test cases

* fix: fix todos and refactor

* test: fix unit test

* feat: parse types of parameters and display it to the user in the placeholder

* refactor: error handling for pop call

* refactor: display call to be executed after guide and reorder

* refactor: when repeat call use same contract values and dont clean screen

* test: add dry-run test

* test: refactor and add more test coverage

* test: more coverage

* fix: unit test

* feat: dev mode to skip certain user prompts

* refactor: test functions, renaming and fix clippy

* refactor: improve devex of pop call contract

* test: adjust tests to refactor

* chore: reset_for_new_call fields

* fix: build contract if has not been built

* refactor: use command state (#338)

Merged set_up_call_config and guide_user_to_call_contract into a single function. Also adds short symbols for arguments.

* fix: automatically add some or none to Option argument

* test: refactor and tests

* refactor: improve code and comments

* fix: renaming and clean code

* chore: option params not mandatory

* fix: parse user inputs for Option arguments in constructor (#335)

* fix: automatically add some or none to Option argument

* fix: tests

* refactor: process_function_args

* test: update tests accordingly last changes

* fix: issue with delimiter

* test: fix unit test

* refactor: renaming and fix comments

* refactor: format types (#339)

Shows the full type representation, making it easier to see the entry format of parameter values.

* fix: logo doesn't show in README

* feat: pop call parachain prototype

* feat: dispaly arguments of extrinsic

* refactor: structure similar to pop call contract

* feat: parse all values for extrinsic/storage

* refactor: signer in common

* refactor: improve messages

* feat: call parachain ui

* fix: calls working

* refactor: remove unused code

* refactor: remove unused code

* refactor: various fixes

* refactor: various fixes

* feat: add option to include params from command line

* refactor: clean docs and refactor code

* fix: tests

* refactor: parse all the metadata again

* refactor: reorganize and clean metadata functions

* feat: display specific use cases to the user

* refactor: predefined actions

* fix: various fixes

* fix: error message not supported for complex types

* refactor: parse all metadata, including parameters at once

* refactor: clean docs and move code

* fix: format_type

* fix: parse user inputs for Option arguments (#332)

* fix: automatically add some or none to Option argument

* test: refactor and tests

* refactor: improve code and comments

* fix: renaming and clean code

* chore: option params not mandatory

* fix: parse user inputs for Option arguments in constructor (#335)

* fix: automatically add some or none to Option argument

* fix: tests

* refactor: process_function_args

* test: update tests accordingly last changes

* fix: issue with delimiter

* test: fix unit test

* refactor: renaming and fix comments

* refactor: format types (#339)

Shows the full type representation, making it easier to see the entry format of parameter values.

* fix: logo doesn't show in README

---------

Co-authored-by: Frank Bell <[email protected]>
Co-authored-by: Alejandro Martinez Andres <[email protected]>

* test: fix unit test

* refactor: clean the way to parse and prompt parameters

* feat: add Purchase on-demand coretime use cases

* test: add skip_confirm, move when prompt for the signer and create the integration test

* test: call parachain ui unit test

* refactor: separate structs

* fmt

* test: pop-cli unit testing

* test: pop-common unit tests

* test: parse metadata unit tests

* test: refactor and test processing parameters

* test: comments and unit test in call functions

* fix: clippy warnings

* chore: fmt

* fix: solve conflicts and unit tests (#359)

* test: call parachain ui unit test

* test: pop-cli unit testing

* test: pop-common unit tests

* test: parse metadata unit tests

* test: refactor and test processing parameters

* test: comments and unit test in call functions

* fix: clippy warnings

* chore: fmt

* fix: conflicts and unit tests

* test: remove test and improve test

* feat: guide user for calling a contract

* feat: get metadata contract from the contract path

* refactor: refactor test and validate address input

* fix: apply feedback

* feat: prompt to have another call and skip questions for queries

* refactor: use Cli module instead of cliclack

* test: unit test pop-cli crate

* test: unit contracts crate

* chore: format

* test: refactor and improve test cases

* fix: fix todos and refactor

* test: fix unit test

* feat: parse types of parameters and display it to the user in the placeholder

* refactor: error handling for pop call

* refactor: display call to be executed after guide and reorder

* refactor: when repeat call use same contract values and dont clean screen

* test: add dry-run test

* test: refactor and add more test coverage

* test: more coverage

* fix: unit test

* feat: dev mode to skip certain user prompts

* refactor: test functions, renaming and fix clippy

* refactor: improve devex of pop call contract

* test: adjust tests to refactor

* chore: reset_for_new_call fields

* fix: build contract if has not been built

* refactor: use command state (#338)

Merged set_up_call_config and guide_user_to_call_contract into a single function. Also adds short symbols for arguments.

* fix: automatically add some or none to Option argument

* test: refactor and tests

* refactor: improve code and comments

* fix: renaming and clean code

* chore: option params not mandatory

* fix: parse user inputs for Option arguments in constructor (#335)

* fix: automatically add some or none to Option argument

* fix: tests

* refactor: process_function_args

* test: update tests accordingly last changes

* fix: issue with delimiter

* test: fix unit test

* refactor: renaming and fix comments

* refactor: format types (#339)

Shows the full type representation, making it easier to see the entry format of parameter values.

* feat: pop call parachain prototype

* feat: dispaly arguments of extrinsic

* refactor: structure similar to pop call contract

* feat: parse all values for extrinsic/storage

* refactor: signer in common

* refactor: improve messages

* feat: call parachain ui

* fix: calls working

* refactor: remove unused code

* refactor: remove unused code

* refactor: various fixes

* refactor: various fixes

* feat: add option to include params from command line

* refactor: clean docs and refactor code

* fix: tests

* refactor: parse all the metadata again

* refactor: reorganize and clean metadata functions

* feat: display specific use cases to the user

* refactor: predefined actions

* fix: various fixes

* fix: error message not supported for complex types

* refactor: parse all metadata, including parameters at once

* refactor: clean docs and move code

* fix: format_type

* test: fix unit test

* refactor: clean the way to parse and prompt parameters

* feat: add Purchase on-demand coretime use cases

* test: add skip_confirm, move when prompt for the signer and create the integration test

* test: call parachain ui unit test

* test: pop-cli unit testing

* test: pop-common unit tests

* test: parse metadata unit tests

* test: refactor and test processing parameters

* test: comments and unit test in call functions

* fix: clippy warnings

* chore: fmt

* feat: repeat call only if using guide UI

* fix: clippy

* refactor: various improvements

* chore: parser for pallet and extrinsic input names

* refactor: only move to pop_common the needed functions

* refactor: improve test, docs and errors

* test: fix unit tests

* fix: reset_for_new_call when extrinisc is not supported

* fix: build with parachain features

* test: wait before call parachain in integration test

* docs: minor improvements

* test: migrate find_free_port to pop_common

* test: fix increase waiting time

* test: remove unnecesary test case

* refactor: rename api with client

* refactor: naming and docs

* docs: improve docs and missing comments

* test: remove unnecesary verbose

* test: find_free_port

* docs: improve parameter documentation

* test: add missing test to sign_and_submit_extrinsic

* fix: apply feedback from auxiliar PRs, remove unnecesary clones

* docs: public modules

* refactor: clean unused params

* fix: mark all extrinsics that uses calls as parameter as unsupported

* test: fix expect_select

* docs: improve documentation

* feat: submit extrinsic from call_data (#348)

* feat: submit extrinsic from call_data

* test: unit test for initialize_api_client

* test: unit test for send_extrinsic_from_call_data

* fix: CallData struct

* fix: skip_confirm for send_extrinsic_from_call_data

* chore: clippy

* chore: fmt

* refactor: minor doc and naming changes

* refactor: remove unnecesary clones and return early when submit_extrinsic_from_call_data

* chore: fmt

* refactor: split decode_call_data logic outside sign_and_submit_extrinsic_with_call_data

* feat: parse files when the argument values are very big (#363)

* feat: parse files when the argument values are very big

* test: unit test

* chore: fmt

* feat: file logic using the command line

* fix: sequence arguments

* test: fix unit test

* refactor: remove prompting the user if input is file or value

* refactor: parse_extrinsic_arguments

* fix: CI deny

* refactor: reorder Param  derive macros

* test: fix decode_call_data_works unit test

* refactor: use Default derive macro and define constants for test values (#366)

* feat: parse files when the argument values are very big

* chore: fmt

* feat: file logic using the command line

* fix: sequence arguments

* refactor: parse_extrinsic_arguments

* refactor: use Default in pop_parachain structs

* refactor: use Default in CallParachainCommand struct

* refactor: use constant in tests

* chore: fmt and small refactor

* feat: flag sudo to wrap extrinsic (#349)

* feat: submit extrinsic from call_data

* test: unit test for initialize_api_client

* feat: wrap call into a sudo call

* test: add unit test to the new logic

* fix: skip_confirm for send_extrinsic_from_call_data

* chore: clippy

* docs: rena…
peterwht added a commit that referenced this pull request Dec 19, 2024
@peterwht @AlexD10S
@evilrobot-01 @al3mart @Daanvdplas
feat: wallet integration (#371)
22a74b3 
* feat(wallet-integration): server and API (#362)

* feat(wallet-integration): implement server and API

* feat(wallet-integration): add a few tests to server. Needs more

* refactor(wallet-integration): just use call_data, remove data types

* feat(wallet-integration): add frontend type for flexible serving

* feat(wallet-integration): StateHandler in WalletIntegrationManager. Add terminate method

* refactor(wallet-integration): move to module with pop-cli crate

* feat(wallet-integration): server-side error handling, update port to 9090

* refactor(wallet-integration): restructure server for easier use in thread

* fix(wallet-integration): remove invalid fn `finish`

* docs(wallet-integration): inline comments

* test(wallet-integration): unit tests for wallet-integration server. Add new frontend type

* feat(wallet-integration): two new routes: error and terminate

* refactor(wallet-integration): consistent comments, remove unnecessary code in tests

* feat: add TransactionData::new

* refactor(wallet-integration: shutdown channel error handling, terminate helper, take_error and TranscationData::new tests

* chore: clippy warning

* feat(wallet integration): pop up contract (#365)

* feat(wallet-integration): server and API (#362)

* feat(wallet-integration): implement server and API

* feat(wallet-integration): add a few tests to server. Needs more

* refactor(wallet-integration): just use call_data, remove data types

* feat(wallet-integration): add frontend type for flexible serving

* feat(wallet-integration): StateHandler in WalletIntegrationManager. Add terminate method

* refactor(wallet-integration): move to module with pop-cli crate

* feat(wallet-integration): server-side error handling, update port to 9090

* refactor(wallet-integration): restructure server for easier use in thread

* fix(wallet-integration): remove invalid fn `finish`

* docs(wallet-integration): inline comments

* test(wallet-integration): unit tests for wallet-integration server. Add new frontend type

* feat(wallet-integration): two new routes: error and terminate

* refactor(wallet-integration): consistent comments, remove unnecessary code in tests

* feat: add TransactionData::new

* refactor(wallet-integration: shutdown channel error handling, terminate helper, take_error and TranscationData::new tests

* chore: clippy warning

* feat(up-contract): get call data for upload-only and pass to wallet integration -- PoC

* feat(up-contract): get call data for instantiate and pass to wallet integration -- PoC

* feat(up-contract): run server and pass call_data for signing -- PoC

* feat(up-contract): submit signed payload to node

* fix(up-contract): update to FrontendFromDir type

* refactor(pop-up): create functions for wallet integration, plus general cleanup

* chore: use git branch for cargo contract

* feat(pop-up-contract): better error handling and prompt displays

* chore(up-contract): outdated field name and clippy allow

* feat(up-contract): handle subxt events better, various improvements

* feat(up-contract): custom errors in contracts crate

* fix: minor fixes after rebase

* fix(up-contract): test compilation after rebase

* feat(up-contract): suri and use-wallet can't be used together

* refactor: wait for finalization

* feat(up-contract): serve HTML from string, fix deployment message on error, cors, and other misc. improvements (#380)

* docs: add function comments

* feat: wallet integration pop call chain (#379)

* feat(wallet-integration): server and API (#362)

* feat(wallet-integration): implement server and API

* feat(wallet-integration): add a few tests to server. Needs more

* refactor(wallet-integration): just use call_data, remove data types

* feat(wallet-integration): add frontend type for flexible serving

* feat(wallet-integration): StateHandler in WalletIntegrationManager. Add terminate method

* refactor(wallet-integration): move to module with pop-cli crate

* feat(wallet-integration): server-side error handling, update port to 9090

* refactor(wallet-integration): restructure server for easier use in thread

* fix(wallet-integration): remove invalid fn `finish`

* docs(wallet-integration): inline comments

* test(wallet-integration): unit tests for wallet-integration server. Add new frontend type

* feat(wallet-integration): two new routes: error and terminate

* refactor(wallet-integration): consistent comments, remove unnecessary code in tests

* feat: add TransactionData::new

* refactor(wallet-integration: shutdown channel error handling, terminate helper, take_error and TranscationData::new tests

* chore: clippy warning

* feat(up-contract): get call data for upload-only and pass to wallet integration -- PoC

* feat(up-contract): get call data for instantiate and pass to wallet integration -- PoC

* feat(up-contract): run server and pass call_data for signing -- PoC

* feat(up-contract): submit signed payload to node

* fix(up-contract): update to FrontendFromDir type

* refactor(pop-up): create functions for wallet integration, plus general cleanup

* chore: use git branch for cargo contract

* feat(pop-up-contract): better error handling and prompt displays

* chore(up-contract): outdated field name and clippy allow

* feat(up-contract): handle subxt events better, various improvements

* feat(up-contract): custom errors in contracts crate

* fix: minor fixes after rebase

* fix(up-contract): test compilation after rebase

* feat(up-contract): suri and use-wallet can't be used together

* refactor: wait for finalization

* feat(up-contract): serve HTML from string, fix deployment message on error, cors, and other misc. improvements (#380)

* feat(wallet-integration): server and API (#362)

* feat(wallet-integration): implement server and API

* feat(wallet-integration): add a few tests to server. Needs more

* refactor(wallet-integration): just use call_data, remove data types

* feat(wallet-integration): add frontend type for flexible serving

* feat(wallet-integration): StateHandler in WalletIntegrationManager. Add terminate method

* refactor(wallet-integration): move to module with pop-cli crate

* feat(wallet-integration): server-side error handling, update port to 9090

* refactor(wallet-integration): restructure server for easier use in thread

* fix(wallet-integration): remove invalid fn `finish`

* docs(wallet-integration): inline comments

* test(wallet-integration): unit tests for wallet-integration server. Add new frontend type

* feat(wallet-integration): two new routes: error and terminate

* refactor(wallet-integration): consistent comments, remove unnecessary code in tests

* feat: add TransactionData::new

* refactor(wallet-integration: shutdown channel error handling, terminate helper, take_error and TranscationData::new tests

* chore: clippy warning

* feat(up-contract): get call data for upload-only and pass to wallet integration -- PoC

* refactor(pop-up): create functions for wallet integration, plus general cleanup

* chore: use git branch for cargo contract

* feat(up-contract): handle subxt events better, various improvements

* feat(wallet-integration): implement server and API

* feat(wallet-integration): add a few tests to server. Needs more

* refactor(wallet-integration): just use call_data, remove data types

* feat(wallet-integration): add frontend type for flexible serving

* feat(wallet-integration): StateHandler in WalletIntegrationManager. Add terminate method

* refactor(wallet-integration): move to module with pop-cli crate

* feat(wallet-integration): server-side error handling, update port to 9090

* refactor(wallet-integration): restructure server for easier use in thread

* fix(wallet-integration): remove invalid fn `finish`

* docs(wallet-integration): inline comments

* test(wallet-integration): unit tests for wallet-integration server. Add new frontend type

* feat(wallet-integration): two new routes: error and terminate

* refactor(wallet-integration): consistent comments, remove unnecessary code in tests

* feat: guide user to call a contract (#306)

* feat: guide user for calling a contract

* feat: get metadata contract from the contract path

* refactor: refactor test and validate address input

* fix: apply feedback

* feat: prompt to have another call and skip questions for queries

* refactor: use Cli module instead of cliclack

* test: unit test pop-cli crate

* test: unit contracts crate

* chore: format

* test: refactor and improve test cases

* fix: fix todos and refactor

* test: fix unit test

* feat: parse types of parameters and display it to the user in the placeholder

* refactor: error handling for pop call

* refactor: display call to be executed after guide and reorder

* refactor: when repeat call use same contract values and dont clean screen

* test: add dry-run test

* test: refactor and add more test coverage

* test: more coverage

* fix: unit test

* feat: dev mode to skip certain user prompts

* refactor: test functions, renaming and fix clippy

* refactor: improve devex of pop call contract

* test: adjust tests to refactor

* chore: reset_for_new_call fields

* fix: build contract if has not been built

* refactor: use command state (#338)

Merged set_up_call_config and guide_user_to_call_contract into a single function. Also adds short symbols for arguments.

* fix: parse user inputs for Option arguments (#332)

* fix: automatically add some or none to Option argument

* test: refactor and tests

* refactor: improve code and comments

* fix: renaming and clean code

* chore: option params not mandatory

* fix: parse user inputs for Option arguments in constructor (#335)

* fix: automatically add some or none to Option argument

* fix: tests

* refactor: process_function_args

* test: update tests accordingly last changes

* fix: issue with delimiter

* test: fix unit test

* refactor: renaming and fix comments

* refactor: format types (#339)

Shows the full type representation, making it easier to see the entry format of parameter values.

* fix: logo doesn't show in README

---------

Co-authored-by: Frank Bell <[email protected]>
Co-authored-by: Alejandro Martinez Andres <[email protected]>

* test: fix unit test

* feat: allow users to specify custom contract metadata files (#347)

* chore: allow the user specify the metadata file to call a contract

* test: unit test to parse metadata from a file

* docs: fix docs

* refactor: ensure_contract_built after user input path

* fix: call contract when metadata file

* fix: remove default_input in contract address

* docs: rename metadata with artifact

* fix: panic at has_contract_been_built

* fix: clippy

* refactor: keep ensure_contract_built as a CallContractCommand function

* fix: ensure_contract_built

* docs: improve comments

* fix: feedback and include wasm file for testing

* fix: clippy

* chore: after build contract prompt the user if the contract is already deployed

* refactor: ensure_contract_built

* refactor: has_contract_been_built function

* docs: fix comments and messages

* refactor: get_messages and get_constructors

* test: fix unit tests call ui

---------

Co-authored-by: Frank Bell <[email protected]>
Co-authored-by: Alejandro Martinez Andres <[email protected]>

* fix: support new substrate-contracts-node structure and stabilize integration tests (#360)

* fix: parse new structure substrate-contracts-node

* fix: paseo+coretime integration test

* fix: sourcing latest version substrate-contracts-node

* refactor: set_executable_permission function

* fix: clippy

* chore: CI configuration

* test: specify port in run_contracts_node

* fix: use random ports instead of hardcoded ones

* feat: guide user to call a parachain (#316)

* feat: guide user for calling a contract

* feat: get metadata contract from the contract path

* refactor: refactor test and validate address input

* fix: apply feedback

* feat: prompt to have another call and skip questions for queries

* refactor: use Cli module instead of cliclack

* test: unit test pop-cli crate

* test: unit contracts crate

* chore: format

* test: refactor and improve test cases

* fix: fix todos and refactor

* test: fix unit test

* feat: parse types of parameters and display it to the user in the placeholder

* refactor: error handling for pop call

* refactor: display call to be executed after guide and reorder

* refactor: when repeat call use same contract values and dont clean screen

* test: add dry-run test

* test: refactor and add more test coverage

* test: more coverage

* fix: unit test

* feat: dev mode to skip certain user prompts

* refactor: test functions, renaming and fix clippy

* refactor: improve devex of pop call contract

* test: adjust tests to refactor

* chore: reset_for_new_call fields

* fix: build contract if has not been built

* refactor: use command state (#338)

Merged set_up_call_config and guide_user_to_call_contract into a single function. Also adds short symbols for arguments.

* fix: automatically add some or none to Option argument

* test: refactor and tests

* refactor: improve code and comments

* fix: renaming and clean code

* chore: option params not mandatory

* fix: parse user inputs for Option arguments in constructor (#335)

* fix: automatically add some or none to Option argument

* fix: tests

* refactor: process_function_args

* test: update tests accordingly last changes

* fix: issue with delimiter

* test: fix unit test

* refactor: renaming and fix comments

* refactor: format types (#339)

Shows the full type representation, making it easier to see the entry format of parameter values.

* fix: logo doesn't show in README

* feat: pop call parachain prototype

* feat: dispaly arguments of extrinsic

* refactor: structure similar to pop call contract

* feat: parse all values for extrinsic/storage

* refactor: signer in common

* refactor: improve messages

* feat: call parachain ui

* fix: calls working

* refactor: remove unused code

* refactor: remove unused code

* refactor: various fixes

* refactor: various fixes

* feat: add option to include params from command line

* refactor: clean docs and refactor code

* fix: tests

* refactor: parse all the metadata again

* refactor: reorganize and clean metadata functions

* feat: display specific use cases to the user

* refactor: predefined actions

* fix: various fixes

* fix: error message not supported for complex types

* refactor: parse all metadata, including parameters at once

* refactor: clean docs and move code

* fix: format_type

* fix: parse user inputs for Option arguments (#332)

* fix: automatically add some or none to Option argument

* test: refactor and tests

* refactor: improve code and comments

* fix: renaming and clean code

* chore: option params not mandatory

* fix: parse user inputs for Option arguments in constructor (#335)

* fix: automatically add some or none to Option argument

* fix: tests

* refactor: process_function_args

* test: update tests accordingly last changes

* fix: issue with delimiter

* test: fix unit test

* refactor: renaming and fix comments

* refactor: format types (#339)

Shows the full type representation, making it easier to see the entry format of parameter values.

* fix: logo doesn't show in README

---------

Co-authored-by: Frank Bell <[email protected]>
Co-authored-by: Alejandro Martinez Andres <[email protected]>

* test: fix unit test

* refactor: clean the way to parse and prompt parameters

* feat: add Purchase on-demand coretime use cases

* test: add skip_confirm, move when prompt for the signer and create the integration test

* test: call parachain ui unit test

* refactor: separate structs

* fmt

* test: pop-cli unit testing

* test: pop-common unit tests

* test: parse metadata unit tests

* test: refactor and test processing parameters

* test: comments and unit test in call functions

* fix: clippy warnings

* chore: fmt

* fix: solve conflicts and unit tests (#359)

* test: call parachain ui unit test

* test: pop-cli unit testing

* test: pop-common unit tests

* test: parse metadata unit tests

* test: refactor and test processing parameters

* test: comments and unit test in call functions

* fix: clippy warnings

* chore: fmt

* fix: conflicts and unit tests

* test: remove test and improve test

* feat: guide user for calling a contract

* feat: get metadata contract from the contract path

* refactor: refactor test and validate address input

* fix: apply feedback

* feat: prompt to have another call and skip questions for queries

* refactor: use Cli module instead of cliclack

* test: unit test pop-cli crate

* test: unit contracts crate

* chore: format

* test: refactor and improve test cases

* fix: fix todos and refactor

* test: fix unit test

* feat: parse types of parameters and display it to the user in the placeholder

* refactor: error handling for pop call

* refactor: display call to be executed after guide and reorder

* refactor: when repeat call use same contract values and dont clean screen

* test: add dry-run test

* test: refactor and add more test coverage

* test: more coverage

* fix: unit test

* feat: dev mode to skip certain user prompts

* refactor: test functions, renaming and fix clippy

* refactor: improve devex of pop call contract

* test: adjust tests to refactor

* chore: reset_for_new_call fields

* fix: build contract if has not been built

* refactor: use command state (#338)

Merged set_up_call_config and guide_user_to_call_contract into a single function. Also adds short symbols for arguments.

* fix: automatically add some or none to Option argument

* test: refactor and tests

* refactor: improve code and comments

* fix: renaming and clean code

* chore: option params not mandatory

* fix: parse user inputs for Option arguments in constructor (#335)

* fix: automatically add some or none to Option argument

* fix: tests

* refactor: process_function_args

* test: update tests accordingly last changes

* fix: issue with delimiter

* test: fix unit test

* refactor: renaming and fix comments

* refactor: format types (#339)

Shows the full type representation, making it easier to see the entry format of parameter values.

* feat: pop call parachain prototype

* feat: dispaly arguments of extrinsic

* refactor: structure similar to pop call contract

* feat: parse all values for extrinsic/storage

* refactor: signer in common

* refactor: improve messages

* feat: call parachain ui

* fix: calls working

* refactor: remove unused code

* refactor: remove unused code

* refactor: various fixes

* refactor: various fixes

* feat: add option to include params from command line

* refactor: clean docs and refactor code

* fix: tests

* refactor: parse all the metadata again

* refactor: reorganize and clean metadata functions

* feat: display specific use cases to the user

* refactor: predefined actions

* fix: various fixes

* fix: error message not supported for complex types

* refactor: parse all metadata, including parameters at once

* refactor: clean docs and move code

* fix: format_type

* test: fix unit test

* refactor: clean the way to parse and prompt parameters

* feat: add Purchase on-demand coretime use cases

* test: add skip_confirm, move when prompt for the signer and create the integration test

* test: call parachain ui unit test

* test: pop-cli unit testing

* test: pop-common unit tests

* test: parse metadata unit tests

* test: refactor and test processing parameters

* test: comments and unit test in call functions

* fix: clippy warnings

* chore: fmt

* feat: repeat call only if using guide UI

* fix: clippy

* refactor: various improvements

* chore: parser for pallet and extrinsic input names

* refactor: only move to pop_common the needed functions

* refactor: improve test, docs and errors

* test: fix unit tests

* fix: reset_for_new_call when extrinisc is not supported

* fix: build with parachain features

* test: wait before call parachain in integration test

* docs: minor improvements

* test: migrate find_free_port to pop_common

* test: fix increase waiting time

* test: remove unnecesary test case

* refactor: rename api with client

* refactor: naming and docs

* docs: improve docs and missing comments

* test: remove unnecesary verbose

* test: find_free_port

* docs: improve parameter documentation

* test: add missing test to sign_and_submit_extrinsic

* fix: apply feedback from auxiliar PRs, remove unnecesary clones

* docs: public modules

* refactor: clean unused params

* fix: mark all extrinsics that uses calls as parameter as unsupported

* test: fix expect_select

* docs: improve documentation

* feat: submit extrinsic from call_data (#348)

* feat: submit extrinsic from call_data

* test: unit test for initialize_api_client

* test: unit test for send_extrinsic_from_call_data

* fix: CallData struct

* fix: skip_confirm for send_extrinsic_from_call_data

* chore: clippy

* chore: fmt

* refactor: minor doc and naming changes

* refactor: remove unnecesary clones and return early when submit_extrinsic_from_call_data

* chore: fmt

* refactor: split decode_call_data logic outside sign_and_submit_extrinsic_with_call_data

* feat: parse files when the argument values are very big (#363)

* feat: parse files when the argument values are very big

* test: unit test

* chore: fmt

* feat: file logic using the command line

* fix: sequence arguments

* test: fix unit test

* refactor: remove prompting the user if input is file or value

* refactor: parse_extrinsic_arguments

* fix: CI deny

* refactor: reorder Param  derive macros

* test: fix decode_call_data_works unit test

* refactor: use Default derive macro and define constants for test values (#366)

* feat: parse files when the argument values are very big

* chore: fmt

* feat: file logic using the command line

* fix: sequence arguments

* refactor: parse_extrinsic_arguments

* refactor: use Default in pop_parachain structs

* refactor: use Default in CallParachainCommand struct

* refactor: use constant in tests

* chore: fmt and small refactor

* feat: flag sudo to wrap extrinsic (#349)

* feat: submit extrinsic from call_data

* test: unit test for initialize_api_client

* feat: wrap call into a sudo call

* test: add unit test to the new logic

* fix: skip_confirm for send_extrinsic_from_call_data

* chore: clippy

* docs: renaming and improve docs

* test: use force_transfer for testing

* fix: check if sudo exist before prompt the user

* chore: fmt

* chore: fmt

* test: fix wrong assert

* docs: improve comments and output messages

* refactor: split decode_call_data logic outside sign_and_submit_extrinsic_with_call_data

* fix: test construct_sudo_extrinsic_works and formatting

* refactor: various fixes and improvements (#367)

* refactor: sort pallets/dispatchables

* refactor: remove unnecessary async

* fix: resolve issue after rebase

* fix: more async issues after rebase

* refactor: use single constant

* refactor: terminology (#368)

* refactor: terminology

* refactor: simply pallet/function relationship

* fix: amend call_data conflicts after refactor

* refactor: improvements (#370)

* fix: add missing short arg option

* refactor: note that extrinsic wait includes finalization

* refactor: remove clones

* style: formatting

* refactor: make file prompt more generic

* refactor: add missing license headers

* style: formatting

* docs: comments

* docs: comments

* docs: comments

* refactor: reuse existing metadata

* refactor: minimise clones

* docs: comments

* refactor: naming

* docs: fix parameter doc comments

* refactor: address clippy warnings

* refactor: rename parachain with chain as the primary command and retain parachain as an alias (#373)

* refactor: rename parachain with chain in visible messages

* refactor: rename parachain with chain internal code

* chore: solve fmt after rebase

* refactor: small fix, use alias instead aliases

* refactor: rename CallParachain struct into Call

---------

Co-authored-by: Frank Bell <[email protected]>
Co-authored-by: Alejandro Martinez Andres <[email protected]>
Co-authored-by: Daanvdplas <[email protected]>

* feat(wallet-integration): server and API (#362)

* feat(wallet-integration): implement server and API

* feat(wallet-integration): add a few tests to server. Needs more

* refactor(wallet-integration): just use call_data, remove data types

* feat(wallet-integration): add frontend type for flexible serving

* feat(wallet-integration): StateHandler in WalletIntegrationManager. Add terminate method

* refactor(wallet-integration): move to module with pop-cli crate

* feat(wallet-integration): server-side error handling, update port to 9090

* refactor(wallet-integration): restructure server for easier use in thread

* fix(wallet-integration): remove invalid fn `finish`

* docs(wallet-integration): inline comments

* test(wallet-integration): unit tests for wallet-integration server. Add new frontend type

* feat(wallet-integration): two new routes: error and terminate

* refactor(wallet-integration): consistent comments, remove unnecessary code in tests

* feat: add TransactionData::new

* refactor(wallet-integration: shutdown channel error handling, terminate helper, take_error and TranscationData::new tests

* chore: clippy warning

* feat(up-contract): get call data for upload-only and pass to wallet integration -- PoC

* chore: use git branch for cargo contract

* feat(up-contract): handle subxt events better, various improvements

* refactor: reuse pop up logic

* chore: rebase fixes

* refactor: clean after rebase

* fix: cargo.lock after rebase

* refactor: move terminate node into common::contracts

* fix: sp-core not only for contracts

* feat(up-contract): serve HTML from string, fix deployment message on error, cors, and other misc. improvements

* fix: rebase

* feat: secure signing logic for pop call chain

* test: unit tests in pop-cli

* feat: secure signing for call from call_data

* refactor: docs and remove unneded functions

* refactor: replace hex library

* fix: rebase issues

* fix: rebase

* refactor: small changes

* refactor: renaming

* feat: wallet integration call contract (#378)

* feat(wallet-integration): server and API (#362)

* feat(wallet-integration): implement server and API

* feat(wallet-integration): add a few tests to server. Needs more

* refactor(wallet-integration): just use call_data, remove data types

* feat(wallet-integration): add frontend type for flexible serving

* feat(wallet-integration): StateHandler in WalletIntegrationManager. Add terminate method

* refactor(wallet-integration): move to module with pop-cli crate

* feat(wallet-integration): server-side error handling, update port to 9090

* refactor(wallet-integration): restructure server for easier use in thread

* fix(wallet-integration): remove invalid fn `finish`

* docs(wallet-integration): inline comments

* test(wallet-integration): unit tests for wallet-integration server. Add new frontend type

* feat(wallet-integration): two new routes: error and terminate

* refactor(wallet-integration): consistent comments, remove unnecessary code in tests

* feat: add TransactionData::new

* refactor(wallet-integration: shutdown channel error handling, terminate helper, take_error and TranscationData::new tests

* chore: clippy warning

* feat(up-contract): get call data for upload-only and pass to wallet integration -- PoC

* feat(up-contract): get call data for instantiate and pass to wallet integration -- PoC

* feat(up-contract): run server and pass call_data for signing -- PoC

* feat(up-contract): submit signed payload to node

* fix(up-contract): update to FrontendFromDir type

* refactor(pop-up): create functions for wallet integration, plus general cleanup

* chore: use git branch for cargo contract

* feat(pop-up-contract): better error handling and prompt displays

* chore(up-contract): outdated field name and clippy allow

* feat(up-contract): handle subxt events better, various improvements

* feat(up-contract): custom errors in contracts crate

* feat(wallet-integration): implement server and API

* feat(wallet-integration): add a few tests to server. Needs more

* refactor(wallet-integration): just use call_data, remove data types

* feat(wallet-integration): add frontend type for flexible serving

* feat(wallet-integration): StateHandler in WalletIntegrationManager. Add terminate method

* refactor(wallet-integration): move to module with pop-cli crate

* feat(wallet-integration): server-side error handling, update port to 9090

* refactor(wallet-integration): restructure server for easier use in thread

* fix(wallet-integration): remove invalid fn `finish`

* docs(wallet-integration): inline comments

* test(wallet-integration): unit tests for wallet-integration server. Add new frontend type

* feat(wallet-integration): two new routes: error and terminate

* refactor(wallet-integration): consistent comments, remove unnecessary code in tests

* feat: add TransactionData::new

* feat: guide user to call a contract (#306)

* feat: guide user for calling a contract

* feat: get metadata contract from the contract path

* refactor: refactor test and validate address input

* fix: apply feedback

* feat: prompt to have another call and skip questions for queries

* refactor: use Cli module instead of cliclack

* test: unit test pop-cli crate

* test: unit contracts crate

* chore: format

* test: refactor and improve test cases

* fix: fix todos and refactor

* test: fix unit test

* feat: parse types of parameters and display it to the user in the placeholder

* refactor: error handling for pop call

* refactor: display call to be executed after guide and reorder

* refactor: when repeat call use same contract values and dont clean screen

* test: add dry-run test

* test: refactor and add more test coverage

* test: more coverage

* fix: unit test

* feat: dev mode to skip certain user prompts

* refactor: test functions, renaming and fix clippy

* refactor: improve devex of pop call contract

* test: adjust tests to refactor

* chore: reset_for_new_call fields

* fix: build contract if has not been built

* refactor: use command state (#338)

Merged set_up_call_config and guide_user_to_call_contract into a single function. Also adds short symbols for arguments.

* fix: parse user inputs for Option arguments (#332)

* fix: automatically add some or none to Option argument

* test: refactor and tests

* refactor: improve code and comments

* fix: renaming and clean code

* chore: option params not mandatory

* fix: parse user inputs for Option arguments in constructor (#335)

* fix: automatically add some or none to Option argument

* fix: tests

* refactor: process_function_args

* test: update tests accordingly last changes

* fix: issue with delimiter

* test: fix unit test

* refactor: renaming and fix comments

* refactor: format types (#339)

Shows the full type representation, making it easier to see the entry format of parameter values.

* fix: logo doesn't show in README

---------

Co-authored-by: Frank Bell <[email protected]>
Co-authored-by: Alejandro Martinez Andres <[email protected]>

* test: fix unit test

* feat: allow users to specify custom contract metadata files (#347)

* chore: allow the user specify the metadata file to call a contract

* test: unit test to parse metadata from a file

* docs: fix docs

* refactor: ensure_contract_built after user input path

* fix: call contract when metadata file

* fix: remove default_input in contract address

* docs: rename metadata with artifact

* fix: panic at has_contract_been_built

* fix: clippy

* refactor: keep ensure_contract_built as a CallContractCommand function

* fix: ensure_contract_built

* docs: improve comments

* fix: feedback and include wasm file for testing

* fix: clippy

* chore: after build contract prompt the user if the contract is already deployed

* refactor: ensure_contract_built

* refactor: has_contract_been_built function

* docs: fix comments and messages

* refactor: get_messages and get_constructors

* test: fix unit tests call ui

---------

Co-authored-by: Frank Bell <[email protected]>
Co-authored-by: Alejandro Martinez Andres <[email protected]>

* fix: support new substrate-contracts-node structure and stabilize integration tests (#360)

* fix: parse new structure substrate-contracts-node

* fix: paseo+coretime integration test

* fix: sourcing latest version substrate-contracts-node

* refactor: set_executable_permission function

* fix: clippy

* chore: CI configuration

* test: specify port in run_contracts_node

* fix: use random ports instead of hardcoded ones

* fix: build spec experience (#331)

* fix: add chain to specify the chain specification

* fix: default_bootnode by default to true

* chore: fmt

* chore: deprecate flag --release in build specs

* fix: clean output (#334)

* fix: undo deprecation of --release flag

* refactor: small fix

* style: remove extra space

* fix(spec): better handling of spinner

* style: use spinner instead of multispinner

* docs: help message to include build

* feat: reuse existing chain spec

* refactor: remove clone

* refactor: opt in to edit provided chain spec

* docs: improve

* refactor: flow flag input

* fix: prepare_output_path

* refactor: resolve small improvements

* fix: protocol id prompt

* fix: spinner

* fix: docs

* test: test cli

* chore: refactor

* chore: amend test

* feat: production profile

* refactor: improve profile experience

* chore: feedback and rebase

* chore: add profile tests

* fix(test): parachain_lifecycle

* style: fmt

* fix: clippy

* fix: cli required changes introduced by PR

* fix: test

* fix: clippy

* docs: deprecation message

---------

Co-authored-by: Alejandro Martinez Andres <[email protected]>
Co-authored-by: Daanvdplas <[email protected]>

* feat: guide user to call a parachain (#316)

* feat: guide user for calling a contract

* feat: get metadata contract from the contract path

* refactor: refactor test and validate address input

* fix: apply feedback

* feat: prompt to have another call and skip questions for queries

* refactor: use Cli module instead of cliclack

* test: unit test pop-cli crate

* test: unit contracts crate

* chore: format

* test: refactor and improve test cases

* fix: fix todos and refactor

* test: fix unit test

* feat: parse types of parameters and display it to the user in the placeholder

* refactor: error handling for pop call

* refactor: display call to be executed after guide and reorder

* refactor: when repeat call use same contract values and dont clean screen

* test: add dry-run test

* test: refactor and add more test coverage

* test: more coverage

* fix: unit test

* feat: dev mode to skip certain user prompts

* refactor: test functions, renaming and fix clippy

* refactor: improve devex of pop call contract

* test: adjust tests to refactor

* chore: reset_for_new_call fields

* fix: build contract if has not been built

* refactor: use command state (#338)

Merged set_up_call_config and guide_user_to_call_contract into a single function. Also adds short symbols for arguments.

* fix: automatically add some or none to Option argument

* test: refactor and tests

* refactor: improve code and comments

* fix: renaming and clean code

* chore: option params not mandatory

* fix: parse user inputs for Option arguments in constructor (#335)

* fix: automatically add some or none to Option argument

* fix: tests

* refactor: process_function_args

* test: update tests accordingly last changes

* fix: issue with delimiter

* test: fix unit test

* refactor: renaming and fix comments

* refactor: format types (#339)

Shows the full type representation, making it easier to see the entry format of parameter values.

* fix: logo doesn't show in README

* feat: pop call parachain prototype

* feat: dispaly arguments of extrinsic

* refactor: structure similar to pop call contract

* feat: parse all values for extrinsic/storage

* refactor: signer in common

* refactor: improve messages

* feat: call parachain ui

* fix: calls working

* refactor: remove unused code

* refactor: remove unused code

* refactor: various fixes

* refactor: various fixes

* feat: add option to include params from command line

* refactor: clean docs and refactor code

* fix: tests

* refactor: parse all the metadata again

* refactor: reorganize and clean metadata functions

* feat: display specific use cases to the user

* refactor: predefined actions

* fix: various fixes

* fix: error message not supported for complex types

* refactor: parse all metadata, including parameters at once

* refactor: clean docs and move code

* fix: format_type

* fix: parse user inputs for Option arguments (#332)

* fix: automatically add some or none to Option argument

* test: refactor and tests

* refactor: improve code and comments

* fix: renaming and clean code

* chore: option params not mandatory

* fix: parse user inputs for Option arguments in constructor (#335)

* fix: automatically add some or none to Option argument

* fix: tests

* refactor: process_function_args

* test: update tests accordingly last changes

* fix: issue with delimiter

* test: fix unit test

* refactor: renaming and fix comments

* refactor: format types (#339)

Shows the full type representation, making it easier to see the entry format of parameter values.

* fix: logo doesn't show in README

---------

Co-authored-by: Frank Bell <[email protected]>
Co-authored-by: Alejandro Martinez Andres <[email protected]>

* test: fix unit test

* refactor: clean the way to parse and prompt parameters

* feat: add Purchase on-demand coretime use cases

* test: add skip_confirm, move when prompt for the signer and create the integration test

* test: call parachain ui unit test

* refactor: separate structs

* fmt

* test: pop-cli unit testing

* test: pop-common unit tests

* test: parse metadata unit tests

* test: refactor and test processing parameters

* test: comments and unit test in call functions

* fix: clippy warnings

* chore: fmt

* fix: solve conflicts and unit tests (#359)

* test: call parachain ui unit test

* test: pop-cli unit testing

* test: pop-common unit tests

* test: parse metadata unit tests

* test: refactor and test processing parameters

* test: comments and unit test in call functions

* fix: clippy warnings

* chore: fmt

* fix: conflicts and unit tests

* test: remove test and improve test

* feat: guide user for calling a contract

* feat: get metadata contract from the contract path

* refactor: refactor test and validate address input

* fix: apply feedback

* feat: prompt to have another call and skip questions for queries

* refactor: use Cli module instead of cliclack

* test: unit test pop-cli crate

* test: unit contracts crate

* chore: format

* test: refactor and improve test cases

* fix: fix todos and refactor

* test: fix unit test

* feat: parse types of parameters and display it to the user in the placeholder

* refactor: error handling for pop call

* refactor: display call to be executed after guide and reorder

* refactor: when repeat call use same contract values and dont clean screen

* test: add dry-run test

* test: refactor and add more test coverage

* test: more coverage

* fix: unit test

* feat: dev mode to skip certain user prompts

* refactor: test functions, renaming and fix clippy

* refactor: improve devex of pop call contract

* test: adjust tests to refactor

* chore: reset_for_new_call fields

* fix: build contract if has not been built

* refactor: use command state (#338)

Merged set_up_call_config and guide_user_to_call_contract into a single function. Also adds short symbols for arguments.

* fix: automatically add some or none to Option argument

* test: refactor and tests

* refactor: improve code and comments

* fix: renaming and clean code

* chore: option params not mandatory

* fix: parse user inputs for Option arguments in constructor (#335)

* fix: automatically add some or none to Option argument

* fix: tests

* refactor: process_function_args

* test: update tests accordingly last changes

* fix: issue with delimiter

* test: fix unit test

* refactor: renaming and fix comments

* refactor: format types (#339)

Shows the full type representation, making it easier to see the entry format of parameter values.

* feat: pop call parachain prototype

* feat: dispaly arguments of extrinsic

* refactor: structure similar to pop call contract

* feat: parse all values for extrinsic/storage

* refactor: signer in common

* refactor: improve messages

* feat: call parachain ui

* fix: calls working

* refactor: remove unused code

* refactor: remove unused code

* refactor: various fixes

* refactor: various fixes

* feat: add option to include params from command line

* refactor: clean docs and refactor code

* fix: tests

* refactor: parse all the metadata again

* refactor: reorganize and clean metadata functions

* feat: display specific use cases to the user

* refactor: predefined actions

* fix: various fixes

* fix: error message not supported for complex types

* refactor: parse all metadata, including parameters at once

* refactor: clean docs and move code

* fix: format_type

* test: fix unit test

* refactor: clean the way to parse and prompt parameters

* feat: add Purchase on-demand coretime use cases

* test: add skip_confirm, move when prompt for the signer and create the integration test

* test: call parachain ui unit test

* test: pop-cli unit testing

* test: pop-common unit tests

* test: parse metadata unit tests

* test: refactor and test processing parameters

* test: comments and unit test in call functions

* fix: clippy warnings

* chore: fmt

* feat: repeat call only if using guide UI

* fix: clippy

* refactor: various improvements

* chore: parser for pallet and extrinsic input names

* refactor: only move to pop_common the needed functions

* refactor: improve test, docs and errors

* test: fix unit tests

* fix: reset_for_new_call when extrinisc is not supported

* fix: build with parachain features

* test: wait before call parachain in integration test

* docs: minor improvements

* test: migrate find_free_port to pop_common

* test: fix increase waiting time

* test: remove unnecesary test case

* refactor: rename api with client

* refactor: naming and docs

* docs: improve docs and missing comments

* test: remove unnecesary verbose

* test: find_free_port

* docs: improve parameter documentation

* test: add missing test to sign_and_submit_extrinsic

* fix: apply feedback from auxiliar PRs, remove unnecesary clones

* docs: public modules

* refactor: clean unused params

* fix: mark all extrinsics that uses calls as parameter as unsupported

* test: fix expect_select

* docs: improve documentation

* feat: submit extrinsic from call_data (#348)

* feat: submit extrinsic from call_data

* test: unit test for initialize_api_client

* test: unit test for send_extrinsic_from_call_data

* fix: CallData struct

* fix: skip_confirm for send_extrinsic_from_call_data

* chore: clippy

* chore: fmt

* refactor: minor doc and naming changes

* refactor: remove unnecesary clones and return early when submit_extrinsic_from_call_data

* chore: fmt

* refactor: split decode_call_data logic outside sign_and_submit_extrinsic_with_call_data

* feat: parse files when the argument values are very big (#363)

* feat: parse files when the argument values are very big

* test: unit test

* chore: fmt

* feat: file logic using the command line

* fix: sequence arguments

* test: fix unit test

* refactor: remove prompting the user if input is file or value

* refactor: parse_extrinsic_arguments

* fix: CI deny

* refactor: reorder Param  derive macros

* test: fix decode_call_data_works unit test

* refactor: use Default derive macro and define constants for test values (#366)

* feat: parse files when the argument values are very big

* chore: fmt

* feat: file logic using the command line

* fix: sequence arguments

* refactor: parse_extrinsic_arguments

* refactor: use Default in pop_parachain structs

* refactor: use Default in CallParachainCommand struct

* refactor: use constant in tests

* chore: fmt and small refactor

* feat: flag sudo to wrap extrinsic (#349)

* feat: submit extrinsic from call_data

* test: unit test for initialize_api_client

* feat: wrap call into a sudo call

* test: add unit test to the new logic

* fix: skip_confirm for send_extrinsic_from_call_data

* chore: clippy

* docs: renaming and improve docs

* test: use force_transfer for testing

* fix: check if sudo exist before prompt the user

* chore: fmt

* chore: fmt

* test: fix wrong assert

* docs: improve comments and output messages

* refactor: split decode_call_data logic outside sign_and_submit_extrinsic_with_call_data

* fix: test construct_sudo_extrinsic_works and formatting

* refactor: various fixes and improvements (#367)

* refactor: sort pallets/dispatchables

* refactor: remove unnecessary async

* fix: resolve issue after rebase

* fix: more async issues after rebase

* refactor: use single constant

* refactor: terminology (#368)

* refactor: terminology

* refactor: simply pallet/function relationship

* fix: amend call_data conflicts after refactor

* refactor: improvements (#370)

* fix: add missing short arg option

* refactor: note that extrinsic wait includes finalization

* refactor: remove clones

* style: formatting

* refactor: make file prompt more generic

* refactor: add missing license headers

* style: formatting

* docs: comments

* docs: comments

* docs: comments

* refactor: reuse existing metadata

* refactor: minimise clones

* docs: comments

* refactor: naming

* docs: fix parameter doc comments

* refactor: address clippy warnings

* refactor: rename parachain with chain as the primary command and retain parachain as an alias (#373)

* refactor: rename parachain with chain in visible messages

* refactor: rename parachain with chain internal code

* chore: solve fmt after rebase

* refactor: small fix, use alias instead aliases

* refactor: rename CallParachain struct into Call

---------

Co-authored-by: Frank Bell <[email protected]>
Co-authored-by: Alejandro Martinez Andres <[email protected]>
Co-authored-by: Daanvdplas <[email protected]>

* feat(wallet-integration): server and API (#362)

* feat(wallet-integration): implement server and API

* feat(wallet-integration): add a few tests to server. Needs more

* refactor(wallet-integration): just use call_data, remove data types

* feat(wallet-integration): add frontend type for flexible serving

* feat(wallet-integration): StateHandler in WalletIntegrationManager. Add terminate method

* refactor(wallet-integration): move to module with pop-cli crate

* feat(wallet-integration): server-side error handling, update port to 9090

* refactor(wallet-integration): restructure server for easier use in thread

* fix(wallet-integration): remove invalid fn `finish`

* docs(wallet-integration): inline comments

* test(wallet-integration): unit tests for wallet-integration server. Add new frontend type

* feat(wallet-integration): two new routes: error and terminate

* refactor(wallet-integration): consistent comments, remove unnecessary code in tests

* feat: add TransactionData::new

* refactor(wallet-integration: shutdown channel error handling, terminate helper, take_error and TranscationData::new tests

* chore: clippy warning

* feat(up-contract): get call data for upload-only and pass to wallet integration -- PoC

* chore: use git branch for cargo contract

* feat(up-contract): handle subxt events better, various improvements

* refactor: reuse pop up logic

* chore: rebase fixes

* refactor: clean after rebase

* fix: cargo.lock after rebase

* refactor: move terminate node into common::contracts

* fix: sp-core not only for contracts

* feat(up-contract): serve HTML from string, fix deployment message on error, cors, and other misc. improvements

* fix: rebase

* chore: deny.toml license

* feat: secure signing logic for pop call contract

* feat: integrate secure signing with pop call contract

* test: adapt pop-cli ui tests

* refactor: clean code

* docs: improve docs functions

* test: ignore failing test (fixed in another PR), and remove println

* fix: import removed by mistake

* feat(up-contract): serve HTML from string, fix deployment message on error, cors, and other misc. improvements

* feat(up-contract): serve HTML from string, fix deployment message on error, cors, and other misc. improvements

* feat(wallet-integration): server and API (#362)

* feat(wallet-integration): implement server and API

* feat(wallet-integration): add a few tests to server. Needs more

* refactor(wallet-integration): just use call_data, remove data types

* feat(wallet-integration): add frontend type for flexible serving

* feat(wallet-integration): StateHandler in WalletIntegrationManager. Add terminate method

* refactor(wallet-integration): move to module with pop-cli crate

* feat(wallet-integration): server-side error handling, update port to 9090

* refactor(wallet-integration): restructure server for easier use in thread

* fix(wallet-integration): remove invalid fn `finish`

* docs(wallet-integration): inline comments

* test(wallet-integration): unit tests for wallet-integration server. Add new frontend type

* feat(wallet-integration): two new routes: error and terminate

* refactor(wallet-integration): consistent comments, remove unnecessary code in tests

* feat: add TransactionData::new

* refactor(wallet-integration: shutdown channel error handling, terminate helper, take_error and TranscationData::new tests

* chore: clippy warning

* feat(up-contract): get call data for upload-only and pass to wallet integration -- PoC

* feat(up-contract): get call data for instantiate and pass to wallet integration -- PoC

* refactor(pop-up): create functions for wallet integration, plus general cleanup

* chore: use git branch for cargo contract

* feat(up-contract): handle subxt events better, various improvements

* feat(wallet-integration): implement server and API

* feat(wallet-integration): add a few tests to server. Needs more

* refactor(wallet-integration): just use call_data, remove data types

* feat(wallet-integration): add frontend type for flexible serving

* feat(wallet-integration): StateHandler in WalletIntegrationManager. Add terminate method

* refactor(wallet-integration): move to module with pop-cli crate

* feat(wallet-integration): server-side error handling, update port to 9090

* refactor(wallet-integration): restructure server for easier use in thread

* fix(wallet-integration): remove invalid fn `finish`

* docs(wallet-integration): inline comments

* test(wallet-integration): unit tests for wallet-integration server. Add new frontend type

* feat(wallet-integration): two new routes: error and terminate

* refactor(wallet-integration): consistent comments, remove unnecessary code in tests

* feat: guide user to call a contract (#306)

* feat: guide user for calling a contract

* feat: get metadata contract from the contract path

* refactor: refactor test and validate address input

* fix: apply feedback

* feat: prompt to have another call and skip questions for queries

* refactor: use Cli module instead of cliclack

* test: unit test pop-cli crate

* test: unit contracts crate

* chore: format

* test: refactor and improve test cases

* fix: fix todos and refactor

* test: fix unit test

* feat: parse types of parameters and display it to the user in the placeholder

* refactor: error handling for pop call

* refactor: display call to be executed after guide and reorder

* refactor: when repeat call use same contract values and dont clean screen

* test: add dry-run test

* test: refactor and add more test coverage

* test: more coverage

* fix: unit test

* feat: dev mode to skip certain user prompts

* refactor: test functions, renaming and fix clippy

* refactor: improve devex of pop call contract

* test: adjust tests to refactor

* chore: reset_for_new_call fields

* fix: build contract if has not been built

* refactor: use command state (#338)

Merged set_up_call_config and guide_user_to_call_contract into a single function. Also adds short symbols for arguments.

* fix: parse user inputs for Option arguments (#332)

* fix: automatically add some or none to Option argument

* test: refactor and tests

* refactor: improve code and comments

* fix: renaming and clean code

* chore: option params not mandatory

* fix: parse user inputs for Option arguments in constructor (#335)

* fix: automatically add some or none to Option argument

* fix: tests

* refactor: process_function_args

* test: update tests accordingly last changes

* fix: issue with delimiter

* test: fix unit test

* refactor: renaming and fix comments

* refactor: format types (#339)

Shows the full type representation, making it easier to see the entry format of parameter values.

* fix: logo doesn't show in README

---------

Co-authored-by: Frank Bell <[email protected]>
Co-authored-by: Alejandro Martinez Andres <[email protected]>

* test: fix unit test

* feat: allow users to specify custom contract metadata files (#347)

* chore: allow the user specify the metadata file to call a contract

* test: unit test to parse metadata from a file

* docs: fix docs

* refactor: ensure_contract_built after user input path

* fix: call contract when metadata file

* fix: remove default_input in contract address

* docs: rename metadata with artifact

* fix: panic at has_contract_been_built

* fix: clippy

* refactor: keep ensure_contract_built as a CallContractCommand function

* fix: ensure_contract_built

* docs: improve comments

* fix: feedback and include wasm file for testing

* fix: clippy

* chore: after build contract prompt the user if the contract is already deployed

* refactor: ensure_contract_built

* refactor: has_contract_been_built function

* docs: fix comments and messages

* refactor: get_messages and get_constructors

* test: fix unit tests call ui

---------

Co-authored-by: Frank Bell <[email protected]>
Co-authored-by: Alejandro Martinez Andres <[email protected]>

* fix: support new substrate-contracts-node structure and stabilize integration tests (#360)

* fix: parse new structure substrate-contracts-node

* fix: paseo+coretime integration test

* fix: sourcing latest version substrate-contracts-node

* refactor: set_executable_permission function

* fix: clippy

* chore: CI configuration

* test: specify port in run_contracts_node

* fix: use random ports instead of hardcoded ones

* feat: guide user to call a parachain (#316)

* feat: guide user for calling a contract

* feat: get metadata contract from the contract path

* refactor: refactor test and validate address input

* fix: apply feedback

* feat: prompt to have another call and skip questions for queries

* refactor: use Cli module instead of cliclack

* test: unit test pop-cli crate

* test: unit contracts crate

* chore: format

* test: refactor and improve test cases

* fix: fix todos and refactor

* test: fix unit test

* feat: parse types of parameters and display it to the user in the placeholder

* refactor: error handling for pop call

* refactor: display call to be executed after guide and reorder

* refactor: when repeat call use same contract values and dont clean screen

* test: add dry-run test

* test: refactor and add more test coverage

* test: more coverage

* fix: unit test

* feat: dev mode to skip certain user prompts

* refactor: test functions, renaming and fix clippy

* refactor: improve devex of pop call contract

* test: adjust tests to refactor

* chore: reset_for_new_call fields

* fix: build contract if has not been built

* refactor: use command state (#338)

Merged set_up_call_config and guide_user_to_call_contract into a single function. Also adds short symbols for arguments.

* fix: automatically add some or none to Option argument

* test: refactor and tests

* refactor: improve code and comments

* fix: renaming and clean code

* chore: option params not mandatory

* fix: parse user inputs for Option arguments in constructor (#335)

* fix: automatically add some or none to Option argument

* fix: tests

* refactor: process_function_args

* test: update tests accordingly last changes

* fix: issue with delimiter

* test: fix unit test

* refactor: renaming and fix comments

* refactor: format types (#339)

Shows the full type representation, making it easier to see the entry format of parameter values.

* fix: logo doesn't show in README

* feat: pop call parachain prototype

* feat: dispaly arguments of extrinsic

* refactor: structure similar to pop call contract

* feat: parse all values for extrinsic/storage

* refactor: signer in common

* refactor: improve messages

* feat: call parachain ui

* fix: calls working

* refactor: remove unused code

* refactor: remove unused code

* refactor: various fixes

* refactor: various fixes

* feat: add option to include params from command line

* refactor: clean docs and refactor code

* fix: tests

* refactor: parse all the metadata again

* refactor: reorganize and clean metadata functions

* feat: display specific use cases to the user

* refactor: predefined actions

* fix: various fixes

* fix: error message not supported for complex types

* refactor: parse all metadata, including parameters at once

* refactor: clean docs and move code

* fix: format_type

* fix: parse user inputs for Option arguments (#332)

* fix: automatically add some or none to Option argument

* test: refactor and tests

* refactor: improve code and comments

* fix: renaming and clean code

* chore: option params not mandatory

* fix: parse user inputs for Option arguments in constructor (#335)

* fix: automatically add some or none to Option argument

* fix: tests

* refactor: process_function_args

* test: update tests accordingly last changes

* fix: issue with delimiter

* test: fix unit test

* refactor: renaming and fix comments

* refactor: format types (#339)

Shows the full type representation, making it easier to see the entry format of parameter values.

* fix: logo doesn't show in README

---------

Co-authored-by: Frank Bell <[email protected]>
Co-authored-by: Alejandro Martinez Andres <[email protected]>

* test: fix unit test

* refactor: clean the way to parse and prompt parameters

* feat: add Purchase on-demand coretime use cases

* test: add skip_confirm, move when prompt for the signer and create the integration test

* test: call parachain ui unit test

* refactor: separate structs

* fmt

* test: pop-cli unit testing

* test: pop-common unit tests

* test: parse metadata unit tests

* test: refactor and test processing parameters

* test: comments and unit test in call functions

* fix: clippy warnings

* chore: fmt

* fix: solve conflicts and unit tests (#359)

* test: call parachain ui unit test

* test: pop-cli unit testing

* test: pop-common unit tests

* test: parse metadata unit tests

* test: refactor and test processing parameters

* test: comments and unit test in call functions

* fix: clippy warnings

* chore: fmt

* fix: conflicts and unit tests

* test: remove test and improve test

* feat: guide user for calling a contract

* feat: get metadata contract from the contract path

* refactor: refactor test and validate address input

* fix: apply feedback

* feat: prompt to have another call and skip questions for queries

* refactor: use Cli module instead of cliclack

* test: unit test pop-cli crate

* test: unit contracts crate

* chore: format

* test: refactor and improve test cases

* fix: fix todos and refactor

* test: fix unit test

* feat: parse types of parameters and display it to the user in the placeholder

* refactor: error handling for pop call

* refactor: display call to be executed after guide and reorder

* refactor: when repeat call use same contract values and dont clean screen

* test: add dry-run test

* test: refactor and add more test coverage

* test: more coverage

* fix: unit test

* feat: dev mode to skip certain user prompts

* refactor: test functions, renaming and fix clippy

* refactor: improve devex of pop call contract

* test: adjust tests to refactor

* chore: reset_for_new_call fields

* fix: build contract if has not been built

* refactor: use command state (#338)

Merged set_up_call_config and guide_user_to_call_contract into a single function. Also adds short symbols for arguments.

* fix: automatically add some or none to Option argument

* test: refactor and tests

* refactor: improve code and comments

* fix: renaming and clean code

* chore: option params not mandatory

* fix: parse user inputs for Option arguments in constructor (#335)

* fix: automatically add some or none to Option argument

* fix: tests

* refactor: process_function_args

* test: update tests accordingly last changes

* fix: issue with delimiter

* test: fix unit test

* refactor: renaming and fix comments

* refactor: format types (#339)

Shows the full type representation, making it easier to see the entry format of parameter values.

* feat: pop call parachain prototype

* feat: dispaly arguments of extrinsic

* refactor: structure similar to pop call contract

* feat: parse all values for extrinsic/storage

* refactor: signer in common

* refactor: improve messages

* feat: call parachain ui

* fix: calls working

* refactor: remove unused code

* refactor: remove unused code

* refactor: various fixes

* refactor: various fixes

* feat: add option to include params from command line

* refactor: clean docs and refactor code

* fix: tests

* refactor: parse all the metadata again

* refactor: reorganize and clean metadata functions

* feat: display specific use cases to the user

* refactor: predefined actions

* fix: various fixes

* fix: error message not supported for complex types

* refactor: parse a…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Daanvdplas Daanvdplas Daanvdplas approved these changes

@evilrobot-01 evilrobot-01 evilrobot-01 approved these changes

@al3mart al3mart al3mart approved these changes

@brunopgalvao brunopgalvao brunopgalvao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: output a live chain spec
5 participants
@AlexD10S @brunopgalvao @al3mart @evilrobot-01 @Daanvdplas